You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/05/04 21:28:35 UTC
[GitHub] [superset] rusackas commented on pull request #14388: chore: [WIP] bumping superset-ui/core, and only importing Emotion from there
rusackas commented on pull request #14388:
URL: https://github.com/apache/superset/pull/14388#issuecomment-832260452
> Nvm, I see that the root cause is actually #14362 . Didn't realize we are creating app just for the menu.
Yep, that PR fixes the acute issue... what I'm confused by is why this PR (which includes 14362) would undo that. In the ephemeral environment on this thread, you can see that the `menu-hash` namespace is not applied for some reason.
Perhaps your Emotion 11 upgrade will fix some of that. When that's safely pulled into Superset, I can rebase this PR and check it again.
Such a juggling act! :D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org