You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by mi...@apache.org on 2011/07/13 19:45:09 UTC

svn commit: r1146155 - in /lucene/dev/branches/fieldtype/lucene/src: java/org/apache/lucene/index/IndexableField.java test/org/apache/lucene/index/TestFieldsReader.java

Author: mikemccand
Date: Wed Jul 13 17:45:09 2011
New Revision: 1146155

URL: http://svn.apache.org/viewvc?rev=1146155&view=rev
Log:
LUCENE-2308: nocommits

Modified:
    lucene/dev/branches/fieldtype/lucene/src/java/org/apache/lucene/index/IndexableField.java
    lucene/dev/branches/fieldtype/lucene/src/test/org/apache/lucene/index/TestFieldsReader.java

Modified: lucene/dev/branches/fieldtype/lucene/src/java/org/apache/lucene/index/IndexableField.java
URL: http://svn.apache.org/viewvc/lucene/dev/branches/fieldtype/lucene/src/java/org/apache/lucene/index/IndexableField.java?rev=1146155&r1=1146154&r2=1146155&view=diff
==============================================================================
--- lucene/dev/branches/fieldtype/lucene/src/java/org/apache/lucene/index/IndexableField.java (original)
+++ lucene/dev/branches/fieldtype/lucene/src/java/org/apache/lucene/index/IndexableField.java Wed Jul 13 17:45:09 2011
@@ -39,9 +39,6 @@ import org.apache.lucene.util.BytesRef;
 // Iterable<IndexableField> that is not a Document
 // instance...
 
-// nocommit -- rename all this stuff -- remove get/is?  --
-// this is all read only APIs
-
 /** @lucene.experimental */
 public interface IndexableField {
   // nocommit: attrs?
@@ -72,7 +69,7 @@ public interface IndexableField {
   public NumericField.DataType numericDataType();
   public Number numericValue();
 
-  // If this returns non-null then we index this field:
+  // If this returns true then we index this field:
   public boolean indexed();
 
   // nocommit maybe remove?  only needed because stored

Modified: lucene/dev/branches/fieldtype/lucene/src/test/org/apache/lucene/index/TestFieldsReader.java
URL: http://svn.apache.org/viewvc/lucene/dev/branches/fieldtype/lucene/src/test/org/apache/lucene/index/TestFieldsReader.java?rev=1146155&r1=1146154&r2=1146155&view=diff
==============================================================================
--- lucene/dev/branches/fieldtype/lucene/src/test/org/apache/lucene/index/TestFieldsReader.java (original)
+++ lucene/dev/branches/fieldtype/lucene/src/test/org/apache/lucene/index/TestFieldsReader.java Wed Jul 13 17:45:09 2011
@@ -554,6 +554,7 @@ public class TestFieldsReader extends Lu
       }
       answers[id] = answer;
       typeAnswers[id] = typeAnswer;
+      // nocommit need to cutover
       doc.add(new NumericField("id", Integer.MAX_VALUE, Field.Store.NO, true).setIntValue(id));
       w.addDocument(doc);
     }