[GitHub] [incubator-devlake] e2corporation commented on a diff in pull request #3165: fix(config-ui): adjust some content about dora

[GitBox <gi...@apache.org>]

e2corporation commented on code in PR #3165:
URL: https://github.com/apache/incubator-devlake/pull/3165#discussion_r977666790


##########
config-ui/src/components/blueprints/transformations/CICD/Deployment.jsx:
##########
@@ -202,95 +190,19 @@ const Deployment = (props) => {
                 <InputGroup
                   id='deploy-tag-production'
                   placeholder='(?i)deploy'
-                  value={transformation?.productionPattern}
+                  value={transformation?.deploymentPattern}
                   onChange={(e) =>
                     onSettingsChange(
-                      { productionPattern: e.target.value },
+                      { deploymentPattern: e.target.value },
                       entityIdKey
                     )
                   }
                   disabled={isSaving}
                   className='input'
                   maxLength={255}
-                  rightElement={
-                    isDeployTagEmpty ? (
-                      <Tooltip
-                        intent={Intent.PRIMARY}
-                        content='Deployment Tag RegEx required'
-                      >
-                        <Icon
-                          icon='warning-sign'
-                          color={Colors.GRAY3}
-                          size={12}
-                          style={{ margin: '8px' }}
-                        />
-                      </Tooltip>
-                    ) : null
-                  }
-                  required
-                />
-              </FormGroup>
-            </div>
-            {/* <div className='formContainer'>

Review Comment:
   @mintsweet These tags are supposed to be re-activated in the future that's why this code was commented and left in tact. Why was it removed?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org