You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by "chenglei (JIRA)" <ji...@apache.org> on 2019/05/23 02:40:00 UTC
[jira] [Comment Edited] (PHOENIX-5292) fix MathTrigFunctionTest
file compile error
[ https://issues.apache.org/jira/browse/PHOENIX-5292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16846384#comment-16846384 ]
chenglei edited comment on PHOENIX-5292 at 5/23/19 2:39 AM:
------------------------------------------------------------
[~yanxinyi], thank your for the fix.
A small suggestion: why you did not put {{MathTrigFunctionTest}} under package {{org.apache.phoenix.expression.function}} ? In consideration of your
SinFunction/CosFunction/TanFunction is under package {{org.apache.phoenix.expression.function}}， put {{MathTrigFunctionTest}} under package {{org.apache.phoenix.expression.function}} is better.
was (Author: comnetwork):
[~yanxinyi], thank your for the fix.
A small suggestion: why you did not put {{MathTrigFunctionTest}} under package {{org.apache.phoenix.expression.function}} ? In consideration of your
SinFunction/CosFunction/TanFunction is under package {{org.apache.phoenix.expression.function}}， put {{MathTrigFunctionTest }} under package {{org.apache.phoenix.expression.function}} is better.
> fix MathTrigFunctionTest file compile error
> --------------------------------------------
>
> Key: PHOENIX-5292
> URL: https://issues.apache.org/jira/browse/PHOENIX-5292
> Project: Phoenix
> Issue Type: Sub-task
> Reporter: Xinyi Yan
> Assignee: Xinyi Yan
> Priority: Minor
> Attachments: PHOENIX-5292-4.x-HBase-1.4.patch
>
>
> {{MathTrigFunctionTest }}causes compile failed on branch 4.x-HBase-1.3 and 4.x-HBase-1.4,
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)