You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/01/28 00:13:43 UTC
[GitHub] [beam] y1chi opened a new pull request #13826: Cherrypick Merge pull request #13797 from [BEAM-11679] Override PubsubUnboundedS…
y1chi opened a new pull request #13826:
URL: https://github.com/apache/beam/pull/13826
…ource transform for dataflow runner v2
[BEAM-11679] Override PubsubUnboundedSource transform for dataflow ru…
**Please** add a meaningful description for your change here
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Dataflow | Flink | Samza | Spark | Twister2
--- | --- | --- | --- | --- | --- | ---
Go | [](https://ci-beam.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/) | ---
Java | [](https://ci-beam.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_VR_Dataflow_V2/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/) | [](https://ci-beam
.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Java11/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Twister2/lastCompletedBuild/)
Python | [](https://ci-beam.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python38/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Python_PVR_Flink_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/) | ---
XLang | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Direct/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Dataflow/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/) | ---
Pre-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
--- |Java | Python | Go | Website | Whitespace | Typescript
--- | --- | --- | --- | --- | --- | ---
Non-portable | [](https://ci-beam.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonDocker_Cron/lastCompletedBuild/) <br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonDocs_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Whitespace_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Typescript_Cron/lastCompletedBuild/)
Portable | --- | [](https://ci-beam.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/) | --- | --- | --- | ---
See [.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md) for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #13826: Cherrypick Merge pull request #13797 from [BEAM-11679] Override PubsubUnboundedS…
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13826:
URL: https://github.com/apache/beam/pull/13826#issuecomment-769384158
# [Codecov](https://codecov.io/gh/apache/beam/pull/13826?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`release-2.28.0@280107a`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/13826?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## release-2.28.0 #13826 +/- ##
=================================================
Coverage ? 82.84%
=================================================
Files ? 466
Lines ? 57632
Branches ? 0
=================================================
Hits ? 47746
Misses ? 9886
Partials ? 0
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/13826?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/13826?src=pr&el=footer). Last update [280107a...3bd01f8](https://codecov.io/gh/apache/beam/pull/13826?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #13826: Cherrypick Merge pull request #13797 from [BEAM-11679] Override PubsubUnboundedS…
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13826:
URL: https://github.com/apache/beam/pull/13826#issuecomment-769384158
# [Codecov](https://codecov.io/gh/apache/beam/pull/13826?src=pr&el=h1) Report
> Merging [#13826](https://codecov.io/gh/apache/beam/pull/13826?src=pr&el=desc) (3bd01f8) into [master](https://codecov.io/gh/apache/beam/commit/297548718cc69ddd30f8c7d1aec6285d6e13ad8c?el=desc) (2975487) will **increase** coverage by `0.05%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/13826?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13826 +/- ##
==========================================
+ Coverage 82.78% 82.83% +0.05%
==========================================
Files 466 466
Lines 57557 57596 +39
==========================================
+ Hits 47647 47710 +63
+ Misses 9910 9886 -24
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/13826?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...eam/runners/portability/fn\_api\_runner/fn\_runner.py](https://codecov.io/gh/apache/beam/pull/13826/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL2ZuX3J1bm5lci5weQ==) | `89.87% <ø> (ø)` | |
| [...apache\_beam/runners/portability/portable\_runner.py](https://codecov.io/gh/apache/beam/pull/13826/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9wb3J0YWJsZV9ydW5uZXIucHk=) | `74.55% <ø> (ø)` | |
| [sdks/python/apache\_beam/utils/interactive\_utils.py](https://codecov.io/gh/apache/beam/pull/13826/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvaW50ZXJhY3RpdmVfdXRpbHMucHk=) | `92.85% <0.00%> (-2.39%)` | :arrow_down: |
| [sdks/python/apache\_beam/internal/metrics/metric.py](https://codecov.io/gh/apache/beam/pull/13826/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW50ZXJuYWwvbWV0cmljcy9tZXRyaWMucHk=) | `86.45% <0.00%> (-1.05%)` | :arrow_down: |
| [.../runners/portability/fn\_api\_runner/translations.py](https://codecov.io/gh/apache/beam/pull/13826/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL3RyYW5zbGF0aW9ucy5weQ==) | `89.11% <0.00%> (-0.62%)` | :arrow_down: |
| [sdks/python/apache\_beam/runners/direct/executor.py](https://codecov.io/gh/apache/beam/pull/13826/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kaXJlY3QvZXhlY3V0b3IucHk=) | `96.29% <0.00%> (-0.53%)` | :arrow_down: |
| [...ks/python/apache\_beam/runners/worker/sdk\_worker.py](https://codecov.io/gh/apache/beam/pull/13826/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvc2RrX3dvcmtlci5weQ==) | `89.69% <0.00%> (-0.16%)` | :arrow_down: |
| [...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/13826/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==) | `93.70% <0.00%> (-0.13%)` | :arrow_down: |
| [sdks/python/apache\_beam/transforms/util.py](https://codecov.io/gh/apache/beam/pull/13826/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy91dGlsLnB5) | `95.84% <0.00%> (+0.17%)` | :arrow_up: |
| [...apache\_beam/runners/dataflow/internal/apiclient.py](https://codecov.io/gh/apache/beam/pull/13826/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kYXRhZmxvdy9pbnRlcm5hbC9hcGljbGllbnQucHk=) | `73.48% <0.00%> (+0.34%)` | :arrow_up: |
| ... and [3 more](https://codecov.io/gh/apache/beam/pull/13826/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/13826?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/13826?src=pr&el=footer). Last update [280107a...3bd01f8](https://codecov.io/gh/apache/beam/pull/13826?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #13826: Cherrypick Merge pull request #13797 from [BEAM-11679] Override PubsubUnboundedS…
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13826:
URL: https://github.com/apache/beam/pull/13826#issuecomment-769384158
# [Codecov](https://codecov.io/gh/apache/beam/pull/13826?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`release-2.28.0@280107a`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/13826?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## release-2.28.0 #13826 +/- ##
=================================================
Coverage ? 82.83%
=================================================
Files ? 466
Lines ? 57596
Branches ? 0
=================================================
Hits ? 47710
Misses ? 9886
Partials ? 0
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/13826?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/13826?src=pr&el=footer). Last update [280107a...3bd01f8](https://codecov.io/gh/apache/beam/pull/13826?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #13826: Cherrypick Merge pull request #13797 from [BEAM-11679] Override PubsubUnboundedS…
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13826:
URL: https://github.com/apache/beam/pull/13826#issuecomment-769384158
# [Codecov](https://codecov.io/gh/apache/beam/pull/13826?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`release-2.28.0@280107a`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/13826?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## release-2.28.0 #13826 +/- ##
=================================================
Coverage ? 82.83%
=================================================
Files ? 466
Lines ? 57596
Branches ? 0
=================================================
Hits ? 47710
Misses ? 9886
Partials ? 0
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/13826?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/13826?src=pr&el=footer). Last update [280107a...3bd01f8](https://codecov.io/gh/apache/beam/pull/13826?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] chamikaramj commented on pull request #13826: Cherrypick Merge pull request #13797 from [BEAM-11679] Override PubsubUnboundedS…
Posted by GitBox <gi...@apache.org>.
chamikaramj commented on pull request #13826:
URL: https://github.com/apache/beam/pull/13826#issuecomment-768706533
Run Java PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #13826: Cherrypick Merge pull request #13797 from [BEAM-11679] Override PubsubUnboundedS…
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13826:
URL: https://github.com/apache/beam/pull/13826#issuecomment-769384158
# [Codecov](https://codecov.io/gh/apache/beam/pull/13826?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`release-2.28.0@280107a`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/13826?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## release-2.28.0 #13826 +/- ##
=================================================
Coverage ? 82.84%
=================================================
Files ? 466
Lines ? 57632
Branches ? 0
=================================================
Hits ? 47746
Misses ? 9886
Partials ? 0
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/13826?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/13826?src=pr&el=footer). Last update [280107a...3bd01f8](https://codecov.io/gh/apache/beam/pull/13826?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] chamikaramj commented on pull request #13826: Cherrypick Merge pull request #13797 from [BEAM-11679] Override PubsubUnboundedS…
Posted by GitBox <gi...@apache.org>.
chamikaramj commented on pull request #13826:
URL: https://github.com/apache/beam/pull/13826#issuecomment-770070989
Run Java PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #13826: Cherrypick Merge pull request #13797 from [BEAM-11679] Override PubsubUnboundedS…
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13826:
URL: https://github.com/apache/beam/pull/13826#issuecomment-769384158
# [Codecov](https://codecov.io/gh/apache/beam/pull/13826?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`release-2.28.0@280107a`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/13826?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## release-2.28.0 #13826 +/- ##
=================================================
Coverage ? 82.84%
=================================================
Files ? 466
Lines ? 57632
Branches ? 0
=================================================
Hits ? 47746
Misses ? 9886
Partials ? 0
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/13826?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/13826?src=pr&el=footer). Last update [280107a...3bd01f8](https://codecov.io/gh/apache/beam/pull/13826?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] chamikaramj commented on pull request #13826: Cherrypick Merge pull request #13797 from [BEAM-11679] Override PubsubUnboundedS…
Posted by GitBox <gi...@apache.org>.
chamikaramj commented on pull request #13826:
URL: https://github.com/apache/beam/pull/13826#issuecomment-769370322
Run Python PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #13826: Cherrypick Merge pull request #13797 from [BEAM-11679] Override PubsubUnboundedS…
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13826:
URL: https://github.com/apache/beam/pull/13826#issuecomment-769384158
# [Codecov](https://codecov.io/gh/apache/beam/pull/13826?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`release-2.28.0@280107a`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/13826?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## release-2.28.0 #13826 +/- ##
=================================================
Coverage ? 82.83%
=================================================
Files ? 466
Lines ? 57596
Branches ? 0
=================================================
Hits ? 47710
Misses ? 9886
Partials ? 0
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/13826?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/13826?src=pr&el=footer). Last update [280107a...3bd01f8](https://codecov.io/gh/apache/beam/pull/13826?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #13826: Cherrypick Merge pull request #13797 from [BEAM-11679] Override PubsubUnboundedS…
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13826:
URL: https://github.com/apache/beam/pull/13826#issuecomment-769384158
# [Codecov](https://codecov.io/gh/apache/beam/pull/13826?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`release-2.28.0@280107a`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/13826?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## release-2.28.0 #13826 +/- ##
=================================================
Coverage ? 82.84%
=================================================
Files ? 466
Lines ? 57632
Branches ? 0
=================================================
Hits ? 47746
Misses ? 9886
Partials ? 0
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/13826?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/13826?src=pr&el=footer). Last update [280107a...3bd01f8](https://codecov.io/gh/apache/beam/pull/13826?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] chamikaramj commented on pull request #13826: Cherrypick Merge pull request #13797 from [BEAM-11679] Override PubsubUnboundedS…
Posted by GitBox <gi...@apache.org>.
chamikaramj commented on pull request #13826:
URL: https://github.com/apache/beam/pull/13826#issuecomment-769405709
I think the PR is incorrect. It says "into apache:master" but should be "into apache:release-2.28.0"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #13826: Cherrypick Merge pull request #13797 from [BEAM-11679] Override PubsubUnboundedS…
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13826:
URL: https://github.com/apache/beam/pull/13826#issuecomment-769384158
# [Codecov](https://codecov.io/gh/apache/beam/pull/13826?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`release-2.28.0@280107a`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/13826?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## release-2.28.0 #13826 +/- ##
=================================================
Coverage ? 82.84%
=================================================
Files ? 466
Lines ? 57632
Branches ? 0
=================================================
Hits ? 47746
Misses ? 9886
Partials ? 0
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/13826?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/13826?src=pr&el=footer). Last update [280107a...3bd01f8](https://codecov.io/gh/apache/beam/pull/13826?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] commented on pull request #13826: Cherrypick Merge pull request #13797 from [BEAM-11679] Override PubsubUnboundedS…
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #13826:
URL: https://github.com/apache/beam/pull/13826#issuecomment-769384158
# [Codecov](https://codecov.io/gh/apache/beam/pull/13826?src=pr&el=h1) Report
> Merging [#13826](https://codecov.io/gh/apache/beam/pull/13826?src=pr&el=desc) (3bd01f8) into [master](https://codecov.io/gh/apache/beam/commit/297548718cc69ddd30f8c7d1aec6285d6e13ad8c?el=desc) (2975487) will **increase** coverage by `0.05%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/13826?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13826 +/- ##
==========================================
+ Coverage 82.78% 82.83% +0.05%
==========================================
Files 466 466
Lines 57557 57596 +39
==========================================
+ Hits 47647 47710 +63
+ Misses 9910 9886 -24
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/13826?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...eam/runners/portability/fn\_api\_runner/fn\_runner.py](https://codecov.io/gh/apache/beam/pull/13826/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL2ZuX3J1bm5lci5weQ==) | `89.87% <ø> (ø)` | |
| [...apache\_beam/runners/portability/portable\_runner.py](https://codecov.io/gh/apache/beam/pull/13826/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9wb3J0YWJsZV9ydW5uZXIucHk=) | `74.55% <ø> (ø)` | |
| [sdks/python/apache\_beam/utils/interactive\_utils.py](https://codecov.io/gh/apache/beam/pull/13826/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvaW50ZXJhY3RpdmVfdXRpbHMucHk=) | `92.85% <0.00%> (-2.39%)` | :arrow_down: |
| [sdks/python/apache\_beam/internal/metrics/metric.py](https://codecov.io/gh/apache/beam/pull/13826/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW50ZXJuYWwvbWV0cmljcy9tZXRyaWMucHk=) | `86.45% <0.00%> (-1.05%)` | :arrow_down: |
| [.../runners/portability/fn\_api\_runner/translations.py](https://codecov.io/gh/apache/beam/pull/13826/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL3RyYW5zbGF0aW9ucy5weQ==) | `89.11% <0.00%> (-0.62%)` | :arrow_down: |
| [sdks/python/apache\_beam/runners/direct/executor.py](https://codecov.io/gh/apache/beam/pull/13826/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kaXJlY3QvZXhlY3V0b3IucHk=) | `96.29% <0.00%> (-0.53%)` | :arrow_down: |
| [...ks/python/apache\_beam/runners/worker/sdk\_worker.py](https://codecov.io/gh/apache/beam/pull/13826/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvc2RrX3dvcmtlci5weQ==) | `89.69% <0.00%> (-0.16%)` | :arrow_down: |
| [...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/13826/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==) | `93.70% <0.00%> (-0.13%)` | :arrow_down: |
| [sdks/python/apache\_beam/transforms/util.py](https://codecov.io/gh/apache/beam/pull/13826/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy91dGlsLnB5) | `95.84% <0.00%> (+0.17%)` | :arrow_up: |
| [...apache\_beam/runners/dataflow/internal/apiclient.py](https://codecov.io/gh/apache/beam/pull/13826/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kYXRhZmxvdy9pbnRlcm5hbC9hcGljbGllbnQucHk=) | `73.48% <0.00%> (+0.34%)` | :arrow_up: |
| ... and [3 more](https://codecov.io/gh/apache/beam/pull/13826/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/13826?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/13826?src=pr&el=footer). Last update [280107a...3bd01f8](https://codecov.io/gh/apache/beam/pull/13826?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #13826: Cherrypick Merge pull request #13797 from [BEAM-11679] Override PubsubUnboundedS…
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13826:
URL: https://github.com/apache/beam/pull/13826#issuecomment-769384158
# [Codecov](https://codecov.io/gh/apache/beam/pull/13826?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`release-2.28.0@280107a`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/13826?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## release-2.28.0 #13826 +/- ##
=================================================
Coverage ? 82.84%
=================================================
Files ? 466
Lines ? 57632
Branches ? 0
=================================================
Hits ? 47746
Misses ? 9886
Partials ? 0
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/13826?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/13826?src=pr&el=footer). Last update [280107a...3bd01f8](https://codecov.io/gh/apache/beam/pull/13826?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] chamikaramj commented on pull request #13826: Cherrypick Merge pull request #13797 from [BEAM-11679] Override PubsubUnboundedS…
Posted by GitBox <gi...@apache.org>.
chamikaramj commented on pull request #13826:
URL: https://github.com/apache/beam/pull/13826#issuecomment-770071619
Python failure is unrelated (Dataflow worker images are not available yet).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] y1chi commented on pull request #13826: Cherrypick Merge pull request #13797 from [BEAM-11679] Override PubsubUnboundedS…
Posted by GitBox <gi...@apache.org>.
y1chi commented on pull request #13826:
URL: https://github.com/apache/beam/pull/13826#issuecomment-768663189
R: @chamikaramj
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] chamikaramj commented on pull request #13826: Cherrypick Merge pull request #13797 from [BEAM-11679] Override PubsubUnboundedS…
Posted by GitBox <gi...@apache.org>.
chamikaramj commented on pull request #13826:
URL: https://github.com/apache/beam/pull/13826#issuecomment-769369686
Run Java PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] chamikaramj commented on pull request #13826: Cherrypick Merge pull request #13797 from [BEAM-11679] Override PubsubUnboundedS…
Posted by GitBox <gi...@apache.org>.
chamikaramj commented on pull request #13826:
URL: https://github.com/apache/beam/pull/13826#issuecomment-770107262
Run Java PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #13826: Cherrypick Merge pull request #13797 from [BEAM-11679] Override PubsubUnboundedS…
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13826:
URL: https://github.com/apache/beam/pull/13826#issuecomment-769384158
# [Codecov](https://codecov.io/gh/apache/beam/pull/13826?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`release-2.28.0@280107a`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/13826?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## release-2.28.0 #13826 +/- ##
=================================================
Coverage ? 82.84%
=================================================
Files ? 466
Lines ? 57632
Branches ? 0
=================================================
Hits ? 47746
Misses ? 9886
Partials ? 0
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/13826?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/13826?src=pr&el=footer). Last update [280107a...3bd01f8](https://codecov.io/gh/apache/beam/pull/13826?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] chamikaramj merged pull request #13826: Cherrypick Merge pull request #13797 from [BEAM-11679] Override PubsubUnboundedS…
Posted by GitBox <gi...@apache.org>.
chamikaramj merged pull request #13826:
URL: https://github.com/apache/beam/pull/13826
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org