[GitHub] [fluo-muchos] ctubbsii commented on a change in pull request #316: Add support for ZooKeeper 3.5

[GitBox <gi...@apache.org>]

ctubbsii commented on a change in pull request #316: Add support for ZooKeeper 3.5
URL: https://github.com/apache/fluo-muchos/pull/316#discussion_r372161473
 
 

 ##########
 File path: ansible/roles/zookeeper/templates/zoo.cfg
 ##########
 @@ -15,6 +15,10 @@ clientPort={{ zookeeper_client_port }}
 # the maximum number of client connections.
 # increase this if you need to handle more clients
 maxClientCnxns=100
+# support zk monitoring
+{% if zookeeper_version.startswith('3.5') %}
+4lw.commands.whitelist=mntr
+{% endif %}
 
 Review comment:
   I assume this config was added new in 3.5, but it is probably ignored in earlier versions. If so, there's probably not a need for the conditional, and I would instead just put update the comment:
   
   ```ini
   # support zk monitoring (for zk >= 3.5)
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services