You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by halton <gi...@git.apache.org> on 2017/06/14 21:28:25 UTC
[GitHub] cordova-mobile-spec pull request #144: Use path.sep instead of Unix separato...
GitHub user halton opened a pull request:
https://github.com/apache/cordova-mobile-spec/pull/144
Use path.sep instead of Unix separator.
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist
is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
### What does this PR do?
Fix the unix format patch on Windows host
### What testing has been done on this change?
jshint
### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [ ] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/halton/cordova-mobile-spec sep
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-mobile-spec/pull/144.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #144
----
commit 3088eb80c8fddaea1a18f0b11a7981dfe726c8fb
Author: Halton Huo <ha...@intel.com>
Date: 2017-06-14T18:35:04Z
CB-12920 Use path.sep instead of Unix seperator.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-mobile-spec issue #144: Use path.sep instead of Unix separator.
Posted by filmaj <gi...@git.apache.org>.
Github user filmaj commented on the issue:
https://github.com/apache/cordova-mobile-spec/pull/144
Thank you very much for the PR!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-mobile-spec pull request #144: Use path.sep instead of Unix separato...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-mobile-spec/pull/144
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-mobile-spec pull request #144: Use path.sep instead of Unix separato...
Posted by halton <gi...@git.apache.org>.
Github user halton commented on a diff in the pull request:
https://github.com/apache/cordova-mobile-spec/pull/144#discussion_r122075324
--- Diff: createmobilespec/createmobilespec.js ---
@@ -365,7 +365,7 @@ shelljs.config.fatal = true;
if (argv.clearnpmcache) {
// clean out cached platforms and plugins and app-hello-world
var home_dir = process.env.HOME || process.env.HOMEPATH || process.env.USERPROFILE;
- shelljs.rm("-rf", path.join(home_dir, ".cordova/npm_cache"));
+ shelljs.rm("-rf", path.join(home_dir, ".cordova" + path.sep + "npm_cache"));
--- End diff --
Updated and pushed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-mobile-spec pull request #144: Use path.sep instead of Unix separato...
Posted by filmaj <gi...@git.apache.org>.
Github user filmaj commented on a diff in the pull request:
https://github.com/apache/cordova-mobile-spec/pull/144#discussion_r122072468
--- Diff: createmobilespec/createmobilespec.js ---
@@ -365,7 +365,7 @@ shelljs.config.fatal = true;
if (argv.clearnpmcache) {
// clean out cached platforms and plugins and app-hello-world
var home_dir = process.env.HOME || process.env.HOMEPATH || process.env.USERPROFILE;
- shelljs.rm("-rf", path.join(home_dir, ".cordova/npm_cache"));
+ shelljs.rm("-rf", path.join(home_dir, ".cordova" + path.sep + "npm_cache"));
--- End diff --
you can just use provide ".cordova" and "npm_cache" as separate arguments to `path.join` here - `join` will handle using the proper separator.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org