You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/07/03 21:05:15 UTC
[GitHub] [incubator-superset] codecov-io commented on issue #7653: [schema]
Deprecating the table_columns.database_expression column
codecov-io commented on issue #7653: [schema] Deprecating the table_columns.database_expression column
URL: https://github.com/apache/incubator-superset/pull/7653#issuecomment-508254650
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/7653?src=pr&el=h1) Report
> Merging [#7653](https://codecov.io/gh/apache/incubator-superset/pull/7653?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/0125ba40ef31790fddbd8cd156e9d39ce532c051?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/7653?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7653 +/- ##
==========================================
- Coverage 65.89% 65.89% -0.01%
==========================================
Files 459 459
Lines 22016 22013 -3
Branches 2417 2417
==========================================
- Hits 14507 14505 -2
+ Misses 7388 7387 -1
Partials 121 121
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/7653?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/connectors/base/models.py](https://codecov.io/gh/apache/incubator-superset/pull/7653/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL21vZGVscy5weQ==) | `89.89% <ø> (ø)` | :arrow_up: |
| [...uperset/assets/src/datasource/DatasourceEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/7653/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXRhc291cmNlL0RhdGFzb3VyY2VFZGl0b3IuanN4) | `61.84% <ø> (ø)` | :arrow_up: |
| [superset/connectors/sqla/views.py](https://codecov.io/gh/apache/incubator-superset/pull/7653/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL3ZpZXdzLnB5) | `65.28% <ø> (ø)` | :arrow_up: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/7653/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `82.48% <100%> (+0.08%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/7653?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/7653?src=pr&el=footer). Last update [0125ba4...970e4c4](https://codecov.io/gh/apache/incubator-superset/pull/7653?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org