You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/01/13 09:50:07 UTC
[GitHub] [pulsar-client-go] GPrabhudas opened a new pull request #708: Encryption failure test case fix
GPrabhudas opened a new pull request #708:
URL: https://github.com/apache/pulsar-client-go/pull/708
address issue: https://github.com/apache/pulsar-client-go/issues/707
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-go] wolfstudy commented on a change in pull request #708: Encryption failure test case fix
Posted by GitBox <gi...@apache.org>.
wolfstudy commented on a change in pull request #708:
URL: https://github.com/apache/pulsar-client-go/pull/708#discussion_r785603239
##########
File path: pulsar/producer_impl.go
##########
@@ -124,6 +126,25 @@ func newProducer(client *client, options *ProducerOptions) (*producer, error) {
}
}
+ encryption := options.Encryption
+ // add default message crypto if not provided
+ if encryption != nil && len(encryption.Keys) > 0 {
+ if encryption.KeyReader == nil {
Review comment:
It seems that there is no similar check in `newConsumer` and `newReader`, do they not need it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-go] wolfstudy merged pull request #708: Encryption failure test case fix
Posted by GitBox <gi...@apache.org>.
wolfstudy merged pull request #708:
URL: https://github.com/apache/pulsar-client-go/pull/708
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-go] GPrabhudas commented on a change in pull request #708: Encryption failure test case fix
Posted by GitBox <gi...@apache.org>.
GPrabhudas commented on a change in pull request #708:
URL: https://github.com/apache/pulsar-client-go/pull/708#discussion_r785609848
##########
File path: pulsar/producer_impl.go
##########
@@ -124,6 +126,25 @@ func newProducer(client *client, options *ProducerOptions) (*producer, error) {
}
}
+ encryption := options.Encryption
+ // add default message crypto if not provided
+ if encryption != nil && len(encryption.Keys) > 0 {
+ if encryption.KeyReader == nil {
Review comment:
Similar check is not needed on consumer/reader side.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org