Re: [PR] Fix internal error "Physical input schema should be the same as the one converted from logical input schema." [datafusion]

["alamb (via GitHub)" <gi...@apache.org>]

alamb commented on code in PR #18412:
URL: https://github.com/apache/datafusion/pull/18412#discussion_r2666123593


##########
datafusion/expr/src/expr_schema.rs:
##########
@@ -698,11 +692,11 @@ impl Expr {
     ///
     /// Otherwise, returns an error if there's a type mismatch between
     /// the window function's signature and the provided arguments.
-    fn data_type_and_nullable_with_window_function(
+    fn window_function_field(
         &self,
         schema: &dyn ExprSchema,
         window_function: &WindowFunction,
-    ) -> Result<(DataType, bool)> {
+    ) -> Result<FieldRef> {

Review Comment:
   the point is to return the entire field, rather than just the DataType and nullability
   
   I think the prior construction is from a time before Fields



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org