You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Wendy Smoak (JIRA)" <ji...@codehaus.org> on 2007/08/15 17:14:47 UTC
[jira] Created: (CONTINUUM-1387) Can't initiate a build of a new
project in continuum until all modules have been checked out
Can't initiate a build of a new project in continuum until all modules have been checked out
--------------------------------------------------------------------------------------------
Key: CONTINUUM-1387
URL: http://jira.codehaus.org/browse/CONTINUUM-1387
Project: Continuum
Issue Type: Bug
Affects Versions: 1.1-beta-1
Reporter: Wendy Smoak
When a multi-module project is added to continuum, a working copy of each module is extracted from subversion.
Typically after adding a project I want to kick off a build.
If I initiate the build before all the modules are extracted, the ones that have not yet been fully extracted will not be queued for build. Only those already fully extracted will be built.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Issue Comment Edited: (CONTINUUM-1387) Can't initiate a
build of a new project in continuum until all modules have been checked out
Posted by "Teodoro Cue Jr. (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/CONTINUUM-1387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_105495 ]
Teodoro Cue Jr. edited comment on CONTINUUM-1387 at 8/23/07 1:18 AM:
---------------------------------------------------------------------
Using Jesse's solution, I was able to add a new remove() method on plexus-taskqueue. Then use that method on DefaultContinuum to remove the task in the checkout queue.
Patch attached. But it is dependent on PLXCOMP-82.
was:
Using Jesse's solution, I was able to add a new remove() method on plexus-taskqueue and used that on DefaultContinuum to remove the task on the checkout queue.
Patch attached. But it is dependent on PLXCOMP-82.
> Can't initiate a build of a new project in continuum until all modules have been checked out
> --------------------------------------------------------------------------------------------
>
> Key: CONTINUUM-1387
> URL: http://jira.codehaus.org/browse/CONTINUUM-1387
> Project: Continuum
> Issue Type: Bug
> Affects Versions: 1.1-beta-1
> Reporter: Wendy Smoak
> Assignee: Teodoro Cue Jr.
> Attachments: CONTINUUM-1387.patch
>
>
> When a multi-module project is added to continuum, a working copy of each module is extracted from subversion.
> Typically after adding a project I want to kick off a build.
> If I initiate the build before all the modules are extracted, the ones that have not yet been fully extracted will not be queued for build. Only those already fully extracted will be built.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (CONTINUUM-1387) Can't initiate a build of a new
project in continuum until all modules have been checked out
Posted by "Maria Odea Ching (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/CONTINUUM-1387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Maria Odea Ching closed CONTINUUM-1387.
---------------------------------------
Resolution: Fixed
Applied patch -r570267. Thanks! :)
> Can't initiate a build of a new project in continuum until all modules have been checked out
> --------------------------------------------------------------------------------------------
>
> Key: CONTINUUM-1387
> URL: http://jira.codehaus.org/browse/CONTINUUM-1387
> Project: Continuum
> Issue Type: Bug
> Affects Versions: 1.1-beta-1
> Reporter: Wendy Smoak
> Assignee: Teodoro Cue Jr.
> Attachments: CONTINUUM-1387.patch
>
>
> When a multi-module project is added to continuum, a working copy of each module is extracted from subversion.
> Typically after adding a project I want to kick off a build.
> If I initiate the build before all the modules are extracted, the ones that have not yet been fully extracted will not be queued for build. Only those already fully extracted will be built.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (CONTINUUM-1387) Can't initiate a build of a new
project in continuum until all modules have been checked out
Posted by "Jesse McConnell (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/CONTINUUM-1387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_105376 ]
Jesse McConnell commented on CONTINUUM-1387:
--------------------------------------------
if there is an easy way to block the build queuing process until continuum has had a change to fully initialize upon adding the project, I would prefer that solution personally..
new queuing structures smell like new features to me and we are in beta for 1.1 :)
but thats just my opinion.
the build process will checkout on an empty project directory, that is how the 'Build Fresh' feature works, it smokes the stuff in that directory and then the build process just checks it back out.
odds are you would be ok just removing that checkout queue check like you were thinking of...could you maybe on the build check if it is in the checkout queue and if it is wack it out of there and then add into the build queue since we know the build process will check it out anyway?
> Can't initiate a build of a new project in continuum until all modules have been checked out
> --------------------------------------------------------------------------------------------
>
> Key: CONTINUUM-1387
> URL: http://jira.codehaus.org/browse/CONTINUUM-1387
> Project: Continuum
> Issue Type: Bug
> Affects Versions: 1.1-beta-1
> Reporter: Wendy Smoak
> Assignee: Teodoro Cue Jr.
>
> When a multi-module project is added to continuum, a working copy of each module is extracted from subversion.
> Typically after adding a project I want to kick off a build.
> If I initiate the build before all the modules are extracted, the ones that have not yet been fully extracted will not be queued for build. Only those already fully extracted will be built.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (CONTINUUM-1387) Can't initiate a build of a new
project in continuum until all modules have been checked out
Posted by "Teodoro Cue Jr. (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/CONTINUUM-1387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_105085 ]
Teodoro Cue Jr. commented on CONTINUUM-1387:
--------------------------------------------
After investigating this for a few hours, I've found out that we can actually do a build even when the project is not yet downloaded. Removing isInCheckoutQueue( project.getId() ) from buildProject() under DefaultContinuum does just that. The adverse effect is that some projects are built without sources. I'm trying to find out how to fix this for now. DefaultBuildController actually checks if the project is downloaded already or not. It then downloads the code if it does not exist.
My other concern is the existence of the same project under the checkout queue. I'm not familiar with the inner workings of the build procedure. Would this actually download the same source twice if the build procedure downloaded the source first then the checkout process encounters the same project in the queue?
> Can't initiate a build of a new project in continuum until all modules have been checked out
> --------------------------------------------------------------------------------------------
>
> Key: CONTINUUM-1387
> URL: http://jira.codehaus.org/browse/CONTINUUM-1387
> Project: Continuum
> Issue Type: Bug
> Affects Versions: 1.1-beta-1
> Reporter: Wendy Smoak
>
> When a multi-module project is added to continuum, a working copy of each module is extracted from subversion.
> Typically after adding a project I want to kick off a build.
> If I initiate the build before all the modules are extracted, the ones that have not yet been fully extracted will not be queued for build. Only those already fully extracted will be built.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (CONTINUUM-1387) Can't initiate a build of a new
project in continuum until all modules have been checked out
Posted by "Teodoro Cue Jr. (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/CONTINUUM-1387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_105385 ]
Teodoro Cue Jr. commented on CONTINUUM-1387:
--------------------------------------------
sounds like a good plan! :) thanks jesse! will try to implement your solution...
> Can't initiate a build of a new project in continuum until all modules have been checked out
> --------------------------------------------------------------------------------------------
>
> Key: CONTINUUM-1387
> URL: http://jira.codehaus.org/browse/CONTINUUM-1387
> Project: Continuum
> Issue Type: Bug
> Affects Versions: 1.1-beta-1
> Reporter: Wendy Smoak
> Assignee: Teodoro Cue Jr.
>
> When a multi-module project is added to continuum, a working copy of each module is extracted from subversion.
> Typically after adding a project I want to kick off a build.
> If I initiate the build before all the modules are extracted, the ones that have not yet been fully extracted will not be queued for build. Only those already fully extracted will be built.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (CONTINUUM-1387) Can't initiate a build of a new
project in continuum until all modules have been checked out
Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/CONTINUUM-1387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_105087 ]
Brett Porter commented on CONTINUUM-1387:
-----------------------------------------
I don't think the build process should download the source (as incheckoutqueue probably also checks for one *in progress*).
is it possible to requeue the build in the build queue if isincheckoutqueue is true instead of just abandoning the build?
> Can't initiate a build of a new project in continuum until all modules have been checked out
> --------------------------------------------------------------------------------------------
>
> Key: CONTINUUM-1387
> URL: http://jira.codehaus.org/browse/CONTINUUM-1387
> Project: Continuum
> Issue Type: Bug
> Affects Versions: 1.1-beta-1
> Reporter: Wendy Smoak
>
> When a multi-module project is added to continuum, a working copy of each module is extracted from subversion.
> Typically after adding a project I want to kick off a build.
> If I initiate the build before all the modules are extracted, the ones that have not yet been fully extracted will not be queued for build. Only those already fully extracted will be built.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (CONTINUUM-1387) Can't initiate a build of a new
project in continuum until all modules have been checked out
Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/CONTINUUM-1387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brett Porter updated CONTINUUM-1387:
------------------------------------
Patch Submitted: [Yes]
> Can't initiate a build of a new project in continuum until all modules have been checked out
> --------------------------------------------------------------------------------------------
>
> Key: CONTINUUM-1387
> URL: http://jira.codehaus.org/browse/CONTINUUM-1387
> Project: Continuum
> Issue Type: Bug
> Affects Versions: 1.1-beta-1
> Reporter: Wendy Smoak
> Assignee: Teodoro Cue Jr.
> Attachments: CONTINUUM-1387.patch
>
>
> When a multi-module project is added to continuum, a working copy of each module is extracted from subversion.
> Typically after adding a project I want to kick off a build.
> If I initiate the build before all the modules are extracted, the ones that have not yet been fully extracted will not be queued for build. Only those already fully extracted will be built.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (CONTINUUM-1387) Can't initiate a build of a new
project in continuum until all modules have been checked out
Posted by "Teodoro Cue Jr. (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/CONTINUUM-1387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Teodoro Cue Jr. updated CONTINUUM-1387:
---------------------------------------
Attachment: CONTINUUM-1387.patch
Using Jesse's solution, I was able to add a new remove() method on plexus-taskqueue and used that on DefaultContinuum to remove the task on the checkout queue.
Patch attached. But it is dependent on PLXCOMP-82.
> Can't initiate a build of a new project in continuum until all modules have been checked out
> --------------------------------------------------------------------------------------------
>
> Key: CONTINUUM-1387
> URL: http://jira.codehaus.org/browse/CONTINUUM-1387
> Project: Continuum
> Issue Type: Bug
> Affects Versions: 1.1-beta-1
> Reporter: Wendy Smoak
> Assignee: Teodoro Cue Jr.
> Attachments: CONTINUUM-1387.patch
>
>
> When a multi-module project is added to continuum, a working copy of each module is extracted from subversion.
> Typically after adding a project I want to kick off a build.
> If I initiate the build before all the modules are extracted, the ones that have not yet been fully extracted will not be queued for build. Only those already fully extracted will be built.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (CONTINUUM-1387) Can't initiate a build of a new
project in continuum until all modules have been checked out
Posted by "Teodoro Cue Jr. (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/CONTINUUM-1387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_105100 ]
Teodoro Cue Jr. commented on CONTINUUM-1387:
--------------------------------------------
That's what I've tried to do. Just put it in the build queue even if isInCheckoutQueue returns true. But the build process would build the project anyway. Source downloaded or not. This is the reason why I discovered that the build process would download the project if the working directory does not exist.
With this, would it be better to make another queue? If isInCheckoutQueue returns true, put the project in the new queue instead of the build queue. The new queue would implement an observer pattern listening to the checkout queue. When a project has been checkout completely, trigger the build by calling DefaultContinuum.buildProject().
> Can't initiate a build of a new project in continuum until all modules have been checked out
> --------------------------------------------------------------------------------------------
>
> Key: CONTINUUM-1387
> URL: http://jira.codehaus.org/browse/CONTINUUM-1387
> Project: Continuum
> Issue Type: Bug
> Affects Versions: 1.1-beta-1
> Reporter: Wendy Smoak
>
> When a multi-module project is added to continuum, a working copy of each module is extracted from subversion.
> Typically after adding a project I want to kick off a build.
> If I initiate the build before all the modules are extracted, the ones that have not yet been fully extracted will not be queued for build. Only those already fully extracted will be built.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (CONTINUUM-1387) Can't initiate a build of a new
project in continuum until all modules have been checked out
Posted by "Emmanuel Venisse (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/CONTINUUM-1387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_104924 ]
Emmanuel Venisse commented on CONTINUUM-1387:
---------------------------------------------
Actually, it isn't a bug but a normal way ;)
The project that isn't fully extracted is in the queue but when you initiate the build, Continuum check if each project is in the que. If it is, Continuum skip it.
We'll look at it if we can improve the process.
> Can't initiate a build of a new project in continuum until all modules have been checked out
> --------------------------------------------------------------------------------------------
>
> Key: CONTINUUM-1387
> URL: http://jira.codehaus.org/browse/CONTINUUM-1387
> Project: Continuum
> Issue Type: Bug
> Affects Versions: 1.1-beta-1
> Reporter: Wendy Smoak
>
> When a multi-module project is added to continuum, a working copy of each module is extracted from subversion.
> Typically after adding a project I want to kick off a build.
> If I initiate the build before all the modules are extracted, the ones that have not yet been fully extracted will not be queued for build. Only those already fully extracted will be built.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (CONTINUUM-1387) Can't initiate a build of a new
project in continuum until all modules have been checked out
Posted by "Teodoro Cue Jr. (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/CONTINUUM-1387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_104973 ]
Teodoro Cue Jr. commented on CONTINUUM-1387:
--------------------------------------------
Chatting with Brett last night, I told him that I've thought of 2 ways to solving this issue.
1. Queue the build process until all the sub modules have been downloaded.
2. Disable the build process while there's something being downloaded.
Brett suggested that we could just re-queue the build if it's still being downloaded.
> Can't initiate a build of a new project in continuum until all modules have been checked out
> --------------------------------------------------------------------------------------------
>
> Key: CONTINUUM-1387
> URL: http://jira.codehaus.org/browse/CONTINUUM-1387
> Project: Continuum
> Issue Type: Bug
> Affects Versions: 1.1-beta-1
> Reporter: Wendy Smoak
>
> When a multi-module project is added to continuum, a working copy of each module is extracted from subversion.
> Typically after adding a project I want to kick off a build.
> If I initiate the build before all the modules are extracted, the ones that have not yet been fully extracted will not be queued for build. Only those already fully extracted will be built.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira