You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Brian FitzGerald <bm...@gmail.com> on 2009/06/29 15:24:32 UTC
SVN with code review workflow
Greetings all,
I am a Web developer with a company who (rightfully so) places a large
amount of importance on code review. For this reason, up to this
point, they have not implemented a traditional version control system,
such as Subversion.
The concern of certain key people in the organization is that putting
SVN in place would mean losing control of the code base in that
developers could simply commit whatever, whenever they wanted, without
going through the highly valued code review process.
I understand their concern, and I have a few ideas about what could be
some potential solutions to our problem, but I wanted to get thoughts
from others about ways they have seen this tackled.
One solution I have heard of large shops using is to have each
developer have their own branch in the repository, so that once their
coding is complete, they would commit to their personal branch. Then,
the code reviewer would perform a commit from the developers branch to
the (and I get hazy about the specifics here) main development branch
(would this need to be a separate repository?).
At this point, the code reviewer could look at all the diffs between
the code in the developers branch, and the code in the main
development branch, and either reject or approve and commit the code.
For updates, developers would grab from the main development
repository (or branch), so that they would always be synced up with
the changes committed (and approved) by other developers.
I have also heard of tools such as Codestriker http://codestriker.sourceforge.net/,
which apparently integrate with SVN and may be valuable in this
process as well.
What solutions have you all seen in action? Thanks in advance for any
other thoughts on the topic.
Thanks,
Brian
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2366421
Re: SVN with code review workflow
Posted by Brian FitzGerald <bm...@gmail.com>.
Thank you very much for redirecting me, Mark. Sorry to have cluttered
the wrong list!
I have sent the post as an email to: users@subversion.tigris.org
All the Best,
Brian
On Jun 29, 11:31 am, Mark Phippard <ma...@gmail.com> wrote:
> Please repost to us...@subversion.tigris.org. This list is about the
> development of Subversion itself.
>
> I'll reply to your post with what I know when I see it on the users@ list.
>
> Mark
>
> On Mon, Jun 29, 2009 at 11:24 AM, Brian
>
>
>
> FitzGerald<bm...@gmail.com> wrote:
> > Greetings all,
>
> > I am a Web developer with a company who (rightfully so) places a large
> > amount of importance on code review. For this reason, up to this
> > point, they have not implemented a traditional version control system,
> > such as Subversion.
>
> > The concern of certain key people in the organization is that putting
> > SVN in place would mean losing control of the code base in that
> > developers could simply commit whatever, whenever they wanted, without
> > going through the highly valued code review process.
>
> > I understand their concern, and I have a few ideas about what could be
> > some potential solutions to our problem, but I wanted to get thoughts
> > from others about ways they have seen this tackled.
>
> > One solution I have heard of large shops using is to have each
> > developer have their own branch in the repository, so that once their
> > coding is complete, they would commit to their personal branch. Then,
> > the code reviewer would perform a commit from the developers branch to
> > the (and I get hazy about the specifics here) main development branch
> > (would this need to be a separate repository?).
>
> > At this point, the code reviewer could look at all the diffs between
> > the code in the developers branch, and the code in the main
> > development branch, and either reject or approve and commit the code.
> > For updates, developers would grab from the main development
> > repository (or branch), so that they would always be synced up with
> > the changes committed (and approved) by other developers.
>
> > I have also heard of tools such as Codestrikerhttp://codestriker.sourceforge.net/,
> > which apparently integrate with SVN and may be valuable in this
> > process as well.
>
> > What solutions have you all seen in action? Thanks in advance for any
> > other thoughts on the topic.
>
> > Thanks,
> > Brian
>
> > ------------------------------------------------------
> >http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessag...
>
> --
> Thanks
>
> Mark Phippardhttp://markphip.blogspot.com/
>
> ------------------------------------------------------http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessag...
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2366431
Re: SVN with code review workflow
Posted by Mark Phippard <ma...@gmail.com>.
Please repost to users@subversion.tigris.org. This list is about the
development of Subversion itself.
I'll reply to your post with what I know when I see it on the users@ list.
Mark
On Mon, Jun 29, 2009 at 11:24 AM, Brian
FitzGerald<bm...@gmail.com> wrote:
> Greetings all,
>
> I am a Web developer with a company who (rightfully so) places a large
> amount of importance on code review. For this reason, up to this
> point, they have not implemented a traditional version control system,
> such as Subversion.
>
> The concern of certain key people in the organization is that putting
> SVN in place would mean losing control of the code base in that
> developers could simply commit whatever, whenever they wanted, without
> going through the highly valued code review process.
>
> I understand their concern, and I have a few ideas about what could be
> some potential solutions to our problem, but I wanted to get thoughts
> from others about ways they have seen this tackled.
>
> One solution I have heard of large shops using is to have each
> developer have their own branch in the repository, so that once their
> coding is complete, they would commit to their personal branch. Then,
> the code reviewer would perform a commit from the developers branch to
> the (and I get hazy about the specifics here) main development branch
> (would this need to be a separate repository?).
>
> At this point, the code reviewer could look at all the diffs between
> the code in the developers branch, and the code in the main
> development branch, and either reject or approve and commit the code.
> For updates, developers would grab from the main development
> repository (or branch), so that they would always be synced up with
> the changes committed (and approved) by other developers.
>
> I have also heard of tools such as Codestriker http://codestriker.sourceforge.net/,
> which apparently integrate with SVN and may be valuable in this
> process as well.
>
> What solutions have you all seen in action? Thanks in advance for any
> other thoughts on the topic.
>
> Thanks,
> Brian
>
> ------------------------------------------------------
> http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2366421
>
--
Thanks
Mark Phippard
http://markphip.blogspot.com/
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2366426