You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Michael Smith (Code Review)" <ge...@cloudera.org> on 2022/08/31 17:17:53 UTC
[Impala-ASF-CR] IMPALA-11464: (Addendum) Skip tests in Ozone
Michael Smith has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18934
Change subject: IMPALA-11464: (Addendum) Skip tests in Ozone
......................................................................
IMPALA-11464: (Addendum) Skip tests in Ozone
Updates the skip for new recursive listing tests to match the comment so
that they're only run on HDFS. The previous skip only roughly matched
the set of all non-HDFS filesystems, and didn't automatically include
new filesystems.
Change-Id: I80de83d506138b57a969258b2f6dcf112dd2e44d
---
M tests/common/skip.py
M tests/metadata/test_recursive_listing.py
2 files changed, 5 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/34/18934/1
--
To view, visit http://gerrit.cloudera.org:8080/18934
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I80de83d506138b57a969258b2f6dcf112dd2e44d
Gerrit-Change-Number: 18934
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-11464: (Addendum) Skip tests in Ozone
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18934 )
Change subject: IMPALA-11464: (Addendum) Skip tests in Ozone
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/11273/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18934
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I80de83d506138b57a969258b2f6dcf112dd2e44d
Gerrit-Change-Number: 18934
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 31 Aug 2022 17:38:21 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11464: (Addendum) Skip tests in Ozone
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18934 )
Change subject: IMPALA-11464: (Addendum) Skip tests in Ozone
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18934
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I80de83d506138b57a969258b2f6dcf112dd2e44d
Gerrit-Change-Number: 18934
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Thu, 01 Sep 2022 05:02:48 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11464: (Addendum) Skip tests in Ozone
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18934 )
Change subject: IMPALA-11464: (Addendum) Skip tests in Ozone
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18934
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I80de83d506138b57a969258b2f6dcf112dd2e44d
Gerrit-Change-Number: 18934
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Thu, 01 Sep 2022 05:02:15 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11464: (Addendum) Skip tests in Ozone
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18934 )
Change subject: IMPALA-11464: (Addendum) Skip tests in Ozone
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8519/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/18934
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I80de83d506138b57a969258b2f6dcf112dd2e44d
Gerrit-Change-Number: 18934
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Thu, 01 Sep 2022 05:02:48 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11464: (Addendum) Skip tests in Ozone
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18934 )
Change subject: IMPALA-11464: (Addendum) Skip tests in Ozone
......................................................................
IMPALA-11464: (Addendum) Skip tests in Ozone
Updates the skip for new recursive listing tests to match the comment so
that they're only run on HDFS. The previous skip only roughly matched
the set of all non-HDFS filesystems, and didn't automatically include
new filesystems.
Change-Id: I80de83d506138b57a969258b2f6dcf112dd2e44d
Reviewed-on: http://gerrit.cloudera.org:8080/18934
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M tests/common/skip.py
M tests/metadata/test_recursive_listing.py
2 files changed, 5 insertions(+), 4 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/18934
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I80de83d506138b57a969258b2f6dcf112dd2e44d
Gerrit-Change-Number: 18934
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
[Impala-ASF-CR] IMPALA-11464: (Addendum) Skip tests in Ozone
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18934 )
Change subject: IMPALA-11464: (Addendum) Skip tests in Ozone
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/18934
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I80de83d506138b57a969258b2f6dcf112dd2e44d
Gerrit-Change-Number: 18934
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Thu, 01 Sep 2022 09:53:15 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11464: (Addendum) Skip tests in Ozone
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18934 )
Change subject: IMPALA-11464: (Addendum) Skip tests in Ozone
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18934/1/tests/metadata/test_recursive_listing.py
File tests/metadata/test_recursive_listing.py:
http://gerrit.cloudera.org:8080/#/c/18934/1/tests/metadata/test_recursive_listing.py@144
PS1, Line 144: @SkipIfFS.no_partial_listing
I'm not sure if Ozone supports partial listing. test_large_staging_dirs passes for Ozone, but test_partition_dir_removed_inflight consistently fails. It seemed like Ozone takes awhile to delete the files (1.5 seconds according to the logs) but I couldn't find a timing that made it work.
--
To view, visit http://gerrit.cloudera.org:8080/18934
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I80de83d506138b57a969258b2f6dcf112dd2e44d
Gerrit-Change-Number: 18934
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Wed, 31 Aug 2022 17:19:17 +0000
Gerrit-HasComments: Yes