You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Giridharan Kesavan (Created) (JIRA)" <ji...@apache.org> on 2011/11/16 21:01:51 UTC
[jira] [Created] (ZOOKEEPER-1301) backport patches related to the
zk startup script from 3.4 to 3.3 release
backport patches related to the zk startup script from 3.4 to 3.3 release
--------------------------------------------------------------------------
Key: ZOOKEEPER-1301
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1301
Project: ZooKeeper
Issue Type: Improvement
Affects Versions: 3.3.4
Reporter: Giridharan Kesavan
Assignee: Giridharan Kesavan
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1301) backport patches related to the
zk startup script from 3.4 to 3.3 release
Posted by "Mahadev konar (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13151671#comment-13151671 ]
Mahadev konar commented on ZOOKEEPER-1301:
------------------------------------------
Looking at the patch, I think we should do this:
3) looks fine to me (giri can you just add an echo statement as roman mentioned)
1) giri already fixed.
2) lets revert
4) lets revert
> backport patches related to the zk startup script from 3.4 to 3.3 release
> --------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1301
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1301
> Project: ZooKeeper
> Issue Type: Improvement
> Affects Versions: 3.3.4
> Reporter: Giridharan Kesavan
> Assignee: Giridharan Kesavan
> Attachments: zookeeper-1301-1.patch, zookeeper-1301.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1301) backport patches related to the
zk startup script from 3.4 to 3.3 release
Posted by "Patrick Hunt (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13151669#comment-13151669 ]
Patrick Hunt commented on ZOOKEEPER-1301:
-----------------------------------------
Here's my suggestion. Giri lmk if this makes sense for you.
1) update this patch to drop 2/3/4 changes
2) create new jira(s) for 2/3/4 against 3.3.5/3.4.1/3.5.0(trunk) in order to get those fixed/addressed in later versions.
Giri can you do 1 & 2? Subsequently i'll review this patch for commit in 3.3.4
Thanks!
> backport patches related to the zk startup script from 3.4 to 3.3 release
> --------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1301
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1301
> Project: ZooKeeper
> Issue Type: Improvement
> Affects Versions: 3.3.4
> Reporter: Giridharan Kesavan
> Assignee: Giridharan Kesavan
> Attachments: zookeeper-1301-1.patch, zookeeper-1301.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1301) backport patches related to the
zk startup script from 3.4 to 3.3 release
Posted by "Patrick Hunt (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13151817#comment-13151817 ]
Patrick Hunt commented on ZOOKEEPER-1301:
-----------------------------------------
+1 looks good to me as well.
> backport patches related to the zk startup script from 3.4 to 3.3 release
> --------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1301
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1301
> Project: ZooKeeper
> Issue Type: Improvement
> Affects Versions: 3.3.4
> Reporter: Giridharan Kesavan
> Assignee: Giridharan Kesavan
> Attachments: zookeeper-1301-1.patch, zookeeper-1301-2.patch, zookeeper-1301.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1301) backport patches related to the
zk startup script from 3.4 to 3.3 release
Posted by "Patrick Hunt (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13151672#comment-13151672 ]
Patrick Hunt commented on ZOOKEEPER-1301:
-----------------------------------------
sounds good.
> backport patches related to the zk startup script from 3.4 to 3.3 release
> --------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1301
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1301
> Project: ZooKeeper
> Issue Type: Improvement
> Affects Versions: 3.3.4
> Reporter: Giridharan Kesavan
> Assignee: Giridharan Kesavan
> Attachments: zookeeper-1301-1.patch, zookeeper-1301.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1301) backport patches related to the
zk startup script from 3.4 to 3.3 release
Posted by "Roman Shaposhnik (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13151575#comment-13151575 ]
Roman Shaposhnik commented on ZOOKEEPER-1301:
---------------------------------------------
I have a couple of concerns regarding the attached code
1. This has to be fixed:
{noformat}
-dataDir=/export/crawlspace/mahadev/zookeeper/server1/data
+dataDir=/home/tdunning/tmp
{noformat}
2. I'm not sure why -f was dropped (in fact it might actually break some ZK deployments)
{noformat}
-if readlink -f "$0" > /dev/null 2>&1
+if readlink "$0" > /dev/null 2>&1
{noformat}
3. I'm really nervous about changing user requests like this without at least a diagnostic message:
{noformat}
+# if we give a more complicated path to the config, don't screw around in $ZOOCFGDIR
+if [ "x`dirname $ZOOCFG`" != "x$ZOOCFGDIR" ]
+then
+ ZOOCFG="$2"
+fi
+
{noformat}
4. I'm not sure I understand the logic of creating ZOO_DATADIR ONLY when ZOOPIDFILE is not defined. In fact,
I a production deployment any attempt at mkdir $ZOO_DATADIR/mkdir -p $(dirname "$ZOOPIDFILE") is very likely
to fail and hence these at least need to be handled gracefully.
{noformat}
+if [ -z $ZOOPIDFILE ]; then
+ ZOO_DATADIR=$(grep "^[[:space:]]*dataDir" "$ZOOCFG" | sed -e 's/.*=//')
+ if [ ! -d "$ZOO_DATADIR" ]; then
+ mkdir -p "$ZOO_DATADIR"
+ fi
+ ZOOPIDFILE="$ZOO_DATADIR/zookeeper_server.pid"
+else
+ # ensure it exists, otw stop will fail
+ mkdir -p $(dirname "$ZOOPIDFILE")
+fi
{noformat}
> backport patches related to the zk startup script from 3.4 to 3.3 release
> --------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1301
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1301
> Project: ZooKeeper
> Issue Type: Improvement
> Affects Versions: 3.3.4
> Reporter: Giridharan Kesavan
> Assignee: Giridharan Kesavan
> Attachments: zookeeper-1301.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Issue Comment Edited] (ZOOKEEPER-1301) backport patches
related to the zk startup script from 3.4 to 3.3 release
Posted by "Patrick Hunt (Issue Comment Edited) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13151472#comment-13151472 ]
Patrick Hunt edited comment on ZOOKEEPER-1301 at 11/16/11 10:20 PM:
--------------------------------------------------------------------
this requires applying/back-porting the following list of patches from 3.4 to 3.3 branch
ZOOKEEPER-905
ZOOKEEPER-796
ZOOKEEPER-983
ZOOKEEPER-976
ZOOKEEPER-1013
ZOOKEEPER-1012
ZOOKEEPER-1061
ZOOKEEPER-1074
ZOOKEEPER-1119
I would upload one single patch if that make things easier..
was (Author: gkesavan):
this requires applying/back-porting the following list of patches from 3.4 to 3.3 branch
zk-905
zk-796
zk-983
zk-976
zk-1013
zk-1012
zk-1061
zk-1074
zk-1119
I would upload one single patch if that make things easier..
> backport patches related to the zk startup script from 3.4 to 3.3 release
> --------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1301
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1301
> Project: ZooKeeper
> Issue Type: Improvement
> Affects Versions: 3.3.4
> Reporter: Giridharan Kesavan
> Assignee: Giridharan Kesavan
> Attachments: zookeeper-1301.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (ZOOKEEPER-1301) backport patches related to the
zk startup script from 3.4 to 3.3 release
Posted by "Patrick Hunt (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt resolved ZOOKEEPER-1301.
-------------------------------------
Resolution: Fixed
Fix Version/s: 3.3.4
Hadoop Flags: Reviewed
committed to branch 3.3, Thanks Giri!
> backport patches related to the zk startup script from 3.4 to 3.3 release
> --------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1301
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1301
> Project: ZooKeeper
> Issue Type: Improvement
> Affects Versions: 3.3.4
> Reporter: Giridharan Kesavan
> Assignee: Giridharan Kesavan
> Fix For: 3.3.4
>
> Attachments: zookeeper-1301-1.patch, zookeeper-1301-2.patch, zookeeper-1301.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1301) backport patches related to the
zk startup script from 3.4 to 3.3 release
Posted by "Giridharan Kesavan (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Giridharan Kesavan updated ZOOKEEPER-1301:
------------------------------------------
Attachment: zookeeper-1301-2.patch
revised patch which uses partial patches from zookeeper-905 and zookeeper-983 to address 2 & 4
> backport patches related to the zk startup script from 3.4 to 3.3 release
> --------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1301
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1301
> Project: ZooKeeper
> Issue Type: Improvement
> Affects Versions: 3.3.4
> Reporter: Giridharan Kesavan
> Assignee: Giridharan Kesavan
> Attachments: zookeeper-1301-1.patch, zookeeper-1301-2.patch, zookeeper-1301.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1301) backport patches related to the
zk startup script from 3.4 to 3.3 release
Posted by "Giridharan Kesavan (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Giridharan Kesavan updated ZOOKEEPER-1301:
------------------------------------------
Attachment: zookeeper-1301-1.patch
update patch to change the snapshot dir to point to /tmp/zookeeper
> backport patches related to the zk startup script from 3.4 to 3.3 release
> --------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1301
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1301
> Project: ZooKeeper
> Issue Type: Improvement
> Affects Versions: 3.3.4
> Reporter: Giridharan Kesavan
> Assignee: Giridharan Kesavan
> Attachments: zookeeper-1301-1.patch, zookeeper-1301.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (ZOOKEEPER-1301) backport patches related to the zk
startup script from 3.4 to 3.3 release
Posted by "Patrick Hunt (Closed) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt closed ZOOKEEPER-1301.
-----------------------------------
> backport patches related to the zk startup script from 3.4 to 3.3 release
> --------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1301
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1301
> Project: ZooKeeper
> Issue Type: Improvement
> Affects Versions: 3.3.4
> Reporter: Giridharan Kesavan
> Assignee: Giridharan Kesavan
> Fix For: 3.3.4
>
> Attachments: zookeeper-1301-1.patch, zookeeper-1301-2.patch, zookeeper-1301.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1301) backport patches related to the
zk startup script from 3.4 to 3.3 release
Posted by "Patrick Hunt (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13151585#comment-13151585 ]
Patrick Hunt commented on ZOOKEEPER-1301:
-----------------------------------------
1) Let's change datadir like we did in 3.4/trunk (tmp).
2) I don't understand this change, it's for mac but seems to break other things? (see ZOOKEEPER-905)
Is there a better way to work around this on mac?
Can we drop this change from the patch?
3) ?
4) ?
> backport patches related to the zk startup script from 3.4 to 3.3 release
> --------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1301
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1301
> Project: ZooKeeper
> Issue Type: Improvement
> Affects Versions: 3.3.4
> Reporter: Giridharan Kesavan
> Assignee: Giridharan Kesavan
> Attachments: zookeeper-1301.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1301) backport patches related to the
zk startup script from 3.4 to 3.3 release
Posted by "Mahadev konar (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13151699#comment-13151699 ]
Mahadev konar commented on ZOOKEEPER-1301:
------------------------------------------
looks good. +1 on the patch.
> backport patches related to the zk startup script from 3.4 to 3.3 release
> --------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1301
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1301
> Project: ZooKeeper
> Issue Type: Improvement
> Affects Versions: 3.3.4
> Reporter: Giridharan Kesavan
> Assignee: Giridharan Kesavan
> Attachments: zookeeper-1301-1.patch, zookeeper-1301-2.patch, zookeeper-1301.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1301) backport patches related to the
zk startup script from 3.4 to 3.3 release
Posted by "Giridharan Kesavan (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Giridharan Kesavan updated ZOOKEEPER-1301:
------------------------------------------
Attachment: zookeeper-1301.patch
patch comprises all the patches listed in the previous comment.
> backport patches related to the zk startup script from 3.4 to 3.3 release
> --------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1301
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1301
> Project: ZooKeeper
> Issue Type: Improvement
> Affects Versions: 3.3.4
> Reporter: Giridharan Kesavan
> Assignee: Giridharan Kesavan
> Attachments: zookeeper-1301.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1301) backport patches related to the
zk startup script from 3.4 to 3.3 release
Posted by "Eric Yang (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13151637#comment-13151637 ]
Eric Yang commented on ZOOKEEPER-1301:
--------------------------------------
1) +1 on datadir=/tmp
2) readlink -f causes to follow symlink recursively. It is not supported on Mac. If we are just doing back port, we should follow it strictly without making more variants that can potentially lose track. We can be sure that both 3.4 and 3.3.4 would behave the same for 1 level symlink.
3) The patch is right, it will use user input. Why show user input again?
4) Again, it's strict porting. Any corner case should be addressed in trunk then backport to avoid fragmented branches.
> backport patches related to the zk startup script from 3.4 to 3.3 release
> --------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1301
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1301
> Project: ZooKeeper
> Issue Type: Improvement
> Affects Versions: 3.3.4
> Reporter: Giridharan Kesavan
> Assignee: Giridharan Kesavan
> Attachments: zookeeper-1301.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1301) backport patches related to the
zk startup script from 3.4 to 3.3 release
Posted by "Giridharan Kesavan (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13151472#comment-13151472 ]
Giridharan Kesavan commented on ZOOKEEPER-1301:
-----------------------------------------------
this requires applying/back-porting the following list of patches from 3.4 to 3.3 branch
zk-905
zk-796
zk-983
zk-976
zk-1013
zk-1012
zk-1061
zk-1074
zk-1119
I would upload one single patch if that make things easier..
> backport patches related to the zk startup script from 3.4 to 3.3 release
> --------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1301
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1301
> Project: ZooKeeper
> Issue Type: Improvement
> Affects Versions: 3.3.4
> Reporter: Giridharan Kesavan
> Assignee: Giridharan Kesavan
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira