Re: [PR] BIGTOP-4063: Adapt bigtop-select to Python 3 [bigtop]

["JiaLiangC (via GitHub)" <gi...@apache.org>]

JiaLiangC commented on code in PR #1236:
URL: https://github.com/apache/bigtop/pull/1236#discussion_r1663386887


##########
bigtop-packages/src/common/bigtop-select/conf-select:
##########


Review Comment:
   is there any reason for remove conf-select?



##########
bigtop-packages/src/rpm/bigtop-select/SPECS/bigtop-select.spec:
##########
@@ -32,16 +32,15 @@ BuildRoot:  %(mktemp -ud %{_tmppath}/%{name}-%{version}-%{release}-XXXXXX)
 BuildArch:  noarch
 Source0:    install_select.sh
 Source1:    LICENSE
-Source2:    conf-select
-Source3:    distro-select
+Source2:    distro-select
 Requires:   bash
 
 # "which" command is needed for a lot of projects.
 # It is part of the package "util-linux" on suse and "which" everywhere else
 %if  %{?suse_version:1}0
 Requires:  util-linux
 %else
-Requires:       which
+Requires:       which, python3

Review Comment:
   At present, all Python dependencies have been removed from Bigtop, and it is now up to the user to manage them. This seems to be redundant here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org