You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by haosdent huang <ha...@gmail.com> on 2015/10/03 11:09:29 UTC
Re: Review Request 37703: Add docker exec command.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37703/
-----------------------------------------------------------
(Updated Oct. 3, 2015, 9:09 a.m.)
Review request for mesos and Timothy Chen.
Changes
-------
Update according @tnachen reviews
Bugs: MESOS-3291
https://issues.apache.org/jira/browse/MESOS-3291
Repository: mesos
Description
-------
Add docker exec command.
Diffs (updated)
-----
src/docker/docker.hpp c04757c32d5e354f7da60fa28b940eb68e1d9c9f
src/docker/docker.cpp afcedf1f1a309bd0626c33ee25694ac1b43bdec7
src/tests/containerizer/docker_tests.cpp babc7d8da4ed9d13b14bd69decd7f27fc7dfde89
Diff: https://reviews.apache.org/r/37703/diff/
Testing
-------
make check
Thanks,
haosdent huang
Re: Review Request 37703: Add docker exec command.
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37703/#review113626
-----------------------------------------------------------
src/tests/containerizer/docker_tests.cpp (line 299)
<https://reviews.apache.org/r/37703/#comment174388>
I'll fix this myself, but comments should end with period.
- Timothy Chen
On Jan. 9, 2016, 10:35 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37703/
> -----------------------------------------------------------
>
> (Updated Jan. 9, 2016, 10:35 a.m.)
>
>
> Review request for mesos and Timothy Chen.
>
>
> Bugs: MESOS-3291
> https://issues.apache.org/jira/browse/MESOS-3291
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add docker exec command.
>
>
> Diffs
> -----
>
> src/docker/docker.hpp dde2b29deda7e40929e0169935a5bafdd43136b1
> src/docker/docker.cpp e93280735f1c5f66c765fcbabfd3e50b46c024e8
> src/tests/containerizer/docker_tests.cpp 72961afb8de25811b16809690d2c3b140e6ce440
>
> Diff: https://reviews.apache.org/r/37703/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 37703: Add docker exec command.
Posted by Qian Zhang <zh...@cn.ibm.com>.
> On Jan. 11, 2016, 8:16 a.m., Qian Zhang wrote:
> >
@haosdent, can you please let me know in which case we need to call this "docker exec" command that you added in this patch?
- Qian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37703/#review113664
-----------------------------------------------------------
On Jan. 10, 2016, 2:32 p.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37703/
> -----------------------------------------------------------
>
> (Updated Jan. 10, 2016, 2:32 p.m.)
>
>
> Review request for mesos and Timothy Chen.
>
>
> Bugs: MESOS-3291
> https://issues.apache.org/jira/browse/MESOS-3291
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add docker exec command.
>
>
> Diffs
> -----
>
> src/docker/docker.hpp dde2b29deda7e40929e0169935a5bafdd43136b1
> src/docker/docker.cpp e93280735f1c5f66c765fcbabfd3e50b46c024e8
> src/tests/containerizer/docker_tests.cpp 72961afb8de25811b16809690d2c3b140e6ce440
>
> Diff: https://reviews.apache.org/r/37703/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 37703: Add docker exec command.
Posted by haosdent huang <ha...@gmail.com>.
> On Jan. 11, 2016, 12:16 a.m., Qian Zhang wrote:
> >
>
> Qian Zhang wrote:
> @haosdent, can you please let me know in which case we need to call this "docker exec" command that you added in this patch?
Hi, @qianzhang. So far don't have cases to call `docker exec`. I try to add this before because we want execute health check in docker container through `docker exec`. But currently docker container health check don't depends on this.
- haosdent
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37703/#review113664
-----------------------------------------------------------
On Jan. 11, 2016, 6:01 p.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37703/
> -----------------------------------------------------------
>
> (Updated Jan. 11, 2016, 6:01 p.m.)
>
>
> Review request for mesos and Timothy Chen.
>
>
> Bugs: MESOS-3291
> https://issues.apache.org/jira/browse/MESOS-3291
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add docker exec command.
>
>
> Diffs
> -----
>
> src/docker/docker.hpp dde2b29deda7e40929e0169935a5bafdd43136b1
> src/docker/docker.cpp e93280735f1c5f66c765fcbabfd3e50b46c024e8
> src/tests/containerizer/docker_tests.cpp 72961afb8de25811b16809690d2c3b140e6ce440
>
> Diff: https://reviews.apache.org/r/37703/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 37703: Add docker exec command.
Posted by Qian Zhang <zh...@cn.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37703/#review113664
-----------------------------------------------------------
src/docker/docker.cpp (line 1229)
<https://reviews.apache.org/r/37703/#comment174421>
s/don't/does not/
s/be/is/
- Qian Zhang
On Jan. 10, 2016, 2:32 p.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37703/
> -----------------------------------------------------------
>
> (Updated Jan. 10, 2016, 2:32 p.m.)
>
>
> Review request for mesos and Timothy Chen.
>
>
> Bugs: MESOS-3291
> https://issues.apache.org/jira/browse/MESOS-3291
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add docker exec command.
>
>
> Diffs
> -----
>
> src/docker/docker.hpp dde2b29deda7e40929e0169935a5bafdd43136b1
> src/docker/docker.cpp e93280735f1c5f66c765fcbabfd3e50b46c024e8
> src/tests/containerizer/docker_tests.cpp 72961afb8de25811b16809690d2c3b140e6ce440
>
> Diff: https://reviews.apache.org/r/37703/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 37703: Add docker exec command.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37703/
-----------------------------------------------------------
(Updated Jan. 11, 2016, 6:01 p.m.)
Review request for mesos and Timothy Chen.
Changes
-------
Address @qianzhang comments
Bugs: MESOS-3291
https://issues.apache.org/jira/browse/MESOS-3291
Repository: mesos
Description
-------
Add docker exec command.
Diffs (updated)
-----
src/docker/docker.hpp dde2b29deda7e40929e0169935a5bafdd43136b1
src/docker/docker.cpp e93280735f1c5f66c765fcbabfd3e50b46c024e8
src/tests/containerizer/docker_tests.cpp 72961afb8de25811b16809690d2c3b140e6ce440
Diff: https://reviews.apache.org/r/37703/diff/
Testing
-------
make check
Thanks,
haosdent huang
Re: Review Request 37703: Add docker exec command.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37703/
-----------------------------------------------------------
(Updated Jan. 10, 2016, 6:32 a.m.)
Review request for mesos and Timothy Chen.
Changes
-------
Address @tnachen comment
Bugs: MESOS-3291
https://issues.apache.org/jira/browse/MESOS-3291
Repository: mesos
Description
-------
Add docker exec command.
Diffs (updated)
-----
src/docker/docker.hpp dde2b29deda7e40929e0169935a5bafdd43136b1
src/docker/docker.cpp e93280735f1c5f66c765fcbabfd3e50b46c024e8
src/tests/containerizer/docker_tests.cpp 72961afb8de25811b16809690d2c3b140e6ce440
Diff: https://reviews.apache.org/r/37703/diff/
Testing
-------
make check
Thanks,
haosdent huang
Re: Review Request 37703: Add docker exec command.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37703/
-----------------------------------------------------------
(Updated Jan. 9, 2016, 10:35 a.m.)
Review request for mesos and Timothy Chen.
Changes
-------
Fix fail test case.
Bugs: MESOS-3291
https://issues.apache.org/jira/browse/MESOS-3291
Repository: mesos
Description
-------
Add docker exec command.
Diffs (updated)
-----
src/docker/docker.hpp dde2b29deda7e40929e0169935a5bafdd43136b1
src/docker/docker.cpp e93280735f1c5f66c765fcbabfd3e50b46c024e8
src/tests/containerizer/docker_tests.cpp 72961afb8de25811b16809690d2c3b140e6ce440
Diff: https://reviews.apache.org/r/37703/diff/
Testing
-------
make check
Thanks,
haosdent huang
Re: Review Request 37703: Add docker exec command.
Posted by haosdent huang <ha...@gmail.com>.
> On Jan. 9, 2016, 1:05 a.m., Timothy Chen wrote:
> > I just ran the CheckExec test and it failed for me, can you try it yourself and see if you can repro?
sorry, my bad. Let me update again..
- haosdent
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37703/#review113582
-----------------------------------------------------------
On Dec. 9, 2015, 5:42 p.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37703/
> -----------------------------------------------------------
>
> (Updated Dec. 9, 2015, 5:42 p.m.)
>
>
> Review request for mesos and Timothy Chen.
>
>
> Bugs: MESOS-3291
> https://issues.apache.org/jira/browse/MESOS-3291
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add docker exec command.
>
>
> Diffs
> -----
>
> src/docker/docker.hpp 33d6fb3e82ff7328ad093648a45546a18ec7b8cb
> src/docker/docker.cpp 5dc4667d93b143b54841d85606affe3e4926757a
> src/tests/containerizer/docker_tests.cpp d9e1345aea0ef9db0e50360e3993ef2708970298
>
> Diff: https://reviews.apache.org/r/37703/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 37703: Add docker exec command.
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37703/#review113582
-----------------------------------------------------------
I just ran the CheckExec test and it failed for me, can you try it yourself and see if you can repro?
- Timothy Chen
On Dec. 9, 2015, 5:42 p.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37703/
> -----------------------------------------------------------
>
> (Updated Dec. 9, 2015, 5:42 p.m.)
>
>
> Review request for mesos and Timothy Chen.
>
>
> Bugs: MESOS-3291
> https://issues.apache.org/jira/browse/MESOS-3291
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add docker exec command.
>
>
> Diffs
> -----
>
> src/docker/docker.hpp 33d6fb3e82ff7328ad093648a45546a18ec7b8cb
> src/docker/docker.cpp 5dc4667d93b143b54841d85606affe3e4926757a
> src/tests/containerizer/docker_tests.cpp d9e1345aea0ef9db0e50360e3993ef2708970298
>
> Diff: https://reviews.apache.org/r/37703/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 37703: Add docker exec command.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37703/#review109600
-----------------------------------------------------------
Patch looks great!
Reviews applied: [37703]
Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh
- Mesos ReviewBot
On Dec. 9, 2015, 5:42 p.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37703/
> -----------------------------------------------------------
>
> (Updated Dec. 9, 2015, 5:42 p.m.)
>
>
> Review request for mesos and Timothy Chen.
>
>
> Bugs: MESOS-3291
> https://issues.apache.org/jira/browse/MESOS-3291
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add docker exec command.
>
>
> Diffs
> -----
>
> src/docker/docker.hpp 33d6fb3e82ff7328ad093648a45546a18ec7b8cb
> src/docker/docker.cpp 5dc4667d93b143b54841d85606affe3e4926757a
> src/tests/containerizer/docker_tests.cpp d9e1345aea0ef9db0e50360e3993ef2708970298
>
> Diff: https://reviews.apache.org/r/37703/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 37703: Add docker exec command.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37703/
-----------------------------------------------------------
(Updated Dec. 9, 2015, 5:42 p.m.)
Review request for mesos and Timothy Chen.
Changes
-------
Address @tnachen comments.
Bugs: MESOS-3291
https://issues.apache.org/jira/browse/MESOS-3291
Repository: mesos
Description
-------
Add docker exec command.
Diffs (updated)
-----
src/docker/docker.hpp 33d6fb3e82ff7328ad093648a45546a18ec7b8cb
src/docker/docker.cpp 5dc4667d93b143b54841d85606affe3e4926757a
src/tests/containerizer/docker_tests.cpp d9e1345aea0ef9db0e50360e3993ef2708970298
Diff: https://reviews.apache.org/r/37703/diff/
Testing
-------
make check
Thanks,
haosdent huang
Re: Review Request 37703: Add docker exec command.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37703/#review108275
-----------------------------------------------------------
Patch looks great!
Reviews applied: [37703]
Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh
- Mesos ReviewBot
On Nov. 29, 2015, 4:37 p.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37703/
> -----------------------------------------------------------
>
> (Updated Nov. 29, 2015, 4:37 p.m.)
>
>
> Review request for mesos and Timothy Chen.
>
>
> Bugs: MESOS-3291
> https://issues.apache.org/jira/browse/MESOS-3291
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add docker exec command.
>
>
> Diffs
> -----
>
> src/docker/docker.hpp 33d6fb3e82ff7328ad093648a45546a18ec7b8cb
> src/docker/docker.cpp 5dc4667d93b143b54841d85606affe3e4926757a
> src/tests/containerizer/docker_tests.cpp d9e1345aea0ef9db0e50360e3993ef2708970298
>
> Diff: https://reviews.apache.org/r/37703/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 37703: Add docker exec command.
Posted by haosdent huang <ha...@gmail.com>.
> On Dec. 1, 2015, 3:09 a.m., Timothy Chen wrote:
> > src/tests/containerizer/docker_tests.cpp, line 297
> > <https://reviews.apache.org/r/37703/diff/7/?file=1148103#file1148103line297>
> >
> > This isn't enough still, when the future is ready doesn't mean the container is actually running yet.
> >
> > What you could do is to run docker->inspect(containerName, Miliseconds(500)) and it will retry inspect until it's running, then you AWAIT that inspect future.
Thx, let me update.
- haosdent
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37703/#review108445
-----------------------------------------------------------
On Nov. 29, 2015, 4:37 p.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37703/
> -----------------------------------------------------------
>
> (Updated Nov. 29, 2015, 4:37 p.m.)
>
>
> Review request for mesos and Timothy Chen.
>
>
> Bugs: MESOS-3291
> https://issues.apache.org/jira/browse/MESOS-3291
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add docker exec command.
>
>
> Diffs
> -----
>
> src/docker/docker.hpp 33d6fb3e82ff7328ad093648a45546a18ec7b8cb
> src/docker/docker.cpp 5dc4667d93b143b54841d85606affe3e4926757a
> src/tests/containerizer/docker_tests.cpp d9e1345aea0ef9db0e50360e3993ef2708970298
>
> Diff: https://reviews.apache.org/r/37703/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 37703: Add docker exec command.
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37703/#review108445
-----------------------------------------------------------
src/tests/containerizer/docker_tests.cpp (line 297)
<https://reviews.apache.org/r/37703/#comment167905>
This isn't enough still, when the future is ready doesn't mean the container is actually running yet.
What you could do is to run docker->inspect(containerName, Miliseconds(500)) and it will retry inspect until it's running, then you AWAIT that inspect future.
- Timothy Chen
On Nov. 29, 2015, 4:37 p.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37703/
> -----------------------------------------------------------
>
> (Updated Nov. 29, 2015, 4:37 p.m.)
>
>
> Review request for mesos and Timothy Chen.
>
>
> Bugs: MESOS-3291
> https://issues.apache.org/jira/browse/MESOS-3291
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add docker exec command.
>
>
> Diffs
> -----
>
> src/docker/docker.hpp 33d6fb3e82ff7328ad093648a45546a18ec7b8cb
> src/docker/docker.cpp 5dc4667d93b143b54841d85606affe3e4926757a
> src/tests/containerizer/docker_tests.cpp d9e1345aea0ef9db0e50360e3993ef2708970298
>
> Diff: https://reviews.apache.org/r/37703/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 37703: Add docker exec command.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37703/
-----------------------------------------------------------
(Updated Nov. 29, 2015, 4:37 p.m.)
Review request for mesos and Timothy Chen.
Changes
-------
Update according to @tnachen's reviews
Bugs: MESOS-3291
https://issues.apache.org/jira/browse/MESOS-3291
Repository: mesos
Description
-------
Add docker exec command.
Diffs (updated)
-----
src/docker/docker.hpp 33d6fb3e82ff7328ad093648a45546a18ec7b8cb
src/docker/docker.cpp 5dc4667d93b143b54841d85606affe3e4926757a
src/tests/containerizer/docker_tests.cpp d9e1345aea0ef9db0e50360e3993ef2708970298
Diff: https://reviews.apache.org/r/37703/diff/
Testing
-------
make check
Thanks,
haosdent huang
Re: Review Request 37703: Add docker exec command.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37703/#review101402
-----------------------------------------------------------
Patch looks great!
Reviews applied: [37703]
All tests passed.
- Mesos ReviewBot
On Oct. 3, 2015, 9:09 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37703/
> -----------------------------------------------------------
>
> (Updated Oct. 3, 2015, 9:09 a.m.)
>
>
> Review request for mesos and Timothy Chen.
>
>
> Bugs: MESOS-3291
> https://issues.apache.org/jira/browse/MESOS-3291
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add docker exec command.
>
>
> Diffs
> -----
>
> src/docker/docker.hpp c04757c32d5e354f7da60fa28b940eb68e1d9c9f
> src/docker/docker.cpp afcedf1f1a309bd0626c33ee25694ac1b43bdec7
> src/tests/containerizer/docker_tests.cpp babc7d8da4ed9d13b14bd69decd7f27fc7dfde89
>
> Diff: https://reviews.apache.org/r/37703/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 37703: Add docker exec command.
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37703/#review107682
-----------------------------------------------------------
Ship it!
Ship It!
- Timothy Chen
On Oct. 3, 2015, 9:09 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37703/
> -----------------------------------------------------------
>
> (Updated Oct. 3, 2015, 9:09 a.m.)
>
>
> Review request for mesos and Timothy Chen.
>
>
> Bugs: MESOS-3291
> https://issues.apache.org/jira/browse/MESOS-3291
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add docker exec command.
>
>
> Diffs
> -----
>
> src/docker/docker.hpp c04757c32d5e354f7da60fa28b940eb68e1d9c9f
> src/docker/docker.cpp afcedf1f1a309bd0626c33ee25694ac1b43bdec7
> src/tests/containerizer/docker_tests.cpp babc7d8da4ed9d13b14bd69decd7f27fc7dfde89
>
> Diff: https://reviews.apache.org/r/37703/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 37703: Add docker exec command.
Posted by haosdent huang <ha...@gmail.com>.
> On Nov. 24, 2015, 1:23 a.m., Timothy Chen wrote:
> > src/tests/containerizer/docker_tests.cpp, line 298
> > <https://reviews.apache.org/r/37703/diff/6/?file=1089376#file1089376line298>
> >
> > This test failed for me since at the time docker->exec is called the container isn't running yet.
> >
> > Please abstract out the exists() method (probably in tests/containerizer/docker_test_helper.hpp) in containerizer_docker_tests so you can use it here that you wait until the container is running before you run docker exec.
Are you refer to the `exists` method in `src/tests/containerizer/docker_containerizer_tests.cpp`? Because could not use it in `src/tests/containerizer/docker_tests.cpp`, I use `AWAIT_READY(status);` directly.
- haosdent
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37703/#review107694
-----------------------------------------------------------
On Oct. 3, 2015, 9:09 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37703/
> -----------------------------------------------------------
>
> (Updated Oct. 3, 2015, 9:09 a.m.)
>
>
> Review request for mesos and Timothy Chen.
>
>
> Bugs: MESOS-3291
> https://issues.apache.org/jira/browse/MESOS-3291
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add docker exec command.
>
>
> Diffs
> -----
>
> src/docker/docker.hpp c04757c32d5e354f7da60fa28b940eb68e1d9c9f
> src/docker/docker.cpp afcedf1f1a309bd0626c33ee25694ac1b43bdec7
> src/tests/containerizer/docker_tests.cpp babc7d8da4ed9d13b14bd69decd7f27fc7dfde89
>
> Diff: https://reviews.apache.org/r/37703/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 37703: Add docker exec command.
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37703/#review107694
-----------------------------------------------------------
src/tests/containerizer/docker_tests.cpp (line 298)
<https://reviews.apache.org/r/37703/#comment166954>
This test failed for me since at the time docker->exec is called the container isn't running yet.
Please abstract out the exists() method (probably in tests/containerizer/docker_test_helper.hpp) in containerizer_docker_tests so you can use it here that you wait until the container is running before you run docker exec.
- Timothy Chen
On Oct. 3, 2015, 9:09 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37703/
> -----------------------------------------------------------
>
> (Updated Oct. 3, 2015, 9:09 a.m.)
>
>
> Review request for mesos and Timothy Chen.
>
>
> Bugs: MESOS-3291
> https://issues.apache.org/jira/browse/MESOS-3291
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add docker exec command.
>
>
> Diffs
> -----
>
> src/docker/docker.hpp c04757c32d5e354f7da60fa28b940eb68e1d9c9f
> src/docker/docker.cpp afcedf1f1a309bd0626c33ee25694ac1b43bdec7
> src/tests/containerizer/docker_tests.cpp babc7d8da4ed9d13b14bd69decd7f27fc7dfde89
>
> Diff: https://reviews.apache.org/r/37703/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> haosdent huang
>
>