You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2020/07/10 22:10:59 UTC
[GitHub] [iceberg] rdblue opened a new pull request #1195: Add PartitionKey to the public API
rdblue opened a new pull request #1195:
URL: https://github.com/apache/iceberg/pull/1195
This is a refactor similar to #1175 that is intended to make the `PartitionKey` class used by Spark public. This PR uses a different approach that doesn't require creating sub-classes of `PartitionKey` and custom `Accessor` classes. Instead, the public `PartitionKey` class can partition any `StructLike`, and a reusable wrapper is added to adapt Spark's `InternalRow` to `StructLike`.
This approach separates concerns. Conversion to the internal representations used by Iceberg classes is handled by the row wrapper, which allows the same `Accessor` class to be used everywhere. That wrapper class could be used to pass rows to an expression evaluator or to `PartitionKey`, as in #983.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] danielcweeks commented on pull request #1195: Add PartitionKey to the public API
Posted by GitBox <gi...@apache.org>.
danielcweeks commented on pull request #1195:
URL: https://github.com/apache/iceberg/pull/1195#issuecomment-657852579
+1 LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] jeffchao commented on pull request #1195: Add PartitionKey to the public API
Posted by GitBox <gi...@apache.org>.
jeffchao commented on pull request #1195:
URL: https://github.com/apache/iceberg/pull/1195#issuecomment-657680576
Been following this from afar. +1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] danielcweeks merged pull request #1195: Add PartitionKey to the public API
Posted by GitBox <gi...@apache.org>.
danielcweeks merged pull request #1195:
URL: https://github.com/apache/iceberg/pull/1195
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org