You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2017/08/10 21:48:50 UTC
[kudu-CR] [cfile-test-base.h] remove cyclic dependency
Alexey Serbin has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7650
Change subject: [cfile-test-base.h] remove cyclic dependency
......................................................................
[cfile-test-base.h] remove cyclic dependency
Removed '#include "kudu/cfile/cfile-test-base.h"' from the
cfile-test-base.h file.
This patch does not contain any functional changes.
Change-Id: I34e92c198b234fa4eb05fb923eb5a9b0133dd578
---
M src/kudu/cfile/cfile-test-base.h
1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/50/7650/1
--
To view, visit http://gerrit.cloudera.org:8080/7650
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I34e92c198b234fa4eb05fb923eb5a9b0133dd578
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [cfile-test-base.h] remove cyclic dependency
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged.
Change subject: [cfile-test-base.h] remove cyclic dependency
......................................................................
[cfile-test-base.h] remove cyclic dependency
Removed '#include "kudu/cfile/cfile-test-base.h"' from the
cfile-test-base.h file.
This patch does not contain any functional changes.
Change-Id: I34e92c198b234fa4eb05fb923eb5a9b0133dd578
Reviewed-on: http://gerrit.cloudera.org:8080/7650
Reviewed-by: Dan Burkert <da...@apache.org>
Tested-by: Kudu Jenkins
---
M src/kudu/cfile/cfile-test-base.h
1 file changed, 0 insertions(+), 1 deletion(-)
Approvals:
Dan Burkert: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/7650
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I34e92c198b234fa4eb05fb923eb5a9b0133dd578
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
[kudu-CR] [cfile-test-base.h] remove cyclic dependency
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: [cfile-test-base.h] remove cyclic dependency
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7650
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I34e92c198b234fa4eb05fb923eb5a9b0133dd578
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No