You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by sureshanaparti <gi...@git.apache.org> on 2015/12/17 06:31:00 UTC
[GitHub] cloudstack pull request: CLOUDSTACK-9185: [VMware DRS] VM sync fai...
GitHub user sureshanaparti opened a pull request:
https://github.com/apache/cloudstack/pull/1256
CLOUDSTACK-9185: [VMware DRS] VM sync failed with exception due to out-of-band changes
Summary: The target "ClusteredVirtualMachineManagerImpl.HandlePowerStateReport" invoked during the VM power state sync is not found as HandlePowerStateReport was not implemented in ClusteredVirtualMachineManagerImpl and was private in VirtualMachineManagerImpl, which was resulting in InvocationTargetException. Changed HandlePowerStateReport() in VirtualMachineManagerImpl to protected.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sureshanaparti/cloudstack CLOUDSTACK-9185
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1256.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1256
----
commit 2d5f6a7911585a8075996e106f97b7f3b89067f8
Author: Suresh Kumar Anaparti <su...@citrix.com>
Date: 2015-12-17T05:29:31Z
CLOUDSTACK-9185: [VMware DRS] VM sync failed with exception due to out-of-band changes
Summary: The target "ClusteredVirtualMachineManagerImpl.HandlePowerStateReport" invoked during the VM power state sync is not found as HandlePowerStateReport was not implemented in ClusteredVirtualMachineManagerImpl and was private in VirtualMachineManagerImpl, which was resulting in InvocationTargetException. Changed HandlePowerStateReport() in VirtualMachineManagerImpl to protected.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9185: [VMware DRS] VM sync fai...
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1256#issuecomment-166816696
LGTM
Thanks for the explanation @sureshanaparti
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9185: [VMware DRS] VM sync fai...
Posted by resmo <gi...@git.apache.org>.
Github user resmo commented on the pull request:
https://github.com/apache/cloudstack/pull/1256#issuecomment-165420030
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9185: [VMware DRS] VM sync fai...
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1256#discussion_r48324398
--- Diff: engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java ---
@@ -3685,7 +3685,7 @@ public void setStoragePoolAllocators(final List<StoragePoolAllocator> storagePoo
//
@MessageHandler(topic = Topics.VM_POWER_STATE)
- private void HandlePowerStateReport(final String subject, final String senderAddress, final Object args) {
+ protected void HandlePowerStateReport(final String subject, final String senderAddress, final Object args) {
--- End diff --
@sureshanaparti can you explain in detail how you got the exception and how this fix fixes that
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9185: [VMware DRS] VM sync fai...
Posted by sureshanaparti <gi...@git.apache.org>.
Github user sureshanaparti commented on the pull request:
https://github.com/apache/cloudstack/pull/1256#issuecomment-166815006
@bhaisaab Got this exception on VM power sync when router is migrated back (due to a DRS rule set for VMs together) after manual migration from CCP. During the power sync, CCP tried to invoke the target "ClusteredVirtualMachineManagerImpl.HandlePowerStateReport" and failed as HandlePowerStateReport was not implemented in ClusteredVirtualMachineManagerImpl and was private in VirtualMachineManagerImpl. Changed HandlePowerStateReport() in VirtualMachineManagerImpl to protected so that CCP can get to the target. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9185: [VMware DRS] VM sync fai...
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1256#issuecomment-175662863
Merging as it has 2LGTMs
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9185: [VMware DRS] VM sync fai...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1256
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---