You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by GitBox <gi...@apache.org> on 2021/01/03 19:26:18 UTC
[GitHub] [maven-site-plugin] bertysentry opened a new pull request #34: [DOXIA-616]
bertysentry opened a new pull request #34:
URL: https://github.com/apache/maven-site-plugin/pull/34
* Fixed integration tests for **doxia-formats* wrt fenced code blocks
* Upgraded to Doxia 1.10-SNAPSHOT
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-site-plugin] bertysentry commented on pull request #34: [DOXIA-616]
Posted by GitBox <gi...@apache.org>.
bertysentry commented on pull request #34:
URL: https://github.com/apache/maven-site-plugin/pull/34#issuecomment-760124289
Oh, last update: I reverted Doxia version to **1.9.1**. MSITE integration tests will pass with both 1.9.1 and 1.10 (no more checks on specific Doxia formatting features).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-site-plugin] bertysentry commented on pull request #34: [DOXIA-616]
Posted by GitBox <gi...@apache.org>.
bertysentry commented on pull request #34:
URL: https://github.com/apache/maven-site-plugin/pull/34#issuecomment-760137856
More build failures: Connection timeout with www.w3.org, which is totally unrelated to this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-site-plugin] bertysentry commented on pull request #34: [DOXIA-616]
Posted by GitBox <gi...@apache.org>.
bertysentry commented on pull request #34:
URL: https://github.com/apache/maven-site-plugin/pull/34#issuecomment-754969798
Submitted PR for Doxia: https://github.com/apache/maven-doxia/pull/52
Thank you!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-site-plugin] elharo commented on pull request #34: [DOXIA-616]
Posted by GitBox <gi...@apache.org>.
elharo commented on pull request #34:
URL: https://github.com/apache/maven-site-plugin/pull/34#issuecomment-760160299
We really should resolve the CI issues before proceeding with this or any other changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-site-plugin] elharo commented on pull request #34: [DOXIA-616]
Posted by GitBox <gi...@apache.org>.
elharo commented on pull request #34:
URL: https://github.com/apache/maven-site-plugin/pull/34#issuecomment-754589531
I think I agree that these should be moved. If they're only testing doxia functionality, and we can test them in doxia, then that's better. Or perhaps tests belong in both places. Doxia should be an implementation detail of maven-site-plugin. Any tests we have for HTML generation in sites should be independent of the HTML generator we're using.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-site-plugin] michael-o commented on pull request #34: [DOXIA-616]
Posted by GitBox <gi...@apache.org>.
michael-o commented on pull request #34:
URL: https://github.com/apache/maven-site-plugin/pull/34#issuecomment-766434017
I won't be able to review before mid Feb due to circumstances here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-site-plugin] bertysentry commented on pull request #34: [DOXIA-616]
Posted by GitBox <gi...@apache.org>.
bertysentry commented on pull request #34:
URL: https://github.com/apache/maven-site-plugin/pull/34#issuecomment-770245625
Awesome, thank you guys! 😊
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-site-plugin] michael-o commented on pull request #34: [DOXIA-616]
Posted by GitBox <gi...@apache.org>.
michael-o commented on pull request #34:
URL: https://github.com/apache/maven-site-plugin/pull/34#issuecomment-754273143
In my opinion they need to bemoved because we test the entire site generation, and not Doxia specific modules. @hboutemy WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-site-plugin] michael-o commented on pull request #34: [DOXIA-616]
Posted by GitBox <gi...@apache.org>.
michael-o commented on pull request #34:
URL: https://github.com/apache/maven-site-plugin/pull/34#issuecomment-770206648
Let me go through too...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-site-plugin] bertysentry commented on pull request #34: [DOXIA-616]
Posted by GitBox <gi...@apache.org>.
bertysentry commented on pull request #34:
URL: https://github.com/apache/maven-site-plugin/pull/34#issuecomment-754944421
@hboutemy We will keep some integration tests in *maven-site-plugin* that involve *doxia-module-markdown*. I want to remove specific Doxia tests (like "quotes were mistakenly removed", or "code block must be surrounded with `<div class="source">`.
These can be properly tested in Doxia with unit tests, and also with integration tests. Where applicable, we use integration tests to invoke *maven-site-plugin* with the current version of Doxia and make sure the end-to-end chain works as expected.
I will submit a PR on Doxia to incorporate these specific tests (from *maven-site-plugin*) to *doxia-module-markdown*.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-site-plugin] bertysentry commented on pull request #34: [DOXIA-616]
Posted by GitBox <gi...@apache.org>.
bertysentry commented on pull request #34:
URL: https://github.com/apache/maven-site-plugin/pull/34#issuecomment-754142358
Okay, I will update the PR once Doxia 1.10 is released.
Do you guys have any opinion on the removal of markdown-specific integration tests (especially Doxia-specific) from maven-site-plugin, and reincorporate them in Doxia? This would avoid the chicken-egg situation like this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-site-plugin] elharo commented on pull request #34: [DOXIA-616]
Posted by GitBox <gi...@apache.org>.
elharo commented on pull request #34:
URL: https://github.com/apache/maven-site-plugin/pull/34#issuecomment-762430570
That one wasn't merged by me. :-)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-site-plugin] slachiewicz commented on pull request #34: [DOXIA-616]
Posted by GitBox <gi...@apache.org>.
slachiewicz commented on pull request #34:
URL: https://github.com/apache/maven-site-plugin/pull/34#issuecomment-766441620
I'll look at it tomorrow
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-site-plugin] michael-o commented on pull request #34: [DOXIA-616]
Posted by GitBox <gi...@apache.org>.
michael-o commented on pull request #34:
URL: https://github.com/apache/maven-site-plugin/pull/34#issuecomment-753673025
Thanks, will look into it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-site-plugin] bertysentry commented on pull request #34: [DOXIA-616]
Posted by GitBox <gi...@apache.org>.
bertysentry commented on pull request #34:
URL: https://github.com/apache/maven-site-plugin/pull/34#issuecomment-753665247
@michael-o Please note:
* I upgraded to Doxia 1.10-SNAPSHOT (not sure you wanted this here, just let me know)
* I wondered whether we should actually remove these Doxia markdown integration tests from **maven-site-plugin**, as we now have proper integration tests in **doxia-module-markdown** itself. This would prevent such situations where updates in one project (Doxia) requires to update the tests in another project (maven-site-plugin).
Please advise! :-)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-site-plugin] slachiewicz commented on pull request #34: [DOXIA-616]
Posted by GitBox <gi...@apache.org>.
slachiewicz commented on pull request #34:
URL: https://github.com/apache/maven-site-plugin/pull/34#issuecomment-766441620
I'll look at it tomorrow
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-site-plugin] bertysentry commented on pull request #34: [DOXIA-616]
Posted by GitBox <gi...@apache.org>.
bertysentry commented on pull request #34:
URL: https://github.com/apache/maven-site-plugin/pull/34#issuecomment-768500491
Guys? I'm still waiting for this to be merged so I can move forward with more changes in Doxia. Your help is much appreciated 😉
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-site-plugin] asfgit closed pull request #34: [DOXIA-616]
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #34:
URL: https://github.com/apache/maven-site-plugin/pull/34
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-site-plugin] bertysentry commented on pull request #34: [DOXIA-616]
Posted by GitBox <gi...@apache.org>.
bertysentry commented on pull request #34:
URL: https://github.com/apache/maven-site-plugin/pull/34#issuecomment-760381651
@elharo Any idea on how to retrieve the **build.log** files from GitHub Actions/Workflows? I must be missing something here, but I can't find any link to any downloadable artifact in GitHub Actions... 😅
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-site-plugin] bertysentry commented on pull request #34: [DOXIA-616]
Posted by GitBox <gi...@apache.org>.
bertysentry commented on pull request #34:
URL: https://github.com/apache/maven-site-plugin/pull/34#issuecomment-766418215
@michael-o @hboutemy @elharo Friendly reminder that this PR is still waiting, and its content is not going to change with regards to the failed builds, which are caused by something else (*master* is failing the same builds the same way).
The more we wait, the more risk we have to get conflicting changes.
Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-site-plugin] elharo commented on pull request #34: [DOXIA-616]
Posted by GitBox <gi...@apache.org>.
elharo commented on pull request #34:
URL: https://github.com/apache/maven-site-plugin/pull/34#issuecomment-762205983
It might need someone who has more permissions on the project. I'm not sure.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-site-plugin] michael-o commented on pull request #34: [DOXIA-616]
Posted by GitBox <gi...@apache.org>.
michael-o commented on pull request #34:
URL: https://github.com/apache/maven-site-plugin/pull/34#issuecomment-770215957
>
>
> I squashed commits - looks good to me.
> Only MacOS tests failed https://github.com/apache/maven-site-plugin/actions/runs/516170331
> Our Jenkins is green https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven-site-plugin/job/feature%252FDOXIA-616/
I was not able to reproduce this problem multiple times.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-site-plugin] michael-o commented on pull request #34: [DOXIA-616]
Posted by GitBox <gi...@apache.org>.
michael-o commented on pull request #34:
URL: https://github.com/apache/maven-site-plugin/pull/34#issuecomment-768532367
>
>
> Guys? I'm still waiting for this to be merged so I can move forward with more changes in Doxia. Your help is much appreciated 😉
As promised, I will pick up as soon as I can, but now Oracle quartely updates are waiting for me...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-site-plugin] hboutemy commented on pull request #34: [DOXIA-616]
Posted by GitBox <gi...@apache.org>.
hboutemy commented on pull request #34:
URL: https://github.com/apache/maven-site-plugin/pull/34#issuecomment-754936536
is it causing issues, so they *need* to be removed?
if you're sure you have sufficient tests nowadays in Doxia, Doxia Sitetools and skins to check that a new feature in a Doxia module has the expected impact when used in a real site, you can drop this end to end test
but I feel that a few end to end tests remain useful to check that the full rendering bring expected result after execution of https://maven.apache.org/plugins/maven-site-plugin/history.html
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-site-plugin] elharo commented on pull request #34: [DOXIA-616]
Posted by GitBox <gi...@apache.org>.
elharo commented on pull request #34:
URL: https://github.com/apache/maven-site-plugin/pull/34#issuecomment-762208210
Some though not all of the errors seem related to this:
: | [ERROR] Failed to execute goal org.apache.maven.plugins:maven-site-plugin:3.10.0-SNAPSHOT:site (default-cli) on project test: Error parsing '/home/runner/work/maven-site-plugin/maven-site-plugin/target/it/validate/src/site/fml/faq.fml': line [-1] Error validating the model: Connect to www.w3.org:80 [www.w3.org/128.30.52.100] failed: Connection timed out -> [Help 1]
It might be worth understanding why the test is trying to connect to www.3.org. I'm not sure it needs to do that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-site-plugin] michael-o commented on pull request #34: [DOXIA-616]
Posted by GitBox <gi...@apache.org>.
michael-o commented on pull request #34:
URL: https://github.com/apache/maven-site-plugin/pull/34#issuecomment-766434017
I won't be able to review before mid Feb due to circumstances here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-site-plugin] bertysentry commented on pull request #34: [DOXIA-616]
Posted by GitBox <gi...@apache.org>.
bertysentry commented on pull request #34:
URL: https://github.com/apache/maven-site-plugin/pull/34#issuecomment-762494128
One recurring error is:
```log
Error: | [ERROR] Failed to execute goal org.apache.maven.plugins:maven-site-plugin:3.10.0-SNAPSHOT:site (default-cli) on project test: Error parsing '/home/runner/work/maven-site-plugin/maven-site-plugin/target/it/validate/src/site/fml/faq.fml': line [-1] Error validating the model: Connect to www.w3.org:80 [www.w3.org/128.30.52.100] failed: Connection timed out (Connection timed out) -> [Help 1]
```
It happens when the **site:validate** goal is invoked in the integration tests (in **src/it/validate/pom.xml**). Apparently, **site:validate** tries to download the specified XML schema to validate the source documents (FML and XDOC). On GitHub Actions, this appears to fail from time to time.
This is nothing too serious, IMO.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-site-plugin] bertysentry commented on pull request #34: [DOXIA-616]
Posted by GitBox <gi...@apache.org>.
bertysentry commented on pull request #34:
URL: https://github.com/apache/maven-site-plugin/pull/34#issuecomment-762209071
This was just a temporary network issue of GitHub Actions. If you re-run the workflow, you won't get these errors.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-site-plugin] bertysentry commented on pull request #34: [DOXIA-616]
Posted by GitBox <gi...@apache.org>.
bertysentry commented on pull request #34:
URL: https://github.com/apache/maven-site-plugin/pull/34#issuecomment-762187924
@hboutemy @michael-o @elharo Will you have a chance to review these changes? This ensures the **maven-site-plugin** integration tests don't break when upgrading from Doxia 1.9.1 to 1.10.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-site-plugin] bertysentry commented on pull request #34: [DOXIA-616]
Posted by GitBox <gi...@apache.org>.
bertysentry commented on pull request #34:
URL: https://github.com/apache/maven-site-plugin/pull/34#issuecomment-766418215
@michael-o @hboutemy @elharo Friendly reminder that this PR is still waiting, and its content is not going to change with regards to the failed builds, which are caused by something else (*master* is failing the same builds the same way).
The more we wait, the more risk we have to get conflicting changes.
Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-site-plugin] bertysentry commented on pull request #34: [DOXIA-616]
Posted by GitBox <gi...@apache.org>.
bertysentry commented on pull request #34:
URL: https://github.com/apache/maven-site-plugin/pull/34#issuecomment-762210778
Also, PR #35 just got merged to *master* 3 days ago, with the same CI failures.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-site-plugin] bertysentry commented on pull request #34: [DOXIA-616]
Posted by GitBox <gi...@apache.org>.
bertysentry commented on pull request #34:
URL: https://github.com/apache/maven-site-plugin/pull/34#issuecomment-760182619
@elharo IMO there is no need to wait to merge this PR. This PR ensures the integration tests won't break when upgrading to Doxia 1.10.
The integration tests that currently fail are only for macOS width JDK 11, 14 and 15:
* Error: MSITE-665/pom.xml: See [MSITE-665](https://issues.apache.org/jira/browse/MSITE-665) from 2013
* Error: MSITE-512/pom.xml
* Error: MSITE-506/pom.xml
* Error: MSITE-497/pom.xml
* Error: MSITE-484/pom.xml
They are all ancient issues and completely unrelated to the changes in the integration tests to support Doxia 1.10.
Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-site-plugin] elharo commented on pull request #34: [DOXIA-616]
Posted by GitBox <gi...@apache.org>.
elharo commented on pull request #34:
URL: https://github.com/apache/maven-site-plugin/pull/34#issuecomment-762197773
Before this can move further, someone needs to debug and fix the CI failures. That's likely not caused by this PR, but checking in when the CI is broken is never a good idea.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-site-plugin] bertysentry commented on pull request #34: [DOXIA-616]
Posted by GitBox <gi...@apache.org>.
bertysentry commented on pull request #34:
URL: https://github.com/apache/maven-site-plugin/pull/34#issuecomment-762198733
@elharo We cannot access the integration test logs, how are we going to fix this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-site-plugin] bertysentry commented on pull request #34: [DOXIA-616]
Posted by GitBox <gi...@apache.org>.
bertysentry commented on pull request #34:
URL: https://github.com/apache/maven-site-plugin/pull/34#issuecomment-762207488
I have full permissions on my fork, and it's running all GitHub Actions as well, and failing at the same place (macOS with JDK11, 14 and 15). But I can't find a way to access the files produced by the build (not even the plugin artifact).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-site-plugin] bertysentry commented on pull request #34: [DOXIA-616]
Posted by GitBox <gi...@apache.org>.
bertysentry commented on pull request #34:
URL: https://github.com/apache/maven-site-plugin/pull/34#issuecomment-759814944
Okay, PR has been updated as below:
* Removed Doxia-specific integration tests
* Added integration tests on the various document formats
* Integration tests on macros are done on the SNIPPET macro from a common Java source file
Please note that the builds on macOS with JDK11, 14 and 15 fail, but these failures are not related to this PR (**master** is failing the same way).
@hboutemy @elharo @michael-o Please review these changes. Thank you!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-site-plugin] michael-o commented on pull request #34: [DOXIA-616]
Posted by GitBox <gi...@apache.org>.
michael-o commented on pull request #34:
URL: https://github.com/apache/maven-site-plugin/pull/34#issuecomment-753697914
I won't merge before anyway because I never depend on snapshots.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-site-plugin] bertysentry edited a comment on pull request #34: [DOXIA-616]
Posted by GitBox <gi...@apache.org>.
bertysentry edited a comment on pull request #34:
URL: https://github.com/apache/maven-site-plugin/pull/34#issuecomment-760137856
More build failures: Connection timeout with www.w3.org, which is totally unrelated to this PR.
Edit: Things run smoothly on my fork. See https://github.com/bertysentry/maven-site-plugin/runs/1701505614?check_suite_focus=true
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-site-plugin] bertysentry edited a comment on pull request #34: [DOXIA-616]
Posted by GitBox <gi...@apache.org>.
bertysentry edited a comment on pull request #34:
URL: https://github.com/apache/maven-site-plugin/pull/34#issuecomment-754944421
@hboutemy We will keep some integration tests in *maven-site-plugin* that involve *doxia-module-markdown*. I want to remove specific Doxia tests (like "quotes were mistakenly removed", or "code block must be surrounded with `<div class="source">`.
These can be properly tested in Doxia with unit tests, and also with integration tests. Where applicable, we use integration tests to invoke *maven-site-plugin* with the current version of Doxia and make sure the end-to-end chain works as expected.
I will submit a PR on Doxia to incorporate these specific tests (from *maven-site-plugin*) to *doxia-module-markdown*.
Watch for [DOXIA-618](https://issues.apache.org/jira/browse/DOXIA-618)
Edit: added reference to JIRA issue number
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org