You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@httpd.apache.org by tr...@apache.org on 2004/02/26 21:00:55 UTC
cvs commit: httpd-2.0/modules/loggers mod_log_config.c
trawick 2004/02/26 12:00:55
Modified: modules/loggers mod_log_config.c
Log:
a kind fix for a compile error unfortunately broke an order
dependency... the buffered logs array needs to be initialized
prior to opening the logs
Revision Changes Path
1.114 +9 -7 httpd-2.0/modules/loggers/mod_log_config.c
Index: mod_log_config.c
===================================================================
RCS file: /home/cvs/httpd-2.0/modules/loggers/mod_log_config.c,v
retrieving revision 1.113
retrieving revision 1.114
diff -u -r1.113 -r1.114
--- mod_log_config.c 9 Feb 2004 20:29:20 -0000 1.113
+++ mod_log_config.c 26 Feb 2004 20:00:55 -0000 1.114
@@ -1176,20 +1176,22 @@
static int init_config_log(apr_pool_t *pc, apr_pool_t *p, apr_pool_t *pt, server_rec *s)
{
- /* First, do "physical" server, which gets default log fd and format
+ int res;
+
+ /* First init the buffered logs array, which is needed when opening the logs. */
+ if (buffered_logs) {
+ all_buffered_logs = apr_array_make(p, 5, sizeof(buffered_log *));
+ }
+
+ /* Next, do "physical" server, which gets default log fd and format
* for the virtual servers, if they don't override...
*/
- int res = open_multi_logs(s, p);
+ res = open_multi_logs(s, p);
/* Then, virtual servers */
for (s = s->next; (res == OK) && s; s = s->next) {
res = open_multi_logs(s, p);
- }
-
- /* Finally init buffered logs */
- if (buffered_logs) {
- all_buffered_logs = apr_array_make(p, 5, sizeof(buffered_log *));
}
return res;
Re: cvs commit: httpd-2.0/modules/loggers mod_log_config.c
Posted by André Malo <nd...@perlig.de>.
* trawick@apache.org wrote:
> trawick 2004/02/26 12:00:55
>
> Modified: modules/loggers mod_log_config.c
> Log:
> a kind fix for a compile error unfortunately broke an order
> dependency... the buffered logs array needs to be initialized
> prior to opening the logs
oh? I must have overseen something. I've looked for such a need, the time I've
did the change.
nd