You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/06/11 21:52:46 UTC
[GitHub] [incubator-doris] sdgshawn opened a new pull request #3846: fix for be server crash which throwing syntax error when parse json …
sdgshawn opened a new pull request #3846:
URL: https://github.com/apache/incubator-doris/pull/3846
fix for be server crash which throwing syntax error when parse json from kafka message
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] imay merged pull request #3846: fix for be server crash which throwing syntax error when parse json …
Posted by GitBox <gi...@apache.org>.
imay merged pull request #3846:
URL: https://github.com/apache/incubator-doris/pull/3846
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] imay commented on a change in pull request #3846: fix for be server crash which throwing syntax error when parse json …
Posted by GitBox <gi...@apache.org>.
imay commented on a change in pull request #3846:
URL: https://github.com/apache/incubator-doris/pull/3846#discussion_r439156446
##########
File path: be/src/exprs/json_functions.cpp
##########
@@ -291,7 +291,7 @@ rapidjson::Value* JsonFunctions::get_json_array_from_parsed_json (
}
rapidjson::Value* root = match_value(parsed_paths, document, mem_allocator, true);
- if (root == document) {// not found
+ if (root==nullptr || root == document) {// not found
Review comment:
```suggestion
if (root == nullptr || root == document) {// not found
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org