You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/01/26 02:19:42 UTC

[GitHub] [dolphinscheduler] qianli2022 commented on a change in pull request #8174: [Feature-8167][service] Introduce k8s client and db support multiple environments

qianli2022 commented on a change in pull request #8174:
URL: https://github.com/apache/dolphinscheduler/pull/8174#discussion_r792269135



##########
File path: dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/K8s.java
##########
@@ -0,0 +1,103 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.dolphinscheduler.dao.entity;
+
+import java.util.Date;
+
+import com.baomidou.mybatisplus.annotation.IdType;
+import com.baomidou.mybatisplus.annotation.TableField;
+import com.baomidou.mybatisplus.annotation.TableId;
+import com.baomidou.mybatisplus.annotation.TableName;
+
+/**
+ * multi-data centre k8s temporary structure, waiting for new feature to complete will switch
+ */
+@TableName("t_ds_k8s")

Review comment:
       Hi,you have a multi-environment feature being worked on https://github.com/apache/dolphinscheduler/issues/7623, I consulted Klein and  told me i could support multiple k8s first by db store and wait for that multi-environment to be finished,or I re-implement the transition solution along the lines of your idea, as long as it supports different k8s clusters




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org