You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2018/01/24 18:05:06 UTC
Review Request 65315: Moved 'ObjectApproverAll' into a header for use
in tests.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65315/
-----------------------------------------------------------
Review request for mesos, Benjamin Mahler, Gaston Kleiman, and Vinod Kone.
Bugs: MESOS-8469
https://issues.apache.org/jira/browse/MESOS-8469
Repository: mesos
Description
-------
Moved 'ObjectApproverAll' into a header for use in tests.
Diffs
-----
src/tests/mesos.hpp a35c68e8645384f6244d17e37cad71373aba6893
src/tests/mesos.cpp d751b2e9c635eb6a5039678de426467176cda908
Diff: https://reviews.apache.org/r/65315/diff/1/
Testing
-------
Testing details in the child review.
Thanks,
Greg Mann
Re: Review Request 65315: Moved 'ObjectApproverAll' into a header for
use in tests.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65315/#review196150
-----------------------------------------------------------
FAIL: Mesos tests failed to build.
Reviews applied: `['65315']`
Failed command: `cmake.exe --build . --target mesos-tests --config Debug`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65315
Relevant logs:
- [mesos-tests-build-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65315/logs/mesos-tests-build-cmake-stdout.log):
```
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\server.c(1799): warning C4996: 'strcat': This function or variable may be unsafe. Consider using strcat_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj] [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\server.c(1814): warning C4996: 'strcat': This function or variable may be unsafe. Consider using strcat_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj] [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\server.c(1818): warning C4996: 'strcat': This function or variable may be unsafe. Consider using strcat_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj] [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\server.c(1826): warning C4996: 'strcat': This function or variable may be unsafe. Consider using strcat_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj] [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\server.c(2363): warning C4996: 'strdup': The POSIX name for this item is deprecated. Instead, use the ISO C and C++ conformant name: _strdup. See online help for details. [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj] [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\server.c(2377): warning C4996: 'stricmp': The POSIX name for this item is deprecated. Instead, use the ISO C and C++ conformant name: _stricmp. See online help for details. [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj] [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\seterror.c(189): warning C4996: 'strerror': This function or variable may be unsafe. Consider using strerror_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj] [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\windlopen.c(236): warning C4996: 'strcpy': This function or variable may be unsafe. Consider using strcpy_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj] [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\windlopen.c(241): warning C4996: 'strcat': This function or variable may be unsafe. Consider using strcat_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj] [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\windlopen.c(253): warning C4996: 'strcat': This function or variable may be unsafe. Consider using strcat_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj] [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\windlopen.c(278): warning C4996: 'stricmp': The POSIX name for this item is deprecated. Instead, use the ISO C and C++ conformant name: _stricmp. See online help for details. [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj] [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\windlopen.c(289): warning C4996: 'strcpy': This function or variable may be unsafe. Consider using strcpy_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj] [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\windlopen.c(290): warning C4996: 'strcat': This function or variable may be unsafe. Consider using strcat_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj] [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\windlopen.c(293): warning C4996: 'strcpy': This function or variable may be unsafe. Consider using strcpy_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj] [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\plugins\cram.c(138): warning C4477: 'snprintf' : format string '%lu' requires an argument of type 'unsigned long', but variadic argument 1 has type 'time_t' [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj] [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\plugins\cram.c(157): warning C4996: 'sprintf': This function or variable may be unsafe. Consider using sprintf_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj] [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\plugins\cram.c(293): warning C4996: 'strncpy': This function or variable may be unsafe. Consider using strncpy_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj] [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
"D:\DCOS\mesos\src\tests\mesos-tests.vcxproj" (default target) (1) ->
"D:\DCOS\mesos\src\mesos.vcxproj" (default target) (12) ->
(ClCompile target) ->
D:\DCOS\mesos\mesos\src\executor\executor.cpp(233): error C2039: 'eraseenv': is not a member of 'os' [D:\DCOS\mesos\src\mesos.vcxproj]
D:\DCOS\mesos\mesos\src\executor\executor.cpp(233): error C3861: 'eraseenv': identifier not found [D:\DCOS\mesos\src\mesos.vcxproj]
112 Warning(s)
2 Error(s)
Time Elapsed 00:03:20.71
```
- [mesos-tests-CMakeOutput.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65315/logs/mesos-tests-CMakeOutput.log):
```
Creating directory "cmTC_b956f.dir\Debug\".
Creating directory "D:\DCOS\mesos\CMakeFiles\CMakeTmp\Debug\".
Creating directory "cmTC_b956f.dir\Debug\cmTC_b956f.tlog\".
InitializeBuildStatus:
Creating "cmTC_b956f.dir\Debug\cmTC_b956f.tlog\unsuccessfulbuild" because "AlwaysCreate" was specified.
ClCompile:
C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.12.25827\bin\HostX64\x64\CL.exe /c /Zi /W3 /WX- /diagnostics:classic /Od /Ob0 /D WIN32 /D _WINDOWS /D COMPILER_SUPPORTS_CXX11 /D "CMAKE_INTDIR=\"Debug\"" /D _MBCS /Gm- /EHsc /RTC1 /MDd /GS /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /GR /Fo"cmTC_b956f.dir\Debug\" /Fd"cmTC_b956f.dir\Debug\vc141.pdb" /Gd /TP /errorReport:queue D:\DCOS\mesos\CMakeFiles\CMakeTmp\src.cxx
Microsoft (R) C/C++ Optimizing Compiler Version 19.12.25830.2 for x64
Copyright (C) Microsoft Corporation. All rights reserved.
cl /c /Zi /W3 /WX- /diagnostics:classic /Od /Ob0 /D WIN32 /D _WINDOWS /D COMPILER_SUPPORTS_CXX11 /D "CMAKE_INTDIR=\"Debug\"" /D _MBCS /Gm- /EHsc /RTC1 /MDd /GS /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /GR /Fo"cmTC_b956f.dir\Debug\" /Fd"cmTC_b956f.dir\Debug\vc141.pdb" /Gd /TP /errorReport:queue D:\DCOS\mesos\CMakeFiles\CMakeTmp\src.cxx
src.cxx
Link:
C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.12.25827\bin\HostX64\x64\link.exe /ERRORREPORT:QUEUE /OUT:"D:\DCOS\mesos\CMakeFiles\CMakeTmp\Debug\cmTC_b956f.exe" /INCREMENTAL /NOLOGO kernel32.lib user32.lib gdi32.lib winspool.lib shell32.lib ole32.lib oleaut32.lib uuid.lib comdlg32.lib advapi32.lib /MANIFEST /MANIFESTUAC:"level='asInvoker' uiAccess='false'" /manifest:embed /DEBUG /PDB:"D:/DCOS/mesos/CMakeFiles/CMakeTmp/Debug/cmTC_b956f.pdb" /SUBSYSTEM:CONSOLE /TLBID:1 /DYNAMICBASE /NXCOMPAT /IMPLIB:"D:/DCOS/mesos/CMakeFiles/CMakeTmp/Debug/cmTC_b956f.lib" /MACHINE:X64 /machine:x64 cmTC_b956f.dir\Debug\src.obj
cmTC_b956f.vcxproj -> D:\DCOS\mesos\CMakeFiles\CMakeTmp\Debug\cmTC_b956f.exe
FinalizeBuildStatus:
Deleting file "cmTC_b956f.dir\Debug\cmTC_b956f.tlog\unsuccessfulbuild".
Touching "cmTC_b956f.dir\Debug\cmTC_b956f.tlog\cmTC_b956f.lastbuildstate".
Done Building Project "D:\DCOS\mesos\CMakeFiles\CMakeTmp\cmTC_b956f.vcxproj" (default targets).
Build succeeded.
0 Warning(s)
0 Error(s)
Time Elapsed 00:00:01.43
Source file was:
int main() { return 0; }
```
- [mesos-tests-CMakeError.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65315/logs/mesos-tests-CMakeError.log):
```
PrepareForBuild:
Creating directory "cmTC_3c84b.dir\Debug\".
Creating directory "D:\DCOS\mesos\CMakeFiles\CMakeTmp\Debug\".
Creating directory "cmTC_3c84b.dir\Debug\cmTC_3c84b.tlog\".
InitializeBuildStatus:
Creating "cmTC_3c84b.dir\Debug\cmTC_3c84b.tlog\unsuccessfulbuild" because "AlwaysCreate" was specified.
ClCompile:
C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.12.25827\bin\HostX64\x64\CL.exe /c /Zi /W3 /WX- /diagnostics:classic /MP /Od /Ob0 /D WIN32 /D _WINDOWS /D UNICODE /D _UNICODE /D "CMAKE_INTDIR=\"Debug\"" /D _UNICODE /D UNICODE /Gm- /RTC1 /MTd /GS /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /Fo"cmTC_3c84b.dir\Debug\" /Fd"cmTC_3c84b.dir\Debug\vc141.pdb" /Gd /TC /errorReport:queue D:\DCOS\mesos\CMakeFiles\CMakeTmp\CheckIncludeFile.c
Microsoft (R) C/C++ Optimizing Compiler Version 19.12.25830.2 for x64
Copyright (C) Microsoft Corporation. All rights reserved.
cl /c /Zi /W3 /WX- /diagnostics:classic /MP /Od /Ob0 /D WIN32 /D _WINDOWS /D UNICODE /D _UNICODE /D "CMAKE_INTDIR=\"Debug\"" /D _UNICODE /D UNICODE /Gm- /RTC1 /MTd /GS /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /Fo"cmTC_3c84b.dir\Debug\" /Fd"cmTC_3c84b.dir\Debug\vc141.pdb" /Gd /TC /errorReport:queue D:\DCOS\mesos\CMakeFiles\CMakeTmp\CheckIncludeFile.c
CheckIncludeFile.c
D:\DCOS\mesos\CMakeFiles\CMakeTmp\CheckIncludeFile.c(1): fatal error C1083: Cannot open include file: 'pthread.h': No such file or directory [D:\DCOS\mesos\CMakeFiles\CMakeTmp\cmTC_3c84b.vcxproj]
Done Building Project "D:\DCOS\mesos\CMakeFiles\CMakeTmp\cmTC_3c84b.vcxproj" (default targets) -- FAILED.
Build FAILED.
"D:\DCOS\mesos\CMakeFiles\CMakeTmp\cmTC_3c84b.vcxproj" (default target) (1) ->
(ClCompile target) ->
D:\DCOS\mesos\CMakeFiles\CMakeTmp\CheckIncludeFile.c(1): fatal error C1083: Cannot open include file: 'pthread.h': No such file or directory [D:\DCOS\mesos\CMakeFiles\CMakeTmp\cmTC_3c84b.vcxproj]
0 Warning(s)
1 Error(s)
Time Elapsed 00:00:00.75
```
- Mesos Reviewbot Windows
On Jan. 24, 2018, 6:05 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65315/
> -----------------------------------------------------------
>
> (Updated Jan. 24, 2018, 6:05 p.m.)
>
>
> Review request for mesos, Benjamin Mahler, Gaston Kleiman, and Vinod Kone.
>
>
> Bugs: MESOS-8469
> https://issues.apache.org/jira/browse/MESOS-8469
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Moved 'ObjectApproverAll' into a header for use in tests.
>
>
> Diffs
> -----
>
> src/tests/mesos.hpp a35c68e8645384f6244d17e37cad71373aba6893
> src/tests/mesos.cpp d751b2e9c635eb6a5039678de426467176cda908
>
>
> Diff: https://reviews.apache.org/r/65315/diff/1/
>
>
> Testing
> -------
>
> Testing details in the child review.
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 65315: Removed a redundant authorization helper
class from the tests.
Posted by Greg Mann <gr...@mesosphere.io>.
> On Jan. 27, 2018, 1:25 a.m., Gaston Kleiman wrote:
> > src/tests/mesos.hpp
> > Lines 3177 (patched)
> > <https://reviews.apache.org/r/65315/diff/1/?file=1946019#file1946019line3177>
> >
> > Would `PermissiveObjectApprover` be a better name?
I actually realized that the test class is unnecessary, since we already have an `AcceptingObjectApprover` in common code. Updated the patch accordingly, LMK what you think.
- Greg
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65315/#review196380
-----------------------------------------------------------
On Jan. 31, 2018, 2:52 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65315/
> -----------------------------------------------------------
>
> (Updated Jan. 31, 2018, 2:52 a.m.)
>
>
> Review request for mesos, Benjamin Mahler, Gaston Kleiman, and Vinod Kone.
>
>
> Bugs: MESOS-8469
> https://issues.apache.org/jira/browse/MESOS-8469
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Removed a redundant authorization helper class from the tests.
>
>
> Diffs
> -----
>
> src/tests/mesos.cpp d751b2e9c635eb6a5039678de426467176cda908
>
>
> Diff: https://reviews.apache.org/r/65315/diff/2/
>
>
> Testing
> -------
>
> Testing details in the child review.
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 65315: Moved 'ObjectApproverAll' into a header for
use in tests.
Posted by Gaston Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65315/#review196380
-----------------------------------------------------------
src/tests/mesos.hpp
Lines 3177 (patched)
<https://reviews.apache.org/r/65315/#comment276009>
Would `PermissiveObjectApprover` be a better name?
- Gaston Kleiman
On Jan. 24, 2018, 10:05 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65315/
> -----------------------------------------------------------
>
> (Updated Jan. 24, 2018, 10:05 a.m.)
>
>
> Review request for mesos, Benjamin Mahler, Gaston Kleiman, and Vinod Kone.
>
>
> Bugs: MESOS-8469
> https://issues.apache.org/jira/browse/MESOS-8469
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Moved 'ObjectApproverAll' into a header for use in tests.
>
>
> Diffs
> -----
>
> src/tests/mesos.hpp a35c68e8645384f6244d17e37cad71373aba6893
> src/tests/mesos.cpp d751b2e9c635eb6a5039678de426467176cda908
>
>
> Diff: https://reviews.apache.org/r/65315/diff/1/
>
>
> Testing
> -------
>
> Testing details in the child review.
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 65315: Removed a redundant authorization helper
class from the tests.
Posted by Gaston Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65315/#review197655
-----------------------------------------------------------
Ship it!
Ship It!
- Gaston Kleiman
On Jan. 30, 2018, 6:52 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65315/
> -----------------------------------------------------------
>
> (Updated Jan. 30, 2018, 6:52 p.m.)
>
>
> Review request for mesos, Benjamin Mahler, Gaston Kleiman, and Vinod Kone.
>
>
> Bugs: MESOS-8469
> https://issues.apache.org/jira/browse/MESOS-8469
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Removed a redundant authorization helper class from the tests.
>
>
> Diffs
> -----
>
> src/tests/mesos.cpp d751b2e9c635eb6a5039678de426467176cda908
>
>
> Diff: https://reviews.apache.org/r/65315/diff/2/
>
>
> Testing
> -------
>
> Testing details in the child review.
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 65315: Removed a redundant authorization helper
class from the tests.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65315/
-----------------------------------------------------------
(Updated Jan. 31, 2018, 2:52 a.m.)
Review request for mesos, Benjamin Mahler, Gaston Kleiman, and Vinod Kone.
Summary (updated)
-----------------
Removed a redundant authorization helper class from the tests.
Bugs: MESOS-8469
https://issues.apache.org/jira/browse/MESOS-8469
Repository: mesos
Description (updated)
-------
Removed a redundant authorization helper class from the tests.
Diffs (updated)
-----
src/tests/mesos.cpp d751b2e9c635eb6a5039678de426467176cda908
Diff: https://reviews.apache.org/r/65315/diff/2/
Changes: https://reviews.apache.org/r/65315/diff/1-2/
Testing
-------
Testing details in the child review.
Thanks,
Greg Mann