You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/12/08 01:08:16 UTC
[GitHub] [incubator-superset] betodealmeida opened a new pull request #11956: feat: add modal to import charts
betodealmeida opened a new pull request #11956:
URL: https://github.com/apache/incubator-superset/pull/11956
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
This is https://github.com/apache/incubator-superset/pull/11923, which I messed up while rebasing.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11956: feat: add modal to import charts
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11956:
URL: https://github.com/apache/incubator-superset/pull/11956#issuecomment-740292381
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11956?src=pr&el=h1) Report
> Merging [#11956](https://codecov.io/gh/apache/incubator-superset/pull/11956?src=pr&el=desc) (8b86183) into [master](https://codecov.io/gh/apache/incubator-superset/commit/2b9695c52024b624631ac27c0f2194e280effdb8?el=desc) (2b9695c) will **decrease** coverage by `4.05%`.
> The diff coverage is `70.11%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11956?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11956 +/- ##
==========================================
- Coverage 67.70% 63.64% -4.06%
==========================================
Files 938 940 +2
Lines 45437 45576 +139
Branches 4358 4378 +20
==========================================
- Hits 30761 29009 -1752
- Misses 14573 16390 +1817
- Partials 103 177 +74
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `62.91% <61.83%> (-0.01%)` | :arrow_down: |
| python | `64.08% <95.34%> (-0.14%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11956?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...nd/src/views/CRUD/data/dataset/AddDatasetModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhc2V0L0FkZERhdGFzZXRNb2RhbC50c3g=) | `57.57% <ø> (ø)` | |
| [...perset-frontend/src/views/CRUD/chart/ChartList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY2hhcnQvQ2hhcnRMaXN0LnRzeA==) | `69.10% <45.00%> (-14.54%)` | :arrow_down: |
| [...ontend/src/views/CRUD/data/dataset/DatasetList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhc2V0L0RhdGFzZXRMaXN0LnRzeA==) | `68.58% <61.53%> (-0.65%)` | :arrow_down: |
| [...rontend/src/chart/components/ImportModal/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NvbXBvbmVudHMvSW1wb3J0TW9kYWwvaW5kZXgudHN4) | `65.30% <65.30%> (ø)` | |
| [...nd/src/datasource/components/ImportModal/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvY29tcG9uZW50cy9JbXBvcnRNb2RhbC9pbmRleC50c3g=) | `65.30% <65.30%> (ø)` | |
| [superset/charts/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2ltcG9ydGVycy92MS9fX2luaXRfXy5weQ==) | `93.25% <85.71%> (-0.65%)` | :arrow_down: |
| [...uperset/datasets/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL19faW5pdF9fLnB5) | `92.20% <85.71%> (-0.65%)` | :arrow_down: |
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `80.53% <100.00%> (+0.06%)` | :arrow_up: |
| [superset/charts/commands/importers/dispatcher.py](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2ltcG9ydGVycy9kaXNwYXRjaGVyLnB5) | `80.64% <100.00%> (+1.33%)` | :arrow_up: |
| [superset/charts/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <100.00%> (ø)` | |
| ... and [190 more](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11956?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11956?src=pr&el=footer). Last update [fbb458f...8b86183](https://codecov.io/gh/apache/incubator-superset/pull/11956?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11956: feat: add modal to import charts
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11956:
URL: https://github.com/apache/incubator-superset/pull/11956#issuecomment-740292381
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11956?src=pr&el=h1) Report
> Merging [#11956](https://codecov.io/gh/apache/incubator-superset/pull/11956?src=pr&el=desc) (990ca8a) into [master](https://codecov.io/gh/apache/incubator-superset/commit/2b9695c52024b624631ac27c0f2194e280effdb8?el=desc) (2b9695c) will **decrease** coverage by `4.17%`.
> The diff coverage is `71.25%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11956?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11956 +/- ##
==========================================
- Coverage 67.70% 63.52% -4.18%
==========================================
Files 938 940 +2
Lines 45437 45575 +138
Branches 4358 4378 +20
==========================================
- Hits 30761 28952 -1809
- Misses 14573 16446 +1873
- Partials 103 177 +74
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `62.91% <62.90%> (-0.01%)` | :arrow_down: |
| python | `63.89% <95.34%> (-0.34%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11956?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...nd/src/views/CRUD/data/dataset/AddDatasetModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhc2V0L0FkZERhdGFzZXRNb2RhbC50c3g=) | `57.57% <ø> (ø)` | |
| [...perset-frontend/src/views/CRUD/chart/ChartList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY2hhcnQvQ2hhcnRMaXN0LnRzeA==) | `68.85% <46.15%> (-14.79%)` | :arrow_down: |
| [...ontend/src/views/CRUD/data/dataset/DatasetList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhc2V0L0RhdGFzZXRMaXN0LnRzeA==) | `68.58% <61.53%> (-0.65%)` | :arrow_down: |
| [...rontend/src/chart/components/ImportModal/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NvbXBvbmVudHMvSW1wb3J0TW9kYWwvaW5kZXgudHN4) | `65.30% <65.30%> (ø)` | |
| [...nd/src/datasource/components/ImportModal/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvY29tcG9uZW50cy9JbXBvcnRNb2RhbC9pbmRleC50c3g=) | `65.30% <65.30%> (ø)` | |
| [superset/charts/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2ltcG9ydGVycy92MS9fX2luaXRfXy5weQ==) | `93.25% <85.71%> (-0.65%)` | :arrow_down: |
| [...uperset/datasets/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL19faW5pdF9fLnB5) | `92.20% <85.71%> (-0.65%)` | :arrow_down: |
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `80.53% <100.00%> (+0.06%)` | :arrow_up: |
| [superset/charts/commands/importers/dispatcher.py](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2ltcG9ydGVycy9kaXNwYXRjaGVyLnB5) | `80.64% <100.00%> (+1.33%)` | :arrow_up: |
| [superset/charts/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <100.00%> (ø)` | |
| ... and [188 more](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11956?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11956?src=pr&el=footer). Last update [fbb458f...990ca8a](https://codecov.io/gh/apache/incubator-superset/pull/11956?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11956: feat: add modal to import charts
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11956:
URL: https://github.com/apache/incubator-superset/pull/11956#issuecomment-740292381
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11956?src=pr&el=h1) Report
> Merging [#11956](https://codecov.io/gh/apache/incubator-superset/pull/11956?src=pr&el=desc) (990ca8a) into [master](https://codecov.io/gh/apache/incubator-superset/commit/2b9695c52024b624631ac27c0f2194e280effdb8?el=desc) (2b9695c) will **decrease** coverage by `3.95%`.
> The diff coverage is `71.25%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11956?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11956 +/- ##
==========================================
- Coverage 67.70% 63.74% -3.96%
==========================================
Files 938 940 +2
Lines 45437 45575 +138
Branches 4358 4378 +20
==========================================
- Hits 30761 29054 -1707
- Misses 14573 16344 +1771
- Partials 103 177 +74
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `62.91% <62.90%> (-0.01%)` | :arrow_down: |
| python | `64.24% <95.34%> (+0.02%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11956?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...nd/src/views/CRUD/data/dataset/AddDatasetModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhc2V0L0FkZERhdGFzZXRNb2RhbC50c3g=) | `57.57% <ø> (ø)` | |
| [...perset-frontend/src/views/CRUD/chart/ChartList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY2hhcnQvQ2hhcnRMaXN0LnRzeA==) | `68.85% <46.15%> (-14.79%)` | :arrow_down: |
| [...ontend/src/views/CRUD/data/dataset/DatasetList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhc2V0L0RhdGFzZXRMaXN0LnRzeA==) | `68.58% <61.53%> (-0.65%)` | :arrow_down: |
| [...rontend/src/chart/components/ImportModal/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NvbXBvbmVudHMvSW1wb3J0TW9kYWwvaW5kZXgudHN4) | `65.30% <65.30%> (ø)` | |
| [...nd/src/datasource/components/ImportModal/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvY29tcG9uZW50cy9JbXBvcnRNb2RhbC9pbmRleC50c3g=) | `65.30% <65.30%> (ø)` | |
| [superset/charts/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2ltcG9ydGVycy92MS9fX2luaXRfXy5weQ==) | `93.25% <85.71%> (-0.65%)` | :arrow_down: |
| [...uperset/datasets/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL19faW5pdF9fLnB5) | `92.20% <85.71%> (-0.65%)` | :arrow_down: |
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `80.53% <100.00%> (+0.06%)` | :arrow_up: |
| [superset/charts/commands/importers/dispatcher.py](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2ltcG9ydGVycy9kaXNwYXRjaGVyLnB5) | `80.64% <100.00%> (+1.33%)` | :arrow_up: |
| [superset/charts/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <100.00%> (ø)` | |
| ... and [185 more](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11956?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11956?src=pr&el=footer). Last update [fbb458f...990ca8a](https://codecov.io/gh/apache/incubator-superset/pull/11956?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11956: feat: add modal to import charts
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11956:
URL: https://github.com/apache/incubator-superset/pull/11956#issuecomment-740292381
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11956?src=pr&el=h1) Report
> Merging [#11956](https://codecov.io/gh/apache/incubator-superset/pull/11956?src=pr&el=desc) (990ca8a) into [master](https://codecov.io/gh/apache/incubator-superset/commit/2b9695c52024b624631ac27c0f2194e280effdb8?el=desc) (2b9695c) will **decrease** coverage by `4.31%`.
> The diff coverage is `71.25%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11956?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11956 +/- ##
==========================================
- Coverage 67.70% 63.38% -4.32%
==========================================
Files 938 940 +2
Lines 45437 45575 +138
Branches 4358 4378 +20
==========================================
- Hits 30761 28886 -1875
- Misses 14573 16512 +1939
- Partials 103 177 +74
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `62.91% <62.90%> (-0.01%)` | :arrow_down: |
| python | `63.65% <95.34%> (-0.57%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11956?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...nd/src/views/CRUD/data/dataset/AddDatasetModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhc2V0L0FkZERhdGFzZXRNb2RhbC50c3g=) | `57.57% <ø> (ø)` | |
| [...perset-frontend/src/views/CRUD/chart/ChartList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY2hhcnQvQ2hhcnRMaXN0LnRzeA==) | `68.85% <46.15%> (-14.79%)` | :arrow_down: |
| [...ontend/src/views/CRUD/data/dataset/DatasetList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhc2V0L0RhdGFzZXRMaXN0LnRzeA==) | `68.58% <61.53%> (-0.65%)` | :arrow_down: |
| [...rontend/src/chart/components/ImportModal/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NvbXBvbmVudHMvSW1wb3J0TW9kYWwvaW5kZXgudHN4) | `65.30% <65.30%> (ø)` | |
| [...nd/src/datasource/components/ImportModal/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvY29tcG9uZW50cy9JbXBvcnRNb2RhbC9pbmRleC50c3g=) | `65.30% <65.30%> (ø)` | |
| [superset/charts/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2ltcG9ydGVycy92MS9fX2luaXRfXy5weQ==) | `93.25% <85.71%> (-0.65%)` | :arrow_down: |
| [...uperset/datasets/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL19faW5pdF9fLnB5) | `92.20% <85.71%> (-0.65%)` | :arrow_down: |
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `80.53% <100.00%> (+0.06%)` | :arrow_up: |
| [superset/charts/commands/importers/dispatcher.py](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2ltcG9ydGVycy9kaXNwYXRjaGVyLnB5) | `80.64% <100.00%> (+1.33%)` | :arrow_up: |
| [superset/charts/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <100.00%> (ø)` | |
| ... and [193 more](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11956?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11956?src=pr&el=footer). Last update [fbb458f...990ca8a](https://codecov.io/gh/apache/incubator-superset/pull/11956?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] betodealmeida merged pull request #11956: feat: add modal to import charts
Posted by GitBox <gi...@apache.org>.
betodealmeida merged pull request #11956:
URL: https://github.com/apache/incubator-superset/pull/11956
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11956: feat: add modal to import charts
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11956:
URL: https://github.com/apache/incubator-superset/pull/11956#issuecomment-740292381
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11956?src=pr&el=h1) Report
> Merging [#11956](https://codecov.io/gh/apache/incubator-superset/pull/11956?src=pr&el=desc) (8b86183) into [master](https://codecov.io/gh/apache/incubator-superset/commit/2b9695c52024b624631ac27c0f2194e280effdb8?el=desc) (2b9695c) will **decrease** coverage by `3.61%`.
> The diff coverage is `95.34%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11956?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11956 +/- ##
==========================================
- Coverage 67.70% 64.08% -3.62%
==========================================
Files 938 465 -473
Lines 45437 28588 -16849
Branches 4358 0 -4358
==========================================
- Hits 30761 18320 -12441
+ Misses 14573 10268 -4305
+ Partials 103 0 -103
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `64.08% <95.34%> (-0.15%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11956?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/charts/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2ltcG9ydGVycy92MS9fX2luaXRfXy5weQ==) | `93.25% <85.71%> (-0.65%)` | :arrow_down: |
| [...uperset/datasets/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL19faW5pdF9fLnB5) | `92.20% <85.71%> (-0.65%)` | :arrow_down: |
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `80.53% <100.00%> (+0.06%)` | :arrow_up: |
| [superset/charts/commands/importers/dispatcher.py](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2ltcG9ydGVycy9kaXNwYXRjaGVyLnB5) | `80.64% <100.00%> (+1.33%)` | :arrow_up: |
| [superset/charts/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <100.00%> (ø)` | |
| [...perset/databases/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2ltcG9ydGVycy92MS9fX2luaXRfXy5weQ==) | `97.22% <100.00%> (+0.07%)` | :arrow_up: |
| [superset/datasets/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `92.12% <100.00%> (+0.07%)` | :arrow_up: |
| [superset/datasets/commands/importers/dispatcher.py](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvaW1wb3J0ZXJzL2Rpc3BhdGNoZXIucHk=) | `87.09% <100.00%> (+0.88%)` | :arrow_up: |
| [superset/datasets/commands/importers/v0.py](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvaW1wb3J0ZXJzL3YwLnB5) | `92.95% <100.00%> (ø)` | |
| [superset/datasets/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvc2NoZW1hcy5weQ==) | `96.39% <100.00%> (ø)` | |
| ... and [476 more](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11956?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11956?src=pr&el=footer). Last update [fbb458f...8b86183](https://codecov.io/gh/apache/incubator-superset/pull/11956?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11956: feat: add modal to import charts
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11956:
URL: https://github.com/apache/incubator-superset/pull/11956#issuecomment-740292381
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11956?src=pr&el=h1) Report
> Merging [#11956](https://codecov.io/gh/apache/incubator-superset/pull/11956?src=pr&el=desc) (8b86183) into [master](https://codecov.io/gh/apache/incubator-superset/commit/2b9695c52024b624631ac27c0f2194e280effdb8?el=desc) (2b9695c) will **decrease** coverage by `4.13%`.
> The diff coverage is `95.34%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11956?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11956 +/- ##
==========================================
- Coverage 67.70% 63.56% -4.14%
==========================================
Files 938 465 -473
Lines 45437 28586 -16851
Branches 4358 0 -4358
==========================================
- Hits 30761 18171 -12590
+ Misses 14573 10415 -4158
+ Partials 103 0 -103
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.56% <95.34%> (-0.66%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11956?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/charts/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2ltcG9ydGVycy92MS9fX2luaXRfXy5weQ==) | `93.25% <85.71%> (-0.65%)` | :arrow_down: |
| [...uperset/datasets/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL19faW5pdF9fLnB5) | `92.20% <85.71%> (-0.65%)` | :arrow_down: |
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `80.53% <100.00%> (+0.06%)` | :arrow_up: |
| [superset/charts/commands/importers/dispatcher.py](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2ltcG9ydGVycy9kaXNwYXRjaGVyLnB5) | `80.64% <100.00%> (+1.33%)` | :arrow_up: |
| [superset/charts/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <100.00%> (ø)` | |
| [...perset/databases/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2ltcG9ydGVycy92MS9fX2luaXRfXy5weQ==) | `97.22% <100.00%> (+0.07%)` | :arrow_up: |
| [superset/datasets/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `92.12% <100.00%> (+0.07%)` | :arrow_up: |
| [superset/datasets/commands/importers/dispatcher.py](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvaW1wb3J0ZXJzL2Rpc3BhdGNoZXIucHk=) | `87.09% <100.00%> (+0.88%)` | :arrow_up: |
| [superset/datasets/commands/importers/v0.py](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvaW1wb3J0ZXJzL3YwLnB5) | `92.95% <100.00%> (ø)` | |
| [superset/datasets/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvc2NoZW1hcy5weQ==) | `96.39% <100.00%> (ø)` | |
| ... and [485 more](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11956?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11956?src=pr&el=footer). Last update [fbb458f...8b86183](https://codecov.io/gh/apache/incubator-superset/pull/11956?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11956: feat: add modal to import charts
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11956:
URL: https://github.com/apache/incubator-superset/pull/11956#issuecomment-740292381
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11956?src=pr&el=h1) Report
> Merging [#11956](https://codecov.io/gh/apache/incubator-superset/pull/11956?src=pr&el=desc) (990ca8a) into [master](https://codecov.io/gh/apache/incubator-superset/commit/2b9695c52024b624631ac27c0f2194e280effdb8?el=desc) (2b9695c) will **decrease** coverage by `4.33%`.
> The diff coverage is `71.25%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11956?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11956 +/- ##
==========================================
- Coverage 67.70% 63.36% -4.34%
==========================================
Files 938 940 +2
Lines 45437 45560 +123
Branches 4358 4378 +20
==========================================
- Hits 30761 28868 -1893
- Misses 14573 16515 +1942
- Partials 103 177 +74
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `62.91% <62.90%> (-0.01%)` | :arrow_down: |
| python | `63.63% <95.34%> (-0.60%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11956?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...nd/src/views/CRUD/data/dataset/AddDatasetModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhc2V0L0FkZERhdGFzZXRNb2RhbC50c3g=) | `57.57% <ø> (ø)` | |
| [...perset-frontend/src/views/CRUD/chart/ChartList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY2hhcnQvQ2hhcnRMaXN0LnRzeA==) | `68.85% <46.15%> (-14.79%)` | :arrow_down: |
| [...ontend/src/views/CRUD/data/dataset/DatasetList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhc2V0L0RhdGFzZXRMaXN0LnRzeA==) | `68.58% <61.53%> (-0.65%)` | :arrow_down: |
| [...rontend/src/chart/components/ImportModal/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NvbXBvbmVudHMvSW1wb3J0TW9kYWwvaW5kZXgudHN4) | `65.30% <65.30%> (ø)` | |
| [...nd/src/datasource/components/ImportModal/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvY29tcG9uZW50cy9JbXBvcnRNb2RhbC9pbmRleC50c3g=) | `65.30% <65.30%> (ø)` | |
| [superset/charts/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2ltcG9ydGVycy92MS9fX2luaXRfXy5weQ==) | `93.25% <85.71%> (-0.65%)` | :arrow_down: |
| [...uperset/datasets/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL19faW5pdF9fLnB5) | `92.20% <85.71%> (-0.65%)` | :arrow_down: |
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `80.53% <100.00%> (+0.06%)` | :arrow_up: |
| [superset/charts/commands/importers/dispatcher.py](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2ltcG9ydGVycy9kaXNwYXRjaGVyLnB5) | `80.64% <100.00%> (+1.33%)` | :arrow_up: |
| [superset/charts/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <100.00%> (ø)` | |
| ... and [203 more](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11956?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11956?src=pr&el=footer). Last update [fbb458f...990ca8a](https://codecov.io/gh/apache/incubator-superset/pull/11956?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11956: feat: add modal to import charts
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11956:
URL: https://github.com/apache/incubator-superset/pull/11956#issuecomment-740292381
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11956?src=pr&el=h1) Report
> Merging [#11956](https://codecov.io/gh/apache/incubator-superset/pull/11956?src=pr&el=desc) (990ca8a) into [master](https://codecov.io/gh/apache/incubator-superset/commit/2b9695c52024b624631ac27c0f2194e280effdb8?el=desc) (2b9695c) will **decrease** coverage by `3.95%`.
> The diff coverage is `71.25%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11956?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11956 +/- ##
==========================================
- Coverage 67.70% 63.74% -3.96%
==========================================
Files 938 940 +2
Lines 45437 45575 +138
Branches 4358 4378 +20
==========================================
- Hits 30761 29054 -1707
- Misses 14573 16344 +1771
- Partials 103 177 +74
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `62.91% <62.90%> (-0.01%)` | :arrow_down: |
| python | `64.24% <95.34%> (+0.02%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11956?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...nd/src/views/CRUD/data/dataset/AddDatasetModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhc2V0L0FkZERhdGFzZXRNb2RhbC50c3g=) | `57.57% <ø> (ø)` | |
| [...perset-frontend/src/views/CRUD/chart/ChartList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY2hhcnQvQ2hhcnRMaXN0LnRzeA==) | `68.85% <46.15%> (-14.79%)` | :arrow_down: |
| [...ontend/src/views/CRUD/data/dataset/DatasetList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhc2V0L0RhdGFzZXRMaXN0LnRzeA==) | `68.58% <61.53%> (-0.65%)` | :arrow_down: |
| [...rontend/src/chart/components/ImportModal/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NvbXBvbmVudHMvSW1wb3J0TW9kYWwvaW5kZXgudHN4) | `65.30% <65.30%> (ø)` | |
| [...nd/src/datasource/components/ImportModal/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvY29tcG9uZW50cy9JbXBvcnRNb2RhbC9pbmRleC50c3g=) | `65.30% <65.30%> (ø)` | |
| [superset/charts/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2ltcG9ydGVycy92MS9fX2luaXRfXy5weQ==) | `93.25% <85.71%> (-0.65%)` | :arrow_down: |
| [...uperset/datasets/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL19faW5pdF9fLnB5) | `92.20% <85.71%> (-0.65%)` | :arrow_down: |
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `80.53% <100.00%> (+0.06%)` | :arrow_up: |
| [superset/charts/commands/importers/dispatcher.py](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2ltcG9ydGVycy9kaXNwYXRjaGVyLnB5) | `80.64% <100.00%> (+1.33%)` | :arrow_up: |
| [superset/charts/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <100.00%> (ø)` | |
| ... and [185 more](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11956?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11956?src=pr&el=footer). Last update [fbb458f...8b86183](https://codecov.io/gh/apache/incubator-superset/pull/11956?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11956: feat: add modal to import charts
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11956:
URL: https://github.com/apache/incubator-superset/pull/11956#issuecomment-740292381
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11956?src=pr&el=h1) Report
> Merging [#11956](https://codecov.io/gh/apache/incubator-superset/pull/11956?src=pr&el=desc) (990ca8a) into [master](https://codecov.io/gh/apache/incubator-superset/commit/2b9695c52024b624631ac27c0f2194e280effdb8?el=desc) (2b9695c) will **decrease** coverage by `3.95%`.
> The diff coverage is `71.25%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11956?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11956 +/- ##
==========================================
- Coverage 67.70% 63.74% -3.96%
==========================================
Files 938 940 +2
Lines 45437 45575 +138
Branches 4358 4378 +20
==========================================
- Hits 30761 29054 -1707
- Misses 14573 16344 +1771
- Partials 103 177 +74
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `62.91% <62.90%> (-0.01%)` | :arrow_down: |
| python | `64.24% <95.34%> (+0.02%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11956?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...nd/src/views/CRUD/data/dataset/AddDatasetModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhc2V0L0FkZERhdGFzZXRNb2RhbC50c3g=) | `57.57% <ø> (ø)` | |
| [...perset-frontend/src/views/CRUD/chart/ChartList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY2hhcnQvQ2hhcnRMaXN0LnRzeA==) | `68.85% <46.15%> (-14.79%)` | :arrow_down: |
| [...ontend/src/views/CRUD/data/dataset/DatasetList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhc2V0L0RhdGFzZXRMaXN0LnRzeA==) | `68.58% <61.53%> (-0.65%)` | :arrow_down: |
| [...rontend/src/chart/components/ImportModal/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NvbXBvbmVudHMvSW1wb3J0TW9kYWwvaW5kZXgudHN4) | `65.30% <65.30%> (ø)` | |
| [...nd/src/datasource/components/ImportModal/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvY29tcG9uZW50cy9JbXBvcnRNb2RhbC9pbmRleC50c3g=) | `65.30% <65.30%> (ø)` | |
| [superset/charts/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2ltcG9ydGVycy92MS9fX2luaXRfXy5weQ==) | `93.25% <85.71%> (-0.65%)` | :arrow_down: |
| [...uperset/datasets/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL19faW5pdF9fLnB5) | `92.20% <85.71%> (-0.65%)` | :arrow_down: |
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `80.53% <100.00%> (+0.06%)` | :arrow_up: |
| [superset/charts/commands/importers/dispatcher.py](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2ltcG9ydGVycy9kaXNwYXRjaGVyLnB5) | `80.64% <100.00%> (+1.33%)` | :arrow_up: |
| [superset/charts/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <100.00%> (ø)` | |
| ... and [185 more](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11956?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11956?src=pr&el=footer). Last update [fbb458f...990ca8a](https://codecov.io/gh/apache/incubator-superset/pull/11956?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11956: feat: add modal to import charts
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11956:
URL: https://github.com/apache/incubator-superset/pull/11956#issuecomment-740292381
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11956?src=pr&el=h1) Report
> Merging [#11956](https://codecov.io/gh/apache/incubator-superset/pull/11956?src=pr&el=desc) (8b86183) into [master](https://codecov.io/gh/apache/incubator-superset/commit/2b9695c52024b624631ac27c0f2194e280effdb8?el=desc) (2b9695c) will **decrease** coverage by `3.95%`.
> The diff coverage is `70.11%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11956?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11956 +/- ##
==========================================
- Coverage 67.70% 63.74% -3.96%
==========================================
Files 938 940 +2
Lines 45437 45576 +139
Branches 4358 4378 +20
==========================================
- Hits 30761 29052 -1709
- Misses 14573 16347 +1774
- Partials 103 177 +74
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `62.91% <61.83%> (-0.01%)` | :arrow_down: |
| python | `64.23% <95.34%> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11956?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...nd/src/views/CRUD/data/dataset/AddDatasetModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhc2V0L0FkZERhdGFzZXRNb2RhbC50c3g=) | `57.57% <ø> (ø)` | |
| [...perset-frontend/src/views/CRUD/chart/ChartList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY2hhcnQvQ2hhcnRMaXN0LnRzeA==) | `69.10% <45.00%> (-14.54%)` | :arrow_down: |
| [...ontend/src/views/CRUD/data/dataset/DatasetList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhc2V0L0RhdGFzZXRMaXN0LnRzeA==) | `68.58% <61.53%> (-0.65%)` | :arrow_down: |
| [...rontend/src/chart/components/ImportModal/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NvbXBvbmVudHMvSW1wb3J0TW9kYWwvaW5kZXgudHN4) | `65.30% <65.30%> (ø)` | |
| [...nd/src/datasource/components/ImportModal/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvY29tcG9uZW50cy9JbXBvcnRNb2RhbC9pbmRleC50c3g=) | `65.30% <65.30%> (ø)` | |
| [superset/charts/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2ltcG9ydGVycy92MS9fX2luaXRfXy5weQ==) | `93.25% <85.71%> (-0.65%)` | :arrow_down: |
| [...uperset/datasets/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL19faW5pdF9fLnB5) | `92.20% <85.71%> (-0.65%)` | :arrow_down: |
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `80.53% <100.00%> (+0.06%)` | :arrow_up: |
| [superset/charts/commands/importers/dispatcher.py](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2ltcG9ydGVycy9kaXNwYXRjaGVyLnB5) | `80.64% <100.00%> (+1.33%)` | :arrow_up: |
| [superset/charts/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <100.00%> (ø)` | |
| ... and [186 more](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11956?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11956?src=pr&el=footer). Last update [fbb458f...8b86183](https://codecov.io/gh/apache/incubator-superset/pull/11956?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11956: feat: add modal to import charts
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11956:
URL: https://github.com/apache/incubator-superset/pull/11956#issuecomment-740292381
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11956?src=pr&el=h1) Report
> Merging [#11956](https://codecov.io/gh/apache/incubator-superset/pull/11956?src=pr&el=desc) (8b86183) into [master](https://codecov.io/gh/apache/incubator-superset/commit/2b9695c52024b624631ac27c0f2194e280effdb8?el=desc) (2b9695c) will **decrease** coverage by `4.13%`.
> The diff coverage is `95.34%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11956?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11956 +/- ##
==========================================
- Coverage 67.70% 63.56% -4.14%
==========================================
Files 938 465 -473
Lines 45437 28588 -16849
Branches 4358 0 -4358
==========================================
- Hits 30761 18172 -12589
+ Misses 14573 10416 -4157
+ Partials 103 0 -103
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.56% <95.34%> (-0.66%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11956?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/charts/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2ltcG9ydGVycy92MS9fX2luaXRfXy5weQ==) | `93.25% <85.71%> (-0.65%)` | :arrow_down: |
| [...uperset/datasets/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL19faW5pdF9fLnB5) | `92.20% <85.71%> (-0.65%)` | :arrow_down: |
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `80.53% <100.00%> (+0.06%)` | :arrow_up: |
| [superset/charts/commands/importers/dispatcher.py](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2ltcG9ydGVycy9kaXNwYXRjaGVyLnB5) | `80.64% <100.00%> (+1.33%)` | :arrow_up: |
| [superset/charts/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <100.00%> (ø)` | |
| [...perset/databases/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2ltcG9ydGVycy92MS9fX2luaXRfXy5weQ==) | `97.22% <100.00%> (+0.07%)` | :arrow_up: |
| [superset/datasets/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `92.12% <100.00%> (+0.07%)` | :arrow_up: |
| [superset/datasets/commands/importers/dispatcher.py](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvaW1wb3J0ZXJzL2Rpc3BhdGNoZXIucHk=) | `87.09% <100.00%> (+0.88%)` | :arrow_up: |
| [superset/datasets/commands/importers/v0.py](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvaW1wb3J0ZXJzL3YwLnB5) | `92.95% <100.00%> (ø)` | |
| [superset/datasets/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvc2NoZW1hcy5weQ==) | `96.39% <100.00%> (ø)` | |
| ... and [484 more](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11956?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11956?src=pr&el=footer). Last update [fbb458f...8b86183](https://codecov.io/gh/apache/incubator-superset/pull/11956?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11956: feat: add modal to import charts
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11956:
URL: https://github.com/apache/incubator-superset/pull/11956#issuecomment-740292381
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11956?src=pr&el=h1) Report
> Merging [#11956](https://codecov.io/gh/apache/incubator-superset/pull/11956?src=pr&el=desc) (8b86183) into [master](https://codecov.io/gh/apache/incubator-superset/commit/2b9695c52024b624631ac27c0f2194e280effdb8?el=desc) (2b9695c) will **decrease** coverage by `3.61%`.
> The diff coverage is `95.34%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11956?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11956 +/- ##
==========================================
- Coverage 67.70% 64.08% -3.62%
==========================================
Files 938 465 -473
Lines 45437 28588 -16849
Branches 4358 0 -4358
==========================================
- Hits 30761 18321 -12440
+ Misses 14573 10267 -4306
+ Partials 103 0 -103
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `64.08% <95.34%> (-0.14%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11956?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/charts/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2ltcG9ydGVycy92MS9fX2luaXRfXy5weQ==) | `93.25% <85.71%> (-0.65%)` | :arrow_down: |
| [...uperset/datasets/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL19faW5pdF9fLnB5) | `92.20% <85.71%> (-0.65%)` | :arrow_down: |
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `80.53% <100.00%> (+0.06%)` | :arrow_up: |
| [superset/charts/commands/importers/dispatcher.py](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2ltcG9ydGVycy9kaXNwYXRjaGVyLnB5) | `80.64% <100.00%> (+1.33%)` | :arrow_up: |
| [superset/charts/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <100.00%> (ø)` | |
| [...perset/databases/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2ltcG9ydGVycy92MS9fX2luaXRfXy5weQ==) | `97.22% <100.00%> (+0.07%)` | :arrow_up: |
| [superset/datasets/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `92.12% <100.00%> (+0.07%)` | :arrow_up: |
| [superset/datasets/commands/importers/dispatcher.py](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvaW1wb3J0ZXJzL2Rpc3BhdGNoZXIucHk=) | `87.09% <100.00%> (+0.88%)` | :arrow_up: |
| [superset/datasets/commands/importers/v0.py](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvaW1wb3J0ZXJzL3YwLnB5) | `92.95% <100.00%> (ø)` | |
| [superset/datasets/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvc2NoZW1hcy5weQ==) | `96.39% <100.00%> (ø)` | |
| ... and [475 more](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11956?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11956?src=pr&el=footer). Last update [fbb458f...8b86183](https://codecov.io/gh/apache/incubator-superset/pull/11956?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11956: feat: add modal to import charts
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11956:
URL: https://github.com/apache/incubator-superset/pull/11956#issuecomment-740292381
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11956?src=pr&el=h1) Report
> Merging [#11956](https://codecov.io/gh/apache/incubator-superset/pull/11956?src=pr&el=desc) (8b86183) into [master](https://codecov.io/gh/apache/incubator-superset/commit/2b9695c52024b624631ac27c0f2194e280effdb8?el=desc) (2b9695c) will **decrease** coverage by `3.94%`.
> The diff coverage is `70.11%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11956?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11956 +/- ##
==========================================
- Coverage 67.70% 63.75% -3.95%
==========================================
Files 938 940 +2
Lines 45437 45576 +139
Branches 4358 4378 +20
==========================================
- Hits 30761 29055 -1706
- Misses 14573 16344 +1771
- Partials 103 177 +74
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `62.91% <61.83%> (-0.01%)` | :arrow_down: |
| python | `64.24% <95.34%> (+0.02%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11956?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...nd/src/views/CRUD/data/dataset/AddDatasetModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhc2V0L0FkZERhdGFzZXRNb2RhbC50c3g=) | `57.57% <ø> (ø)` | |
| [...perset-frontend/src/views/CRUD/chart/ChartList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY2hhcnQvQ2hhcnRMaXN0LnRzeA==) | `69.10% <45.00%> (-14.54%)` | :arrow_down: |
| [...ontend/src/views/CRUD/data/dataset/DatasetList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhc2V0L0RhdGFzZXRMaXN0LnRzeA==) | `68.58% <61.53%> (-0.65%)` | :arrow_down: |
| [...rontend/src/chart/components/ImportModal/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NvbXBvbmVudHMvSW1wb3J0TW9kYWwvaW5kZXgudHN4) | `65.30% <65.30%> (ø)` | |
| [...nd/src/datasource/components/ImportModal/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvY29tcG9uZW50cy9JbXBvcnRNb2RhbC9pbmRleC50c3g=) | `65.30% <65.30%> (ø)` | |
| [superset/charts/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2ltcG9ydGVycy92MS9fX2luaXRfXy5weQ==) | `93.25% <85.71%> (-0.65%)` | :arrow_down: |
| [...uperset/datasets/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL19faW5pdF9fLnB5) | `92.20% <85.71%> (-0.65%)` | :arrow_down: |
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `80.53% <100.00%> (+0.06%)` | :arrow_up: |
| [superset/charts/commands/importers/dispatcher.py](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2ltcG9ydGVycy9kaXNwYXRjaGVyLnB5) | `80.64% <100.00%> (+1.33%)` | :arrow_up: |
| [superset/charts/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <100.00%> (ø)` | |
| ... and [185 more](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11956?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11956?src=pr&el=footer). Last update [fbb458f...8b86183](https://codecov.io/gh/apache/incubator-superset/pull/11956?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11956: feat: add modal to import charts
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11956:
URL: https://github.com/apache/incubator-superset/pull/11956#issuecomment-740292381
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11956?src=pr&el=h1) Report
> Merging [#11956](https://codecov.io/gh/apache/incubator-superset/pull/11956?src=pr&el=desc) (8b86183) into [master](https://codecov.io/gh/apache/incubator-superset/commit/2b9695c52024b624631ac27c0f2194e280effdb8?el=desc) (2b9695c) will **decrease** coverage by `4.04%`.
> The diff coverage is `95.34%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11956?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11956 +/- ##
==========================================
- Coverage 67.70% 63.65% -4.05%
==========================================
Files 938 465 -473
Lines 45437 28588 -16849
Branches 4358 0 -4358
==========================================
- Hits 30761 18199 -12562
+ Misses 14573 10389 -4184
+ Partials 103 0 -103
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.65% <95.34%> (-0.57%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11956?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/charts/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2ltcG9ydGVycy92MS9fX2luaXRfXy5weQ==) | `93.25% <85.71%> (-0.65%)` | :arrow_down: |
| [...uperset/datasets/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL19faW5pdF9fLnB5) | `92.20% <85.71%> (-0.65%)` | :arrow_down: |
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `80.53% <100.00%> (+0.06%)` | :arrow_up: |
| [superset/charts/commands/importers/dispatcher.py](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2ltcG9ydGVycy9kaXNwYXRjaGVyLnB5) | `80.64% <100.00%> (+1.33%)` | :arrow_up: |
| [superset/charts/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <100.00%> (ø)` | |
| [...perset/databases/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2ltcG9ydGVycy92MS9fX2luaXRfXy5weQ==) | `97.22% <100.00%> (+0.07%)` | :arrow_up: |
| [superset/datasets/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `92.12% <100.00%> (+0.07%)` | :arrow_up: |
| [superset/datasets/commands/importers/dispatcher.py](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvaW1wb3J0ZXJzL2Rpc3BhdGNoZXIucHk=) | `87.09% <100.00%> (+0.88%)` | :arrow_up: |
| [superset/datasets/commands/importers/v0.py](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvaW1wb3J0ZXJzL3YwLnB5) | `92.95% <100.00%> (ø)` | |
| [superset/datasets/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvc2NoZW1hcy5weQ==) | `96.39% <100.00%> (ø)` | |
| ... and [478 more](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11956?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11956?src=pr&el=footer). Last update [fbb458f...8b86183](https://codecov.io/gh/apache/incubator-superset/pull/11956?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on pull request #11956: feat: add modal to import charts
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #11956:
URL: https://github.com/apache/incubator-superset/pull/11956#issuecomment-740292381
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11956?src=pr&el=h1) Report
> Merging [#11956](https://codecov.io/gh/apache/incubator-superset/pull/11956?src=pr&el=desc) (990ca8a) into [master](https://codecov.io/gh/apache/incubator-superset/commit/2b9695c52024b624631ac27c0f2194e280effdb8?el=desc) (2b9695c) will **decrease** coverage by `4.40%`.
> The diff coverage is `95.34%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11956?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11956 +/- ##
==========================================
- Coverage 67.70% 63.29% -4.41%
==========================================
Files 938 465 -473
Lines 45437 28573 -16864
Branches 4358 0 -4358
==========================================
- Hits 30761 18084 -12677
+ Misses 14573 10489 -4084
+ Partials 103 0 -103
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.29% <95.34%> (-0.94%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11956?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/charts/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2ltcG9ydGVycy92MS9fX2luaXRfXy5weQ==) | `93.25% <85.71%> (-0.65%)` | :arrow_down: |
| [...uperset/datasets/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL19faW5pdF9fLnB5) | `92.20% <85.71%> (-0.65%)` | :arrow_down: |
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `80.53% <100.00%> (+0.06%)` | :arrow_up: |
| [superset/charts/commands/importers/dispatcher.py](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2ltcG9ydGVycy9kaXNwYXRjaGVyLnB5) | `80.64% <100.00%> (+1.33%)` | :arrow_up: |
| [superset/charts/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <100.00%> (ø)` | |
| [...perset/databases/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2ltcG9ydGVycy92MS9fX2luaXRfXy5weQ==) | `97.22% <100.00%> (+0.07%)` | :arrow_up: |
| [superset/datasets/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `92.12% <100.00%> (+0.07%)` | :arrow_up: |
| [superset/datasets/commands/importers/dispatcher.py](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvaW1wb3J0ZXJzL2Rpc3BhdGNoZXIucHk=) | `87.09% <100.00%> (+0.88%)` | :arrow_up: |
| [superset/datasets/commands/importers/v0.py](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvaW1wb3J0ZXJzL3YwLnB5) | `92.95% <100.00%> (ø)` | |
| [superset/datasets/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvc2NoZW1hcy5weQ==) | `96.39% <100.00%> (ø)` | |
| ... and [501 more](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11956?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11956?src=pr&el=footer). Last update [fbb458f...990ca8a](https://codecov.io/gh/apache/incubator-superset/pull/11956?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org