You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/10/20 16:42:02 UTC
[GitHub] [iceberg] RussellSpitzer opened a new pull request #3329: [Benchmark] Improve perf of Dictionary Benchmark Setup
RussellSpitzer opened a new pull request #3329:
URL: https://github.com/apache/iceberg/pull/3329
Previously the benchmarking code used a number of "when" constructs to
generate data in rings. This became much more expensive somewhere between
Spark 2.4.5 and 2.4.6 for reasons we are not certain of. In an attempt
to improve performance we have removed all of these constructs and
replaced them with identical modulo operations and add date operations
when applicable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] RussellSpitzer commented on pull request #3329: [Benchmark] Improve perf of Dictionary Benchmark Setup
Posted by GitBox <gi...@apache.org>.
RussellSpitzer commented on pull request #3329:
URL: https://github.com/apache/iceberg/pull/3329#issuecomment-947868710
https://github.com/apache/iceberg/pull/3330
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #3329: [Benchmark] Improve perf of Dictionary Benchmark Setup
Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #3329:
URL: https://github.com/apache/iceberg/pull/3329#issuecomment-947862237
I'm going to merge this before tests pass because it only modifies benchmark code that won't affect tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #3329: [Benchmark] Improve perf of Dictionary Benchmark Setup
Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #3329:
URL: https://github.com/apache/iceberg/pull/3329#issuecomment-947861663
Good catch!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue merged pull request #3329: [Benchmark] Improve perf of Dictionary Benchmark Setup
Posted by GitBox <gi...@apache.org>.
rdblue merged pull request #3329:
URL: https://github.com/apache/iceberg/pull/3329
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] RussellSpitzer commented on pull request #3329: [Benchmark] Improve perf of Dictionary Benchmark Setup
Posted by GitBox <gi...@apache.org>.
RussellSpitzer commented on pull request #3329:
URL: https://github.com/apache/iceberg/pull/3329#issuecomment-947867020
Ahh it wasn't done :( I broke the spark2 jmh tests, just fixed and pushed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] nastra commented on pull request #3329: [Benchmark] Improve perf of Dictionary Benchmark Setup
Posted by GitBox <gi...@apache.org>.
nastra commented on pull request #3329:
URL: https://github.com/apache/iceberg/pull/3329#issuecomment-948386260
fixes #3157
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org