You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jmeter.apache.org by ham1 <gi...@git.apache.org> on 2017/11/26 17:51:55 UTC
[GitHub] jmeter pull request #343: Reduced the size of all screenshots.
GitHub user ham1 opened a pull request:
https://github.com/apache/jmeter/pull/343
Reduced the size of all screenshots.
## Description
Reduced size of all png screenshots using: `pngquant -f --ext .png --quality 70-95 *.png`.
Most were only reduced marginally but some were reduced a lot. This should probably be done for each new screenshot to ensure source control and the doc website loads as fast as possible.
Also:
Removed workbench from a few screenshots.
Removed unused screenshots.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ham1/jmeter doc_screenshots
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/jmeter/pull/343.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #343
----
commit 43e81eab0c44f82efd106b3ef2a3650d5429e0c9
Author: Graham Russell <gr...@ham1.co.uk>
Date: 2017-11-26T17:48:59Z
Reduced the size of all screenshots.
Removed workbench from a few screenshots.
Removed unused screenshots.
----
---
[GitHub] jmeter issue #343: Reduced the size of all screenshots.
Posted by FSchumacher <gi...@git.apache.org>.
Github user FSchumacher commented on the issue:
https://github.com/apache/jmeter/pull/343
Some of those images have been reduced already in the past. In my tests pngquant will happily compress those again, but that would probably be at 0.75*0.75 quality.
---
[GitHub] jmeter issue #343: Reduced the size of all screenshots.
Posted by pmouawad <gi...@git.apache.org>.
Github user pmouawad commented on the issue:
https://github.com/apache/jmeter/pull/343
Hi Team,
if there are volunteer to merge this one, thanks in advance.
Regards
---
[GitHub] jmeter pull request #343: Reduced the size of all screenshots.
Posted by ham1 <gi...@git.apache.org>.
Github user ham1 closed the pull request at:
https://github.com/apache/jmeter/pull/343
---
[GitHub] jmeter issue #343: Reduced the size of all screenshots.
Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:
https://github.com/apache/jmeter/pull/343
# [Codecov](https://codecov.io/gh/apache/jmeter/pull/343?src=pr&el=h1) Report
> Merging [#343](https://codecov.io/gh/apache/jmeter/pull/343?src=pr&el=desc) into [trunk](https://codecov.io/gh/apache/jmeter/commit/ffb434e7df9fa56358c99dbb8cda9119f63daf89?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/jmeter/pull/343?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## trunk #343 +/- ##
=========================================
Coverage 58.06% 58.06%
Complexity 10100 10100
=========================================
Files 1153 1153
Lines 73868 73868
Branches 7337 7337
=========================================
Hits 42893 42893
Misses 28496 28496
Partials 2479 2479
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/jmeter/pull/343?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/jmeter/pull/343?src=pr&el=footer). Last update [ffb434e...43e81ea](https://codecov.io/gh/apache/jmeter/pull/343?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---
[GitHub] jmeter pull request #343: Reduced the size of all screenshots.
Posted by ham1 <gi...@git.apache.org>.
GitHub user ham1 reopened a pull request:
https://github.com/apache/jmeter/pull/343
Reduced the size of all screenshots.
## Description
Reduced size of all png screenshots using: `pngquant -f --ext .png --quality 70-95 *.png`.
Most were only reduced marginally but some were reduced a lot. This should probably be done for each new screenshot to ensure source control and the doc website loads as fast as possible.
Also:
Removed workbench from a few screenshots.
Removed unused screenshots.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ham1/jmeter doc_screenshots
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/jmeter/pull/343.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #343
----
commit 2ea40bc692e07778acd2c4e402bce9421cbe9985
Author: Graham Russell <gr...@ham1.co.uk>
Date: 2017-12-03T12:47:06Z
compressed pngs with saving greater than 2k
commit b9ba0ba77078c005bc9fcae4a37382109d9b7069
Author: Graham Russell <gr...@ham1.co.uk>
Date: 2017-12-03T13:00:09Z
Removed unused screenshots
commit 75c23e0fdf2184e8c1d88d502eea6a181447c9b3
Author: Graham Russell <gr...@ham1.co.uk>
Date: 2017-12-03T13:01:39Z
Merge branch 'compress_png' into doc_screenshots
----
---
[GitHub] jmeter issue #343: Reduced the size of all screenshots.
Posted by ham1 <gi...@git.apache.org>.
Github user ham1 commented on the issue:
https://github.com/apache/jmeter/pull/343
I've updated the PR:
* removed an unused screenshot
* de-duped a screenshot and
* compressed all png images with an individual saving of more than 2048 bytes using the command line and script below.
`find xdocs/ src/ test/ bin/ -iname "*.png" -print0 | xargs -0 -n 1 -P 3 ./compare-size.sh `
```bash
#!/bin/bash
set -e
err_report() {
echo "Error on line $1"
rm -v "${2}.new"
}
trap 'err_report ${LINENO} ${1}' ERR
pngquant --quality=70-100 --output "${1}.new" "${1}"
oldSize=$(stat -c%s "${1}")
newSize=$(stat -c%s "${1}.new")
let "diff = ${oldSize} - ${newSize}" || true # if sum is 0
let "threshold = ${newSize} + (1024 * 2)"
if [[ ${oldSize} -ge ${threshold} ]]
then
echo "${1} compressed, saved ${diff}"
mv "${1}.new" "${1}"
else
rm -v "${1}.new"
fi
```
---
[GitHub] jmeter issue #343: Reduced the size of all screenshots.
Posted by FSchumacher <gi...@git.apache.org>.
Github user FSchumacher commented on the issue:
https://github.com/apache/jmeter/pull/343
Thanks for your contribution. I ran the shell commands on current trunk, inspected the changed images and committed them.
---
[GitHub] jmeter issue #343: Reduced the size of all screenshots.
Posted by ham1 <gi...@git.apache.org>.
Github user ham1 commented on the issue:
https://github.com/apache/jmeter/pull/343
Deleted the wrong branch...
---
[GitHub] jmeter pull request #343: Reduced the size of all screenshots.
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/jmeter/pull/343
---