[GitHub] [incubator-druid] clintropolis commented on a change in pull request #8426: groupBy query: optional limit push down to segment scan

[GitBox <gi...@apache.org>]

clintropolis commented on a change in pull request #8426:  groupBy query: optional limit push down to segment scan
URL: https://github.com/apache/incubator-druid/pull/8426#discussion_r325923084
 
 

 ##########
 File path: processing/src/main/java/org/apache/druid/query/groupby/GroupByQueryConfig.java
 ##########
 @@ -78,6 +79,9 @@
   @JsonProperty
   private boolean forcePushDownLimit = false;
 
+  @JsonProperty
+  private boolean applyLimitPushDownToSegment = true;
 
 Review comment:
   Is there a reason we wouldn't want to do this? It seems like it would always be better? Are we just being cautious just in case the new behavior is bad in some cases?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org