You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by "vchiapaikeo (via GitHub)" <gi...@apache.org> on 2023/12/18 01:19:31 UTC

Re: [PR] Modify SmtpNotifier to accept template with defaults [airflow]

vchiapaikeo commented on code in PR #36226:
URL: https://github.com/apache/airflow/pull/36226#discussion_r1429356248


##########
airflow/providers/smtp/notifications/smtp.py:
##########
@@ -47,31 +50,41 @@ class SmtpNotifier(BaseNotifier):
 
     def __init__(
         self,
-        from_email: str | None,
+        *,

Review Comment:
   This introduces a potential breaking change for any uses of SmtpNotifier that rely on positional arguments. Thoughts? Alternatively, we could just keep it as is and require that users pass it like was done before.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org