You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Mike Percy (Code Review)" <ge...@cloudera.org> on 2017/01/06 01:08:31 UTC
[kudu-CR] path util: Add SplitPath() helper function
Mike Percy has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5628
Change subject: path_util: Add SplitPath() helper function
......................................................................
path_util: Add SplitPath() helper function
This function provides a (theoretically) portable method of splitting a
filesystem path into its constituent components.
Change-Id: I49e7a37e905e3f4897449ce8fcd1104bfacb4a94
---
M src/kudu/util/path_util-test.cc
M src/kudu/util/path_util.cc
M src/kudu/util/path_util.h
3 files changed, 35 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/28/5628/1
--
To view, visit http://gerrit.cloudera.org:8080/5628
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I49e7a37e905e3f4897449ce8fcd1104bfacb4a94
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
[kudu-CR] path util: Add SplitPath() helper function
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change.
Change subject: path_util: Add SplitPath() helper function
......................................................................
Patch Set 1:
(2 comments)
I am going to merge this into the CreateDirsRecursively() CR per Todd's request.
http://gerrit.cloudera.org:8080/#/c/5628/1/src/kudu/util/path_util.cc
File src/kudu/util/path_util.cc:
Line 56: vector<string> SplitPath(const string &path) {
> Here too.
Done
http://gerrit.cloudera.org:8080/#/c/5628/1/src/kudu/util/path_util.h
File src/kudu/util/path_util.h:
Line 43: std::vector<std::string> SplitPath(const std::string &path);
> Nit: const std::string& path
Done
--
To view, visit http://gerrit.cloudera.org:8080/5628
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I49e7a37e905e3f4897449ce8fcd1104bfacb4a94
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] path util: Add SplitPath() helper function
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has abandoned this change.
Change subject: path_util: Add SplitPath() helper function
......................................................................
Abandoned
Merging into https://gerrit.cloudera.org/5618
--
To view, visit http://gerrit.cloudera.org:8080/5628
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: abandon
Gerrit-Change-Id: I49e7a37e905e3f4897449ce8fcd1104bfacb4a94
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] path util: Add SplitPath() helper function
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: path_util: Add SplitPath() helper function
......................................................................
Patch Set 1:
(2 comments)
Still not sure whether we should allow "empty" paths, but the approach you took here (garbage in, garbage out) is OK I guess.
http://gerrit.cloudera.org:8080/#/c/5628/1/src/kudu/util/path_util.cc
File src/kudu/util/path_util.cc:
Line 56: vector<string> SplitPath(const string &path) {
Here too.
http://gerrit.cloudera.org:8080/#/c/5628/1/src/kudu/util/path_util.h
File src/kudu/util/path_util.h:
Line 43: std::vector<std::string> SplitPath(const std::string &path);
Nit: const std::string& path
--
To view, visit http://gerrit.cloudera.org:8080/5628
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I49e7a37e905e3f4897449ce8fcd1104bfacb4a94
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes