You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2019/08/14 18:55:50 UTC
[GitHub] [incubator-gobblin] codecov-io commented on issue #2713:
[GOBBLIN-857] Extending getTopicsFromConfigStore to accept topicName directly
codecov-io commented on issue #2713: [GOBBLIN-857] Extending getTopicsFromConfigStore to accept topicName directly
URL: https://github.com/apache/incubator-gobblin/pull/2713#issuecomment-521373562
# [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2713?src=pr&el=h1) Report
> Merging [#2713](https://codecov.io/gh/apache/incubator-gobblin/pull/2713?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/8006ac900554df0a33ba1c1aac9205ef30841d17?src=pr&el=desc) will **increase** coverage by `<.01%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/2713?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2713 +/- ##
============================================
+ Coverage 45.08% 45.08% +<.01%
- Complexity 8739 8741 +2
============================================
Files 1879 1879
Lines 70161 70162 +1
Branches 7703 7703
============================================
+ Hits 31630 31631 +1
+ Misses 35612 35610 -2
- Partials 2919 2921 +2
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2713?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...urce/extractor/extract/kafka/ConfigStoreUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2713/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4ta2Fma2EtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NvdXJjZS9leHRyYWN0b3IvZXh0cmFjdC9rYWZrYS9Db25maWdTdG9yZVV0aWxzLmphdmE=) | `60% <100%> (+0.42%)` | `18 <2> (+1)` | :arrow_up: |
| [.../org/apache/gobblin/cluster/GobblinTaskRunner.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2713/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpblRhc2tSdW5uZXIuamF2YQ==) | `64.78% <0%> (-1.41%)` | `29% <0%> (ø)` | |
| [.../apache/gobblin/runtime/api/JobExecutionState.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2713/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvYXBpL0pvYkV4ZWN1dGlvblN0YXRlLmphdmE=) | `79.43% <0%> (-0.94%)` | `24% <0%> (ø)` | |
| [...in/java/org/apache/gobblin/cluster/HelixUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2713/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvSGVsaXhVdGlscy5qYXZh) | `39.25% <0%> (+3.73%)` | `13% <0%> (+1%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2713?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2713?src=pr&el=footer). Last update [8006ac9...2de603d](https://codecov.io/gh/apache/incubator-gobblin/pull/2713?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services