[GitHub] [shardingsphere] xbkaishui commented on a change in pull request #7574: Refactor change YamlRuleSchemaMetaData same with RuleSchemaMetaData

[GitBox <gi...@apache.org>]

xbkaishui commented on a change in pull request #7574:
URL: https://github.com/apache/shardingsphere/pull/7574#discussion_r493374607



##########
File path: shardingsphere-governance/shardingsphere-governance-core/shardingsphere-governance-core-config/src/test/resources/yaml/metadata.yaml
##########
@@ -30,15 +30,4 @@ configuredSchemaMetaData:
             name: PRIMARY          
 unconfiguredSchemaMetaDataMap:
   ds_0:
-    tables:
-      t_user:
-        columns:
-          id:
-            caseSensitive: false
-            dataType: 0
-            generated: false
-            name: id
-            primaryKey: true
-        indexes:
-          primary:
-            name: PRIMARY
+    - t_user

Review comment:
       done

##########
File path: shardingsphere-governance/shardingsphere-governance-core/shardingsphere-governance-core-common/src/main/java/org/apache/shardingsphere/governance/core/yaml/config/metadata/YamlRuleSchemaMetaData.java
##########
@@ -32,5 +33,5 @@
 
     private YamlSchemaMetaData configuredSchemaMetaData;
 
-    private Map<String, YamlSchemaMetaData> unconfiguredSchemaMetaDataMap;
+    private Map<String, Collection<String>> unconfiguredSchemaMetaDataMap;

Review comment:
       done




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org