[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #3895: Fix the RecordReader to pick incoming time column

[GitBox <gi...@apache.org>]

jackjlli commented on a change in pull request #3895: Fix the RecordReader to pick incoming time column
URL: https://github.com/apache/incubator-pinot/pull/3895#discussion_r262261945
 
 

 ##########
 File path: pinot-core/src/main/java/org/apache/pinot/core/data/readers/AvroRecordReader.java
 ##########
 @@ -59,9 +62,9 @@ public AvroRecordReader(File dataFile, Schema schema)
 
   private void validateSchema() {
     org.apache.avro.Schema avroSchema = _avroReader.getSchema();
-    for (FieldSpec fieldSpec : _schema.getAllFieldSpecs()) {
+    for (FieldSpec fieldSpec : _fieldSpecs) {
       String fieldName = fieldSpec.getName();
 
 Review comment:
   This variable assignment is duplicated with the following line. Just keep one of them.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org