You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/08/30 18:50:39 UTC

[GitHub] [shardingsphere] abhinav-koppula opened a new pull request, #20665: [#19911]-Added unit test for JDBCRepositoryProviderFactory

abhinav-koppula opened a new pull request, #20665:
URL: https://github.com/apache/shardingsphere/pull/20665

   Fixes #19911.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] terrymanu merged pull request #20665: [#19911]-Added unit test for JDBCRepositoryProviderFactory

Posted by GitBox <gi...@apache.org>.
terrymanu merged PR #20665:
URL: https://github.com/apache/shardingsphere/pull/20665


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] abhinav-koppula commented on pull request #20665: [#19911]-Added unit test for JDBCRepositoryProviderFactory

Posted by GitBox <gi...@apache.org>.
abhinav-koppula commented on PR #20665:
URL: https://github.com/apache/shardingsphere/pull/20665#issuecomment-1236294661

   @agentart - Is it possible for you to review this PR? Asking you since you recently reviewed the JDBCRepositoryTest PR and this is also related.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] codecov-commenter commented on pull request #20665: [#19911]-Added unit test for JDBCRepositoryProviderFactory

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #20665:
URL: https://github.com/apache/shardingsphere/pull/20665#issuecomment-1232454384

   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/20665?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#20665](https://codecov.io/gh/apache/shardingsphere/pull/20665?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (702935a) into [master](https://codecov.io/gh/apache/shardingsphere/commit/7e555d6d4f93b479b7b23404676117e9663fc86e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7e555d6) will **increase** coverage by `0.00%`.
   > The diff coverage is `54.76%`.
   
   ```diff
   @@            Coverage Diff            @@
   ##             master   #20665   +/-   ##
   =========================================
     Coverage     61.05%   61.06%           
   - Complexity     2413     2414    +1     
   =========================================
     Files          3954     3959    +5     
     Lines         54882    54897   +15     
     Branches       9314     9313    -1     
   =========================================
   + Hits          33510    33521   +11     
     Misses        18525    18525           
   - Partials       2847     2851    +4     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/20665?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...gsphere/dialect/exception/SQLDialectException.java](https://codecov.io/gh/apache/shardingsphere/pull/20665/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZGlhbGVjdC1leGNlcHRpb24vc2hhcmRpbmdzcGhlcmUtZGlhbGVjdC1leGNlcHRpb24tY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGlhbGVjdC9leGNlcHRpb24vU1FMRGlhbGVjdEV4Y2VwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...on/InvalidAuthorizationSpecificationException.java](https://codecov.io/gh/apache/shardingsphere/pull/20665/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZGlhbGVjdC1leGNlcHRpb24vc2hhcmRpbmdzcGhlcmUtcG9zdGdyZXNxbC1kaWFsZWN0LWV4Y2VwdGlvbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGlhbGVjdC9wb3N0Z3Jlc3FsL2V4Y2VwdGlvbi9JbnZhbGlkQXV0aG9yaXphdGlvblNwZWNpZmljYXRpb25FeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...xception/PostgreSQLProtocolViolationException.java](https://codecov.io/gh/apache/shardingsphere/pull/20665/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZGlhbGVjdC1leGNlcHRpb24vc2hhcmRpbmdzcGhlcmUtcG9zdGdyZXNxbC1kaWFsZWN0LWV4Y2VwdGlvbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGlhbGVjdC9wb3N0Z3Jlc3FsL2V4Y2VwdGlvbi9Qb3N0Z3JlU1FMUHJvdG9jb2xWaW9sYXRpb25FeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...actReadwriteSplittingRuleConfigurationChecker.java](https://codecov.io/gh/apache/shardingsphere/pull/20665/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtcmVhZHdyaXRlLXNwbGl0dGluZy9zaGFyZGluZ3NwaGVyZS1yZWFkd3JpdGUtc3BsaXR0aW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3JlYWR3cml0ZXNwbGl0dGluZy9jaGVja2VyL0Fic3RyYWN0UmVhZHdyaXRlU3BsaXR0aW5nUnVsZUNvbmZpZ3VyYXRpb25DaGVja2VyLmphdmE=) | `58.92% <0.00%> (ø)` | |
   | [...handler/query/ShowMigrationListQueryResultSet.java](https://codecov.io/gh/apache/shardingsphere/pull/20665/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctZGlzdHNxbC9zaGFyZGluZ3NwaGVyZS1zaGFyZGluZy1kaXN0c3FsLWhhbmRsZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL21pZ3JhdGlvbi9kaXN0c3FsL2hhbmRsZXIvcXVlcnkvU2hvd01pZ3JhdGlvbkxpc3RRdWVyeVJlc3VsdFNldC5qYXZh) | `0.00% <ø> (ø)` | |
   | [...uery/impl/driver/jdbc/type/util/ResultSetUtil.java](https://codecov.io/gh/apache/shardingsphere/pull/20665/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtZXhlY3V0b3Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2luZnJhL2V4ZWN1dG9yL3NxbC9leGVjdXRlL3Jlc3VsdC9xdWVyeS9pbXBsL2RyaXZlci9qZGJjL3R5cGUvdXRpbC9SZXN1bHRTZXRVdGlsLmphdmE=) | `79.38% <0.00%> (-1.68%)` | :arrow_down: |
   | [...r/jdbc/core/resultset/ShardingSphereResultSet.java](https://codecov.io/gh/apache/shardingsphere/pull/20665/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtamRiYy9zaGFyZGluZ3NwaGVyZS1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RyaXZlci9qZGJjL2NvcmUvcmVzdWx0c2V0L1NoYXJkaW5nU3BoZXJlUmVzdWx0U2V0LmphdmE=) | `90.62% <0.00%> (ø)` | |
   | [...tsql/handler/query/TrafficRulesQueryResultSet.java](https://codecov.io/gh/apache/shardingsphere/pull/20665/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLXRyYWZmaWMvc2hhcmRpbmdzcGhlcmUtdHJhZmZpYy1kaXN0c3FsL3NoYXJkaW5nc3BoZXJlLXRyYWZmaWMtZGlzdHNxbC1oYW5kbGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS90cmFmZmljL2Rpc3RzcWwvaGFuZGxlci9xdWVyeS9UcmFmZmljUnVsZXNRdWVyeVJlc3VsdFNldC5qYXZh) | `66.66% <ø> (ø)` | |
   | [.../standalone/lock/ShardingSphereStandaloneLock.java](https://codecov.io/gh/apache/shardingsphere/pull/20665/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtbW9kZS9zaGFyZGluZ3NwaGVyZS1tb2RlLXR5cGUvc2hhcmRpbmdzcGhlcmUtc3RhbmRhbG9uZS1tb2RlL3NoYXJkaW5nc3BoZXJlLXN0YW5kYWxvbmUtbW9kZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9tb2RlL21hbmFnZXIvc3RhbmRhbG9uZS9sb2NrL1NoYXJkaW5nU3BoZXJlU3RhbmRhbG9uZUxvY2suamF2YQ==) | `14.28% <0.00%> (ø)` | |
   | [...nager/standalone/lock/StandaloneExclusiveLock.java](https://codecov.io/gh/apache/shardingsphere/pull/20665/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtbW9kZS9zaGFyZGluZ3NwaGVyZS1tb2RlLXR5cGUvc2hhcmRpbmdzcGhlcmUtc3RhbmRhbG9uZS1tb2RlL3NoYXJkaW5nc3BoZXJlLXN0YW5kYWxvbmUtbW9kZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9tb2RlL21hbmFnZXIvc3RhbmRhbG9uZS9sb2NrL1N0YW5kYWxvbmVFeGNsdXNpdmVMb2NrLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | ... and [27 more](https://codecov.io/gh/apache/shardingsphere/pull/20665/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org