You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@httpd.apache.org by Ruediger Pluem <rp...@apache.org> on 2016/08/17 14:29:10 UTC

Re: svn commit: r1756187 - /httpd/httpd/trunk/modules/proxy/mod_proxy_fcgi.c


On 08/12/2016 04:04 PM, ylavic@apache.org wrote:
> Author: ylavic
> Date: Fri Aug 12 14:04:51 2016
> New Revision: 1756187
> 
> URL: http://svn.apache.org/viewvc?rev=1756187&view=rev
> Log:
> mod_proxy_fcgi: forcing proxy_conn->close here is useless, same is done
> either above in ap_proxy_determine_connection(), or below in
> ap_proxy_release_connection().
> 

I don't think so. The default is disablereuse=off and the code you removed makes the
default disablereuse=on

Regards

R�diger

Re: svn commit: r1756187 - /httpd/httpd/trunk/modules/proxy/mod_proxy_fcgi.c

Posted by Yann Ylavic <yl...@gmail.com>.

On Wed, Aug 17, 2016 at 4:29 PM, Ruediger Pluem <rp...@apache.org> wrote:
>
>
> On 08/12/2016 04:04 PM, ylavic@apache.org wrote:
>> Author: ylavic
>> Date: Fri Aug 12 14:04:51 2016
>> New Revision: 1756187
>>
>> URL: http://svn.apache.org/viewvc?rev=1756187&view=rev
>> Log:
>> mod_proxy_fcgi: forcing proxy_conn->close here is useless, same is done
>> either above in ap_proxy_determine_connection(), or below in
>> ap_proxy_release_connection().
>>
>
> I don't think so. The default is disablereuse=off and the code you removed makes the
> default disablereuse=on

Indeed, I missed the default...
Reverted in r1757097, thanks!

Regards,
Yann.