[jira] [Commented] (SOLR-13794) Delete solr/core/src/test-files/solr/configsets/_default

["Ishan Chattopadhyaya (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-13794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16938156#comment-16938156 ] 

Ishan Chattopadhyaya commented on SOLR-13794:
---------------------------------------------

+1 to the proposition. I wasn't aware at the time of how I could've used the user facing _default configset in tests, and hence copied it over. I admit I didn't look hard enough. Thanks for tackling this.

> Delete solr/core/src/test-files/solr/configsets/_default
> --------------------------------------------------------
>
>                 Key: SOLR-13794
>                 URL: https://issues.apache.org/jira/browse/SOLR-13794
>             Project: Solr
>          Issue Type: Test
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Chris M. Hostetter
>            Priority: Major
>         Attachments: SOLR-13794.patch, SOLR-13794_code_only.patch
>
>
> For as long as we've had a {{_default}} configset in solr, we've also had a copy of that default in {{core/src/test-files/}} - as well as a unit test that confirms they are identical.
> It's never really been clear to me *why* we have this duplication, instead of just having the test-framework take the necessary steps to ensure that {{server/solr/configsets/_default}} is properly used when running tests.
> I'd like to propose we eliminate the duplication since it only ever seems to cause problems (notably spurious test failures when people modify the {{_default}} configset w/o remembering that they need to make identical edits to the {{test-files}} clone) and instead have {{SolrTestCase}} set the (already existing & supported) {{solr.default.confdir}} system property to point to the (already existing) {{ExternalPaths.DEFAULT_CONFIGSET}}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org