You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/05/23 11:22:30 UTC
[GitHub] [hudi] liujinhui1994 opened a new pull request, #5663: [HUDI-4135] Remove netty and netty-all
liujinhui1994 opened a new pull request, #5663:
URL: https://github.com/apache/hudi/pull/5663
## *Tips*
- *Thank you very much for contributing to Apache Hudi.*
- *Please review https://hudi.apache.org/contribute/how-to-contribute before opening a pull request.*
## What is the purpose of the pull request
*(For example: This pull request adds quick-start document.)*
## Brief change log
*(for example:)*
- *Modify AnnotationLocation checkstyle rule in checkstyle.xml*
## Verify this pull request
*(Please pick either of the following options)*
This pull request is a trivial rework / code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end.*
- *Added HoodieClientWriteTest to verify the change.*
- *Manually verified the change by running a job locally.*
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5663: [HUDI-4135] Remove netty and netty-all
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5663:
URL: https://github.com/apache/hudi/pull/5663#issuecomment-1134833126
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dc6499f6f509b62f6b9b9312a0358a26060c1644",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8860",
"triggerID" : "dc6499f6f509b62f6b9b9312a0358a26060c1644",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* dc6499f6f509b62f6b9b9312a0358a26060c1644 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8860)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] liujinhui1994 commented on pull request #5663: [HUDI-4135] Remove netty and netty-all
Posted by GitBox <gi...@apache.org>.
liujinhui1994 commented on PR #5663:
URL: https://github.com/apache/hudi/pull/5663#issuecomment-1135468386
> @liujinhui1994 the key part of this task is validation. Can we prove that after removing these, spark bundles all work as before?
1. Modify the code to remove dependencies and see if the test passes, currently it is passed
2. Repackage, I will try it on our PRD environment to see if the task runs normally.
At present, the first step is completed, and the second step will be dealt with in my spare time, I think it will not be too late
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5663: [HUDI-4135] Remove netty and netty-all
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5663:
URL: https://github.com/apache/hudi/pull/5663#issuecomment-1134571764
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dc6499f6f509b62f6b9b9312a0358a26060c1644",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8860",
"triggerID" : "dc6499f6f509b62f6b9b9312a0358a26060c1644",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* dc6499f6f509b62f6b9b9312a0358a26060c1644 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8860)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5663: [HUDI-4135] Remove netty and netty-all
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5663:
URL: https://github.com/apache/hudi/pull/5663#issuecomment-1134568601
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dc6499f6f509b62f6b9b9312a0358a26060c1644",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "dc6499f6f509b62f6b9b9312a0358a26060c1644",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* dc6499f6f509b62f6b9b9312a0358a26060c1644 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] xushiyan merged pull request #5663: [HUDI-4135] Remove netty and netty-all
Posted by GitBox <gi...@apache.org>.
xushiyan merged PR #5663:
URL: https://github.com/apache/hudi/pull/5663
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] liujinhui1994 commented on pull request #5663: [HUDI-4135] Remove netty and netty-all
Posted by GitBox <gi...@apache.org>.
liujinhui1994 commented on PR #5663:
URL: https://github.com/apache/hudi/pull/5663#issuecomment-1135592051
@xushiyan I am in spark2.4.5 environment. Use hudi-spark-bundle_2.11-0.12.0-SNAPSHOT.jar. Consume kafka and write hudi successfully and stably
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] liujinhui1994 commented on pull request #5663: [HUDI-4135] Remove netty and netty-all
Posted by GitBox <gi...@apache.org>.
liujinhui1994 commented on PR #5663:
URL: https://github.com/apache/hudi/pull/5663#issuecomment-1135594213
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] xushiyan commented on pull request #5663: [HUDI-4135] Remove netty and netty-all
Posted by GitBox <gi...@apache.org>.
xushiyan commented on PR #5663:
URL: https://github.com/apache/hudi/pull/5663#issuecomment-1135369526
@liujinhui1994 the key part of this task is validation. Can we prove that after removing these, spark bundles all work as before?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org