[GitHub] [incubator-streampark] wolfboys commented on a diff in pull request #2782: [Feature][ISSUE-2780] support set RestoreMode when starting app

["wolfboys (via GitHub)" <gi...@apache.org>]

wolfboys commented on code in PR #2782:
URL: https://github.com/apache/incubator-streampark/pull/2782#discussion_r1211078673


##########
streampark-flink/streampark-flink-client/streampark-flink-client-core/src/main/scala/org/apache/streampark/flink/client/trait/FlinkClientTrait.scala:
##########
@@ -115,6 +115,7 @@ trait FlinkClientTrait extends Logger {
       flinkConfig.setBoolean(
         SavepointConfigOptions.SAVEPOINT_IGNORE_UNCLAIMED_STATE,
         submitRequest.allowNonRestoredState)
+      flinkConfig.setString(RestoreMode.RESTORE_MODE, submitRequest.restoreMode.getName);

Review Comment:
   Here, we should check the version number of Flink and then decide whether this parameter is needed or not.



##########
streampark-console/streampark-console-webapp/src/views/flink/app/components/AppView/StartApplicationModal.vue:
##########
@@ -89,6 +90,26 @@
         ifShow: ({ values }) => values.startSavePointed,
         required: true,
       },
+      {
+        field: 'restoreMode',
+        label: 'restore mode',
+        component: 'Select',
+        defaultValue: RestoreModeEnum.NO_CLAIM,
+        componentProps: {
+          options: [
+            { label: 'CLAIM', value: RestoreModeEnum.CLAIM },
+            { label: 'NO_CLAIM', value: RestoreModeEnum.NO_CLAIM },
+            { label: 'LEGACY', value: RestoreModeEnum.LEGACY },
+          ],
+        },
+        afterItem: () =>

Review Comment:
   Have we checked the version number of Flink here? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org