[GitHub] [airflow] potiuk edited a comment on pull request #17779: Ensure that airflow modules are not imported too early in conftest

[GitBox <gi...@apache.org>]

potiuk edited a comment on pull request #17779:
URL: https://github.com/apache/airflow/pull/17779#issuecomment-903662619


   > This seems to break MySQL’s collation settings for some reason
   
   I thought it could be because it needs to be rebased to latest main. I just merged yesterday a change that removed the need for specifically setting the collation in 5.7, though I still think it **SHOULD** work without rebase, because docker-compose with the parameter + code detecting it in "base.py" were changed together. 
   
   BTW.  I keep on saying it but, no matter the reason I think this one is only a 'band-aid` - we have much bigger problem with our conf/settings. The way how our conf and settings depend on each other in bizzare and baroque ways continues to amaze me and there is always a bit magic involved regarding the sequence in which it should be imported. 
   
   I really think we should finally simplify and use "single responsibility" rule here as now both conf and settings do partially the same and call each-other in cycles. It's really confusing. 
   
   It might however break some compatibility.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org