You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "mapleFU (via GitHub)" <gi...@apache.org> on 2024/06/05 11:18:49 UTC
[PR] MINOR: ParquetFilePrinter::JSONPrint print length of FLBA [arrow]
mapleFU opened a new pull request, #41981:
URL: https://github.com/apache/arrow/pull/41981
<!--
Thanks for opening a pull request!
If this is your first pull request you can find detailed information on how
to contribute here:
* [New Contributor's Guide](https://arrow.apache.org/docs/dev/developers/guide/step_by_step/pr_lifecycle.html#reviews-and-merge-of-the-pull-request)
* [Contributing Overview](https://arrow.apache.org/docs/dev/developers/overview.html)
If this is not a [minor PR](https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose
Opening GitHub issues ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
Then could you also rename the pull request title in the following format?
GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
In the case of PARQUET issues on JIRA the title also supports:
PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
-->
### Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
Print FLBA length in `ParquetFilePrinter::JSONPrint`
### What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
Print FLBA length in `ParquetFilePrinter::JSONPrint`
### Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
no need
### Are there any user-facing changes?
no
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please uncomment the line below and explain which changes are breaking.
-->
<!-- **This PR includes breaking changes to public APIs.** -->
<!--
Please uncomment the line below (and provide explanation) if the changes fix either (a) a security vulnerability, (b) a bug that caused incorrect or invalid data to be produced, or (c) a bug that causes a crash (even when the API contract is upheld). We use this to highlight fixes to issues that may affect users without their knowledge. For this reason, fixing bugs that cause errors don't count, since those are usually obvious.
-->
<!-- **This PR contains a "Critical Fix".** -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-42100: [C++][Parquet] ParquetFilePrinter::JSONPrint print length of FLBA [arrow]
Posted by "mapleFU (via GitHub)" <gi...@apache.org>.
mapleFU commented on PR #41981:
URL: https://github.com/apache/arrow/pull/41981#issuecomment-2160993967
@pitrou I just add a case for FLBA, and print the whole FLBA min-max would be weird
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-42100: [C++][Parquet] ParquetFilePrinter::JSONPrint print length of FLBA [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #41981:
URL: https://github.com/apache/arrow/pull/41981#issuecomment-2160439392
:warning: GitHub issue #42100 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-42100: [C++][Parquet] ParquetFilePrinter::JSONPrint print length of FLBA [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on code in PR #41981:
URL: https://github.com/apache/arrow/pull/41981#discussion_r1635146307
##########
cpp/src/parquet/reader_test.cc:
##########
@@ -1077,7 +1077,24 @@ Column 1
ASSERT_EQ(header_output + dump_output, ss_dump.str());
}
-TEST(TestJSONWithLocalFile, JSONOutput) {
+class TestJSONWithLocalFile : public ::testing::Test {
+ public:
+ static std::string readFromLocalFile(std::string_view localFileName) {
Review Comment:
Nit: coding style
```suggestion
static std::string ReadFromLocalFile(std::string_view file_path) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: [C++][Parquet] ParquetFilePrinter::JSONPrint print length of FLBA [arrow]
Posted by "mapleFU (via GitHub)" <gi...@apache.org>.
mapleFU commented on PR #41981:
URL: https://github.com/apache/arrow/pull/41981#issuecomment-2149972106
Emmm I use this as debug tool and I found it doesn't contains FLBA length, it's just debug tool, so I think adding test for this would make `Printer` weird to maintain...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: [C++][Parquet] ParquetFilePrinter::JSONPrint print length of FLBA [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #41981:
URL: https://github.com/apache/arrow/pull/41981#issuecomment-2149920064
Also, do we want to add basic tests for ParquetFilePrinter at some point?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-42100: [C++][Parquet] ParquetFilePrinter::JSONPrint print length of FLBA [arrow]
Posted by "mapleFU (via GitHub)" <gi...@apache.org>.
mapleFU merged PR #41981:
URL: https://github.com/apache/arrow/pull/41981
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: [C++][Parquet] ParquetFilePrinter::JSONPrint print length of FLBA [arrow]
Posted by "mapleFU (via GitHub)" <gi...@apache.org>.
mapleFU commented on PR #41981:
URL: https://github.com/apache/arrow/pull/41981#issuecomment-2149576965
cc @pitrou @wgtmac
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: [C++][Parquet] ParquetFilePrinter::JSONPrint print length of FLBA [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #41981:
URL: https://github.com/apache/arrow/pull/41981#issuecomment-2149918354
I'm not sure this is minor, do you want to open an issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-42100: [C++][Parquet] ParquetFilePrinter::JSONPrint print length of FLBA [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #41981:
URL: https://github.com/apache/arrow/pull/41981#issuecomment-2160549532
@mapleFU We can fix that in another PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-42100: [C++][Parquet] ParquetFilePrinter::JSONPrint print length of FLBA [arrow]
Posted by "mapleFU (via GitHub)" <gi...@apache.org>.
mapleFU commented on code in PR #41981:
URL: https://github.com/apache/arrow/pull/41981#discussion_r1635182603
##########
cpp/src/parquet/reader_test.cc:
##########
@@ -1077,7 +1077,24 @@ Column 1
ASSERT_EQ(header_output + dump_output, ss_dump.str());
}
-TEST(TestJSONWithLocalFile, JSONOutput) {
+class TestJSONWithLocalFile : public ::testing::Test {
+ public:
+ static std::string readFromLocalFile(std::string_view localFileName) {
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: [C++][Parquet] ParquetFilePrinter::JSONPrint print length of FLBA [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #41981:
URL: https://github.com/apache/arrow/pull/41981#issuecomment-2149983528
Well, wouldn't it be useful to check that the debugging tool doesn't regress?
I'm not insisting on tests, just to note that the "not needed" in your PR description seems a bit cavalier.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-42100: [C++][Parquet] ParquetFilePrinter::JSONPrint print length of FLBA [arrow]
Posted by "mapleFU (via GitHub)" <gi...@apache.org>.
mapleFU commented on PR #41981:
URL: https://github.com/apache/arrow/pull/41981#issuecomment-2161235755
https://github.com/apache/arrow/issues/42104 Create issue here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-42100: [C++][Parquet] ParquetFilePrinter::JSONPrint print length of FLBA [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #41981:
URL: https://github.com/apache/arrow/pull/41981#issuecomment-2163506772
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 65974672a356f34889ed7b9bfb8b76230c27c7ee.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/26141405690) has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-42100: [C++][Parquet] ParquetFilePrinter::JSONPrint print length of FLBA [arrow]
Posted by "mapleFU (via GitHub)" <gi...@apache.org>.
mapleFU commented on PR #41981:
URL: https://github.com/apache/arrow/pull/41981#issuecomment-2160462992
I came cross a problem:
```
"ColumnChunks": [
{"Id": "0", "Values": "1000", "StatsSet": "True", "Stats": {"NumNulls": "105", "Max": "