You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/02/28 17:55:52 UTC
[GitHub] [spark] MaxGekk opened a new pull request #27741:
[SPARK-30988][SQL][TESTS] Add more edge-case exercising values to stats tests
MaxGekk opened a new pull request #27741: [SPARK-30988][SQL][TESTS] Add more edge-case exercising values to stats tests
URL: https://github.com/apache/spark/pull/27741
### What changes were proposed in this pull request?
Added more test cases to `StatisticsCollectionTestBase`.
### Why are the changes needed?
To improve test coverage.
### Does this PR introduce any user-facing change?
No
### How was this patch tested?
By `StatisticsSuite` and `StatisticsCollectionTestBase`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27741:
[SPARK-30988][SQL][TESTS] Add more edge-case exercising values to stats tests
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27741: [SPARK-30988][SQL][TESTS] Add more edge-case exercising values to stats tests
URL: https://github.com/apache/spark/pull/27741#issuecomment-592653438
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27741:
[SPARK-30988][SQL][TESTS] Add more edge-case exercising values to stats tests
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27741: [SPARK-30988][SQL][TESTS] Add more edge-case exercising values to stats tests
URL: https://github.com/apache/spark/pull/27741#issuecomment-592652758
**[Test build #119098 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119098/testReport)** for PR 27741 at commit [`5ae140c`](https://github.com/apache/spark/commit/5ae140ce50142467cd3318b4253bb8830f180744).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27741:
[SPARK-30988][SQL][TESTS] Add more edge-case exercising values to stats tests
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27741: [SPARK-30988][SQL][TESTS] Add more edge-case exercising values to stats tests
URL: https://github.com/apache/spark/pull/27741#issuecomment-592756757
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119098/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27741:
[SPARK-30988][SQL][TESTS] Add more edge-case exercising values to stats tests
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27741: [SPARK-30988][SQL][TESTS] Add more edge-case exercising values to stats tests
URL: https://github.com/apache/spark/pull/27741#issuecomment-592755899
**[Test build #119098 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119098/testReport)** for PR 27741 at commit [`5ae140c`](https://github.com/apache/spark/commit/5ae140ce50142467cd3318b4253bb8830f180744).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27741:
[SPARK-30988][SQL][TESTS] Add more edge-case exercising values to stats tests
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27741: [SPARK-30988][SQL][TESTS] Add more edge-case exercising values to stats tests
URL: https://github.com/apache/spark/pull/27741#issuecomment-592653448
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23842/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27741:
[SPARK-30988][SQL][TESTS] Add more edge-case exercising values to stats tests
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27741: [SPARK-30988][SQL][TESTS] Add more edge-case exercising values to stats tests
URL: https://github.com/apache/spark/pull/27741#issuecomment-592653448
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23842/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27741:
[SPARK-30988][SQL][TESTS] Add more edge-case exercising values to stats tests
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27741: [SPARK-30988][SQL][TESTS] Add more edge-case exercising values to stats tests
URL: https://github.com/apache/spark/pull/27741#issuecomment-592756757
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119098/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on issue #27741:
[SPARK-30988][SQL][TESTS] Add more edge-case exercising values to stats tests
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on issue #27741: [SPARK-30988][SQL][TESTS] Add more edge-case exercising values to stats tests
URL: https://github.com/apache/spark/pull/27741#issuecomment-593180169
Merged to master and branch-3.0.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on issue #27741:
[SPARK-30988][SQL][TESTS] Add more edge-case exercising values to stats tests
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on issue #27741: [SPARK-30988][SQL][TESTS] Add more edge-case exercising values to stats tests
URL: https://github.com/apache/spark/pull/27741#issuecomment-592650526
Thanks to @jose-torres for the provided tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on issue #27741:
[SPARK-30988][SQL][TESTS] Add more edge-case exercising values to stats tests
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on issue #27741: [SPARK-30988][SQL][TESTS] Add more edge-case exercising values to stats tests
URL: https://github.com/apache/spark/pull/27741#issuecomment-593180384
There's conflict against branch-3.0. I think it's fine to don't backport either.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27741:
[SPARK-30988][SQL][TESTS] Add more edge-case exercising values to stats tests
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27741: [SPARK-30988][SQL][TESTS] Add more edge-case exercising values to stats tests
URL: https://github.com/apache/spark/pull/27741#issuecomment-592653438
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27741:
[SPARK-30988][SQL][TESTS] Add more edge-case exercising values to stats tests
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27741: [SPARK-30988][SQL][TESTS] Add more edge-case exercising values to stats tests
URL: https://github.com/apache/spark/pull/27741#issuecomment-592652758
**[Test build #119098 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119098/testReport)** for PR 27741 at commit [`5ae140c`](https://github.com/apache/spark/commit/5ae140ce50142467cd3318b4253bb8830f180744).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27741:
[SPARK-30988][SQL][TESTS] Add more edge-case exercising values to stats tests
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27741: [SPARK-30988][SQL][TESTS] Add more edge-case exercising values to stats tests
URL: https://github.com/apache/spark/pull/27741#issuecomment-592756750
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #27741:
[SPARK-30988][SQL][TESTS] Add more edge-case exercising values to stats tests
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #27741: [SPARK-30988][SQL][TESTS] Add more edge-case exercising values to stats tests
URL: https://github.com/apache/spark/pull/27741
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon edited a comment on issue #27741:
[SPARK-30988][SQL][TESTS] Add more edge-case exercising values to stats tests
Posted by GitBox <gi...@apache.org>.
HyukjinKwon edited a comment on issue #27741: [SPARK-30988][SQL][TESTS] Add more edge-case exercising values to stats tests
URL: https://github.com/apache/spark/pull/27741#issuecomment-593180169
Merged to master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27741:
[SPARK-30988][SQL][TESTS] Add more edge-case exercising values to stats tests
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27741: [SPARK-30988][SQL][TESTS] Add more edge-case exercising values to stats tests
URL: https://github.com/apache/spark/pull/27741#issuecomment-592756750
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org