You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by vladimir-kotikov <gi...@git.apache.org> on 2016/07/08 13:11:12 UTC
[GitHub] cordova-windows pull request #184: CB-11516 windows: Preparing icons w/ targ...
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-windows/pull/184
CB-11516 windows: Preparing icons w/ target fails
This closes #179
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vladimir-kotikov/cordova-windows CB-11548
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-windows/pull/184.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #184
----
commit f6f7f89a5be4a2efac0fa19538f474095f020f1e
Author: Cody Hoover <gi...@codyhoover.com>
Date: 2016-06-30T07:30:03Z
CB-11516 windows: Preparing icons w/ target fails
This closes #179
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows issue #184: CB-11516 windows: Preparing icons w/ target fail...
Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:
https://github.com/apache/cordova-windows/pull/184
## [Current coverage][cc-pull] is **72.50%**
> Merging [#184][cc-pull] into [master][cc-base-branch] will increase coverage by **0.32%**
```diff
@@ master #184 diff @@
==========================================
Files 14 14
Lines 1905 1920 +15
Methods 351 356 +5
Messages 0 0
Branches 385 386 +1
==========================================
+ Hits 1375 1392 +17
+ Misses 530 528 -2
Partials 0 0
```
> Powered by [Codecov](https://codecov.io?src=pr). Last updated by [b0502ae...f6f7f89][cc-compare]
[cc-base-branch]: https://codecov.io/gh/apache/cordova-windows/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/apache/cordova-windows/compare/b0502ae450c61e8bcb99969a174d062ef751f081...f6f7f89a5be4a2efac0fa19538f474095f020f1e?src=pr
[cc-pull]: https://codecov.io/gh/apache/cordova-windows/pull/184?src=pr
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows issue #184: CB-11548 windows: Respect user-specified msbuild...
Posted by vladimir-kotikov <gi...@git.apache.org>.
Github user vladimir-kotikov commented on the issue:
https://github.com/apache/cordova-windows/pull/184
@sgrebnov, please take a look
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows issue #184: CB-11548 windows: Respect user-specified msbuild...
Posted by sgrebnov <gi...@git.apache.org>.
Github user sgrebnov commented on the issue:
https://github.com/apache/cordova-windows/pull/184
Reviewed, LGTM :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows pull request #184: CB-11548 windows: Respect user-specified ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-windows/pull/184
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org