You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2022/04/22 00:10:24 UTC

[GitHub] [calcite] libenchao commented on a diff in pull request #2773: [CALCITE-5095] Support Java 18 and Guava 31.1-jre

libenchao commented on code in PR #2773:
URL: https://github.com/apache/calcite/pull/2773#discussion_r855676810


##########
core/src/main/java/org/apache/calcite/config/CalciteSystemProperty.java:
##########
@@ -429,7 +430,8 @@ private static Properties loadProperties() {
         Thread.currentThread().getContextClassLoader(),
         CalciteSystemProperty.class.getClassLoader());
     // Read properties from the file "saffron.properties", if it exists in classpath
-    try (InputStream stream = classLoader.getResourceAsStream("saffron.properties")) {

Review Comment:
   Thanks for the review @NobiGo, these changes is because we upgraded guava version, which checks nullability more strictly, many apis added nullability annotation.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org