You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/01/09 12:59:43 UTC

[GitHub] tkaymak commented on issue #4466: [AIRFLOW-3657] Specify zdesk package version in setup.py

tkaymak commented on issue #4466: [AIRFLOW-3657] Specify zdesk package version in setup.py
URL: https://github.com/apache/airflow/pull/4466#issuecomment-452687930
 
 
   @ron819 Compare this line:
   https://github.com/fprimex/zdesk/blob/2.6.0/zdesk/zdesk.py#L91
   
   to this line:
   https://github.com/fprimex/zdesk/blob/2.7.0/zdesk/zdesk.py#L91
   
   You can see that the signature of the __init__ changed, now the 3rd argument is no longer the boolean for saying that you are identifying with a token (`zdesk_token`, which is set to True by default by the hook here in this line: 
   https://github.com/apache/airflow/blob/master/airflow/hooks/zendesk_hook.py#L36
   
   This breaks the authentication.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services