You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/06/07 16:21:01 UTC
[GitHub] [ozone] adoroszlai opened a new pull request #2308: HDDS-5312. Intermittent failure in SCM Ratis integration test
adoroszlai opened a new pull request #2308:
URL: https://github.com/apache/ozone/pull/2308
## What changes were proposed in this pull request?
1. Mini cluster in SCM HA tests waits for two events sequentially:
- SCM leader election
- datanode registration, pipeline creation
The same 2 minutes timeout applies to both of these separately.
This change makes single SCM _with Ratis enabled_ also wait for leader election, to allow for time spent to start up Ratis. Most timeouts are observed in tests with such setup (single SCM with Ratis).
2. Increase frequency of pipeline creation attempts for some integration tests.
3. Fix `BackgroundPipelineCreatorV2#stop()`: the thread was always considered "not running" due to wrong condition for return value of `compareAndSet` (returns `true` if update is successful).
4. Guard `oneShotRun` value assignment in `notifyEventTriggered` by `serviceLock`, similar to other access in `shouldRun`.
https://issues.apache.org/jira/browse/HDDS-5312
## How was this patch tested?
Regular CI:
https://github.com/adoroszlai/hadoop-ozone/actions/runs/914869219
20x repetitions of affected tests:
https://github.com/adoroszlai/hadoop-ozone/runs/2764193856
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on pull request #2308: HDDS-5312. Intermittent failure in SCM Ratis integration test
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on pull request #2308:
URL: https://github.com/apache/ozone/pull/2308#issuecomment-857795872
Thanks @GlenGeng and @elek for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai merged pull request #2308: HDDS-5312. Intermittent failure in SCM Ratis integration test
Posted by GitBox <gi...@apache.org>.
adoroszlai merged pull request #2308:
URL: https://github.com/apache/ozone/pull/2308
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] GlenGeng commented on a change in pull request #2308: HDDS-5312. Intermittent failure in SCM Ratis integration test
Posted by GitBox <gi...@apache.org>.
GlenGeng commented on a change in pull request #2308:
URL: https://github.com/apache/ozone/pull/2308#discussion_r647935709
##########
File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/pipeline/BackgroundPipelineCreatorV2.java
##########
@@ -150,7 +150,7 @@ public void start() {
* Stop RatisPipelineUtilsThread.
*/
public void stop() {
- if (running.compareAndSet(true, false)) {
+ if (!running.compareAndSet(true, false)) {
Review comment:
Thanks @adoroszlai for find out this bug !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org