You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "Aias00 (via GitHub)" <gi...@apache.org> on 2026/10/20 05:11:02 UTC
[PR] fix(alerts): isolate bulk rule item transactions [rocketmq-dashboard]
Aias00 opened a new pull request, #7221:
URL: https://github.com/apache/rocketmq-dashboard/pull/7221
When state cleanup throws after a bulk rule update/delete, AlertService catches the error inside the batch transaction and reports failure while the rule mutation can still commit.
Run each item’s rule mutation, state cleanup and audit call in a separate `REQUIRES_NEW` transaction. Catch failures after rollback and add successes only after commit, preserving the existing best-effort bulk result across all four scoped/unscoped overloads.
Fixes #7220
Validation:
- Added real H2/database regression tests with failure injected after state deletion, covering scoped/unscoped bulk disable/delete. All four failed on the original code (failed rules were disabled or deleted) and pass with the fix.
- Full alert package: **466 tests, 0 failures, 0 errors, 0 skipped**, with the dev profile; bound Checkstyle passed.
- `git diff --check` passed.
Tested with JDK 21 and H2; no live MySQL/Broker or full repository suite was run.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(alerts): isolate bulk rule item transactions [rocketmq-dashboard]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins merged PR #7221:
URL: https://github.com/apache/rocketmq-dashboard/pull/7221
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org