You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@logging.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2020/02/08 22:32:00 UTC

[jira] [Work logged] (LOG4J2-2768) LogBuilder multi-parameter overloads

     [ https://issues.apache.org/jira/browse/LOG4J2-2768?focusedWorklogId=384011&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-384011 ]

ASF GitHub Bot logged work on LOG4J2-2768:
------------------------------------------

                Author: ASF GitHub Bot
            Created on: 08/Feb/20 22:31
            Start Date: 08/Feb/20 22:31
    Worklog Time Spent: 10m 
      Work Description: rgoers commented on pull request #336: LOG4J2-2768 Add log(String, ...) overloads to LogBuilder
URL: https://github.com/apache/logging-log4j2/pull/336
 
 
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 384011)
    Time Spent: 20m  (was: 10m)

> LogBuilder multi-parameter overloads
> ------------------------------------
>
>                 Key: LOG4J2-2768
>                 URL: https://issues.apache.org/jira/browse/LOG4J2-2768
>             Project: Log4j 2
>          Issue Type: Improvement
>          Components: API
>    Affects Versions: 2.13.0
>            Reporter: Marius Volkhart
>            Assignee: Ralph Goers
>            Priority: Minor
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> The new {{LogBuilder}} interface provides a single {{log(String format, Object... params)}} method for creating formatted messages from a {{String}}. The {{Logger}} methods {{info}}, {{debug}}, etc all had overloads like {{debug(String format, Object p0)}}, {{debug(String format, Object p0, Object p1)}}, etc. This avoided allocating an {{Object[]}} before knowing whether or not the message is going to be logged.
> Were these overloads intentionally omitted from the {{LogBuilder}} API? Is there a new/better way to avoid the {{Object[]}} allocation, or do newer JVMs perhaps not require this anymore? 
> If not, I'd like to request the overloads be added to the {{LogBuilder}} API, and would be happy to submit a PR to do so.
> Google's Flogger has a write up that covers this topic in a bit more detail: https://google.github.io/flogger/anatomy



--
This message was sent by Atlassian Jira
(v8.3.4#803005)