Re: [PR] UI: Fix OS Type displayed for a VM [cloudstack]

["fmaximus (via GitHub)" <gi...@apache.org>]

fmaximus commented on code in PR #11075:
URL: https://github.com/apache/cloudstack/pull/11075#discussion_r2176631304


##########
ui/src/components/view/InfoCard.vue:
##########
@@ -35,7 +35,7 @@
                       <resource-icon :image="resourceIcon" size="4x" style="margin-right: 5px"/>
                     </span>
                     <span v-else>
-                      <os-logo v-if="resource.ostypeid || resource.ostypename || ['guestoscategory'].includes($route.path.split('/')[1])" :osId="resource.ostypeid" :osName="resource.ostypename || resource.name" size="3x" @update-osname="setResourceOsType"/>
+                      <os-logo v-if="resource.ostypeid || resource.ostypename || ['guestoscategory'].includes($route.path.split('/')[1])" :osId="resource.ostypeid" :osName="resource.ostypename || resource.osdisplayname || resource.name" size="3x" />

Review Comment:
   The core issue is passing resource.name to osName,
   while os-logo only does lookup by osId when osName is empty.
   
   Removal of the @update-osname also makes it incorrect,
   as it's now showing OS instead of OS type, e.g. CentOS 9 instead of CentOS.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org