You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "iht (via GitHub)" <gi...@apache.org> on 2023/02/13 16:48:00 UTC
[GitHub] [beam] iht opened a new pull request, #25448: Make `withDesiredBundleSizeBytes` methods public
iht opened a new pull request, #25448:
URL: https://github.com/apache/beam/pull/25448
With these methods being private, the bundle size is 64 MB, which is too large for streaming applications using these classes.
This changes the method visibility to public so a smaller bundle size can be used for streaming.
Fixes #25447
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #25448: Make `withDesiredBundleSizeBytes` methods public
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #25448:
URL: https://github.com/apache/beam/pull/25448#issuecomment-1498965800
Reminder, please take a look at this pr: @robertwb
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #25448: Make `withDesiredBundleSizeBytes` methods public
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #25448:
URL: https://github.com/apache/beam/pull/25448#issuecomment-1488491170
Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @robertwb for label java.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aromanenko-dev commented on pull request #25448: Make `withDesiredBundleSizeBytes` methods public
Posted by "aromanenko-dev (via GitHub)" <gi...@apache.org>.
aromanenko-dev commented on PR #25448:
URL: https://github.com/apache/beam/pull/25448#issuecomment-1516160481
The failed tests in Java PreCommit are not related to this change. Merging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #25448: Make `withDesiredBundleSizeBytes` methods public
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #25448:
URL: https://github.com/apache/beam/pull/25448#issuecomment-1474993869
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @lukecwik for label java.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aromanenko-dev commented on pull request #25448: Make `withDesiredBundleSizeBytes` methods public
Posted by "aromanenko-dev (via GitHub)" <gi...@apache.org>.
aromanenko-dev commented on PR #25448:
URL: https://github.com/apache/beam/pull/25448#issuecomment-1466363793
@iht Kind ping on this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aromanenko-dev commented on pull request #25448: Make `withDesiredBundleSizeBytes` methods public
Posted by "aromanenko-dev (via GitHub)" <gi...@apache.org>.
aromanenko-dev commented on PR #25448:
URL: https://github.com/apache/beam/pull/25448#issuecomment-1514988231
retest this please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aromanenko-dev commented on pull request #25448: Make `withDesiredBundleSizeBytes` methods public
Posted by "aromanenko-dev (via GitHub)" <gi...@apache.org>.
aromanenko-dev commented on PR #25448:
URL: https://github.com/apache/beam/pull/25448#issuecomment-1515966743
Run Java PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #25448: Make `withDesiredBundleSizeBytes` methods public
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #25448:
URL: https://github.com/apache/beam/pull/25448#issuecomment-1503221172
Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @Abacn for label java.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] iht commented on a diff in pull request #25448: Make `withDesiredBundleSizeBytes` methods public
Posted by "iht (via GitHub)" <gi...@apache.org>.
iht commented on code in PR #25448:
URL: https://github.com/apache/beam/pull/25448#discussion_r1141150202
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/io/AvroIO.java:
##########
@@ -806,9 +806,8 @@ abstract Builder<T> setFileExceptionHandler(
abstract ReadFiles<T> build();
}
-
- @VisibleForTesting
- ReadFiles<T> withDesiredBundleSizeBytes(long desiredBundleSizeBytes) {
+
Review Comment:
I have added Javadoc strings to all the methods that are now public.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] iht commented on pull request #25448: Make `withDesiredBundleSizeBytes` methods public
Posted by "iht (via GitHub)" <gi...@apache.org>.
iht commented on PR #25448:
URL: https://github.com/apache/beam/pull/25448#issuecomment-1474984641
I have changed these methods in the previous package location (now deprecated), and in the new package location (`org.apache.beam.sdk.extensions.avro.io`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] iht commented on pull request #25448: Make `withDesiredBundleSizeBytes` methods public
Posted by "iht (via GitHub)" <gi...@apache.org>.
iht commented on PR #25448:
URL: https://github.com/apache/beam/pull/25448#issuecomment-1466562549
> @iht Kind ping on this.
ack, will be sending an update soon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] iht commented on a diff in pull request #25448: Make `withDesiredBundleSizeBytes` methods public
Posted by "iht (via GitHub)" <gi...@apache.org>.
iht commented on code in PR #25448:
URL: https://github.com/apache/beam/pull/25448#discussion_r1134338947
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/io/AvroIO.java:
##########
@@ -806,9 +806,8 @@ abstract Builder<T> setFileExceptionHandler(
abstract ReadFiles<T> build();
}
-
- @VisibleForTesting
- ReadFiles<T> withDesiredBundleSizeBytes(long desiredBundleSizeBytes) {
+
Review Comment:
I will be adding this asap, thanks for the tip!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #25448: Make `withDesiredBundleSizeBytes` methods public
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #25448:
URL: https://github.com/apache/beam/pull/25448#issuecomment-1512991942
Reminder, please take a look at this pr: @Abacn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aromanenko-dev merged pull request #25448: Make `withDesiredBundleSizeBytes` methods public
Posted by "aromanenko-dev (via GitHub)" <gi...@apache.org>.
aromanenko-dev merged PR #25448:
URL: https://github.com/apache/beam/pull/25448
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on a diff in pull request #25448: Make `withDesiredBundleSizeBytes` methods public
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on code in PR #25448:
URL: https://github.com/apache/beam/pull/25448#discussion_r1105030806
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/io/AvroIO.java:
##########
@@ -806,9 +806,8 @@ abstract Builder<T> setFileExceptionHandler(
abstract ReadFiles<T> build();
}
-
- @VisibleForTesting
- ReadFiles<T> withDesiredBundleSizeBytes(long desiredBundleSizeBytes) {
+
Review Comment:
Thanks, seems it is now exposed to user, would you mind adding a brief javadoc? e.g. information in your PR description addressing when this may be useful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #25448: Make `withDesiredBundleSizeBytes` methods public
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #25448:
URL: https://github.com/apache/beam/pull/25448#issuecomment-1435239058
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment `assign set of reviewers`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #25448: Make `withDesiredBundleSizeBytes` methods public
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #25448:
URL: https://github.com/apache/beam/pull/25448#issuecomment-1484078477
Reminder, please take a look at this pr: @lukecwik
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org