You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Vincent Siveton (JIRA)" <ji...@codehaus.org> on 2008/09/04 01:36:49 UTC
[jira] Closed: (SCM-246) p4 command reports most or all errors on
stderr but maven-scm-provider-perforce throws away stderr
[ http://jira.codehaus.org/browse/SCM-246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vincent Siveton closed SCM-246.
-------------------------------
Assignee: Vincent Siveton
Resolution: Fixed
Fixed in [r691823|http://svn.apache.org/viewvc?rev=691823&view=rev]
Since I am not a Perforce user, please test it.
> p4 command reports most or all errors on stderr but maven-scm-provider-perforce throws away stderr
> --------------------------------------------------------------------------------------------------
>
> Key: SCM-246
> URL: http://jira.codehaus.org/browse/SCM-246
> Project: Maven SCM
> Issue Type: Bug
> Components: maven-scm-provider-perforce
> Environment: I tested this with whatever version came down by default & then with the lastest svn trunk. The fixes & affects versions available in this issue form don't seem to match the versions available.
> [tomp@tua maven-scm-provider-perforce]$ p4 -V
> Perforce - The Fast Software Configuration Management System.
> Copyright 1995-2006 Perforce Software. All rights reserved.
> Rev. P4/LINUX24X86/2006.1/101890 (2006/06/21).
> [tomp@tua maven-scm-provider-perforce]$ p4 info
> User name: tparker
> Client name: tua
> Client host: tua.uiactive.com
> Client unknown.
> Current directory: /u01/tomp/maven-scm/maven-scm-providers/maven-scm-provider-perforce
> Client address: 172.18.1.29:52715
> Server address: sydb.bullant.local:1666
> Server root: P:\P4ROOT
> Server date: 2006/10/31 16:47:50 +1100 AUS Eastern Daylight Time
> Server version: P4D/NTX86/2005.2/93627 (2006/02/14)
> Server license: Bullant Software (fka Bullant Technology - fna Softblocks Pty.) 40 users (support expired 2006/10/04)
> Reporter: Tom Parker
> Assignee: Vincent Siveton
> Fix For: 1.1.1
>
> Attachments: maven-scm-provider-perforce.patch
>
>
> This applies to most or all commands in maven-scm-provider-perforce. I was unable to fix some basic scm configuration issues until I downloaded the maven-scm-provider-perforce source and hacked it to consume and report the p4 command's stderr as well as stdout.
> The attached patch fixes the problem for diff, checkin, checkout and tag. My solution naively consumes stdout until it is finished and then consums stderr. This isn't ideal if the output order is significant, but for the errors situations I was dealing with, it worked fine. I had a brief search for an InputStreamMultiplexer but found nothing. I have included todos to improve this.
> There is much potential for reuse between the classes in maven-scm-provider-perforce, I have included todo's stating as such.
> I have not fixed all the perforce commands. Sorry.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira